[0/2] media: Introduce pixel format helpers

Message

Ezequiel Garcia March 28, 2019, 6:07 p.m. UTC

Following the "Add MPEG-2 decoding to Rockchip VPU"[1], and given we want to start
using the pixel format helpers rather soon, I've decided to submit them separatedly.

Aside from documenting the block_w and block_h, as suggested by Emil Velikov, these
two patches are unmodified compared to v2 [1].

This series contains the minimum patches to introduce the pixel format
helpers, it currently will have no users, but we expect users to start
popping-up soon.
very shortly [2].

To avoid confusing the patches here with those on v2 [1], I'm marking them as v3.

Thanks!

[1] https://patchwork.kernel.org/cover/10838327/
[2] https://patchwork.kernel.org/patch/10851639/

Ezequiel Garcia (2):
  rockchip/vpu: Rename pixel format helpers
  media: Introduce helpers to fill pixel format structs

 drivers/media/v4l2-core/v4l2-common.c         | 164 ++++++++++++++++++
 .../media/rockchip/vpu/rockchip_vpu_enc.c     |  12 +-
 include/media/v4l2-common.h                   |  33 ++++
 3 files changed, 203 insertions(+), 6 deletions(-)

Comments

Alexandre Courbot April 1, 2019, 7:25 a.m. UTC | #1

On Fri, Mar 29, 2019 at 3:08 AM Ezequiel Garcia <[e-mail]> wrote:
>
> Following the "Add MPEG-2 decoding to Rockchip VPU"[1], and given we want to start
> using the pixel format helpers rather soon, I've decided to submit them separatedly.
>
> Aside from documenting the block_w and block_h, as suggested by Emil Velikov, these
> two patches are unmodified compared to v2 [1].
>
> This series contains the minimum patches to introduce the pixel format
> helpers, it currently will have no users, but we expect users to start
> popping-up soon.
> very shortly [2].

Is there anything that prevents you from moving the Rockchip drivers
to using these right after patch 2/2? IIRC that's what your MPEG-2
series did initially, and that would introduce a user immediately.

Maxime Ripard April 1, 2019, 6:30 p.m. UTC | #2

Hi Ezequiel,

On Thu, Mar 28, 2019 at 03:07:02PM -0300, Ezequiel Garcia wrote:
> Following the "Add MPEG-2 decoding to Rockchip VPU"[1], and given we want to start
> using the pixel format helpers rather soon, I've decided to submit them separatedly.
>
> Aside from documenting the block_w and block_h, as suggested by Emil Velikov, these
> two patches are unmodified compared to v2 [1].
>
> This series contains the minimum patches to introduce the pixel format
> helpers, it currently will have no users, but we expect users to start
> popping-up soon.
> very shortly [2].
>
> To avoid confusing the patches here with those on v2 [1], I'm marking them as v3.

You might have missed it, but have you looked at the RFC "drm: Split
out the formats API and move it to a common place" I sent a couple of
weeks ago? It seems to cover the same use cases.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com