| Message ID | 20190716122718.125993-1-darekm@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: cec: convert DRM drivers to the new notifier API | expand |
Hi Dariusz, On 7/16/19 2:27 PM, Dariusz Marcinkiewicz wrote: > This series updates DRM drivers to use new CEC notifier API. > > Only first two patches were tested on the actual hardware. Thank you for this v4 and apologies for the delay in reviewing. A v5 is needed (my review of the tegra driver flagged a serious issue there, but it shouldn't be difficult to fix). My tentative plan is to do a final check second half of next week and merge it. So if you are able to make a v5 before that, then that would be very nice. Regards, Hans > > Changes since v3: > Updated adapter flags in dw-hdmi-cec. > Changes since v2: > Include all DRM patches from "cec: improve notifier support, > add connector info connector info" series. > Changes since v1: > Those patches delay creation of notifiers until respective > connectors are constructed. It seems that those patches, for a > couple of drivers, by adding the delay, introduce a race between > notifiers' creation and the IRQs handling threads - at least I > don't see anything obvious in there that would explicitly forbid > such races to occur. v2 adds a write barrier to make sure IRQ > threads see the notifier once it is created (replacing the > WRITE_ONCE I put in v1). The best thing to do here, I believe, > would be not to have any synchronization and make sure that an IRQ > only gets enabled after the notifier is created. > > Dariusz Marcinkiewicz (9): > drm_dp_cec: add connector info support. > drm/i915/intel_hdmi: use cec_notifier_conn_(un)register > dw-hdmi-cec: use cec_notifier_cec_adap_(un)register > tda9950: use cec_notifier_cec_adap_(un)register > drm: tda998x: use cec_notifier_conn_(un)register > drm: sti: use cec_notifier_conn_(un)register > drm: tegra: use cec_notifier_conn_(un)register > drm: dw-hdmi: use cec_notifier_conn_(un)register > drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register > > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 9 +++-- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 36 +++++++++++-------- > drivers/gpu/drm/drm_dp_cec.c | 25 ++++++++----- > drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++++------- > drivers/gpu/drm/i2c/tda9950.c | 11 +++--- > drivers/gpu/drm/i2c/tda998x_drv.c | 33 +++++++++++------ > drivers/gpu/drm/i915/intel_dp.c | 4 +-- > drivers/gpu/drm/i915/intel_hdmi.c | 13 ++++--- > drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +- > drivers/gpu/drm/sti/sti_hdmi.c | 19 ++++++---- > drivers/gpu/drm/tegra/output.c | 18 ++++++---- > include/drm/drm_dp_helper.h | 14 ++++---- > 13 files changed, 130 insertions(+), 88 deletions(-) >
This series updates DRM drivers to use new CEC notifier API. Only first two patches were tested on the actual hardware. Changes since v3: Updated adapter flags in dw-hdmi-cec. Changes since v2: Include all DRM patches from "cec: improve notifier support, add connector info connector info" series. Changes since v1: Those patches delay creation of notifiers until respective connectors are constructed. It seems that those patches, for a couple of drivers, by adding the delay, introduce a race between notifiers' creation and the IRQs handling threads - at least I don't see anything obvious in there that would explicitly forbid such races to occur. v2 adds a write barrier to make sure IRQ threads see the notifier once it is created (replacing the WRITE_ONCE I put in v1). The best thing to do here, I believe, would be not to have any synchronization and make sure that an IRQ only gets enabled after the notifier is created. Dariusz Marcinkiewicz (9): drm_dp_cec: add connector info support. drm/i915/intel_hdmi: use cec_notifier_conn_(un)register dw-hdmi-cec: use cec_notifier_cec_adap_(un)register tda9950: use cec_notifier_cec_adap_(un)register drm: tda998x: use cec_notifier_conn_(un)register drm: sti: use cec_notifier_conn_(un)register drm: tegra: use cec_notifier_conn_(un)register drm: dw-hdmi: use cec_notifier_conn_(un)register drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 9 +++-- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 36 +++++++++++-------- drivers/gpu/drm/drm_dp_cec.c | 25 ++++++++----- drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++++------- drivers/gpu/drm/i2c/tda9950.c | 11 +++--- drivers/gpu/drm/i2c/tda998x_drv.c | 33 +++++++++++------ drivers/gpu/drm/i915/intel_dp.c | 4 +-- drivers/gpu/drm/i915/intel_hdmi.c | 13 ++++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +- drivers/gpu/drm/sti/sti_hdmi.c | 19 ++++++---- drivers/gpu/drm/tegra/output.c | 18 ++++++---- include/drm/drm_dp_helper.h | 14 ++++---- 13 files changed, 130 insertions(+), 88 deletions(-)