From patchwork Thu Sep 19 20:41:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benoit Parrot X-Patchwork-Id: 11153309 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B013F76 for ; Thu, 19 Sep 2019 20:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8673421D56 for ; Thu, 19 Sep 2019 20:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="bs/93Jwt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392548AbfISUjW (ORCPT ); Thu, 19 Sep 2019 16:39:22 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:42632 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388901AbfISUjV (ORCPT ); Thu, 19 Sep 2019 16:39:21 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8JKdKnq116993; Thu, 19 Sep 2019 15:39:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1568925560; bh=RL8A9dz6TwS35t2dubytM8Akx1mLkbACo91LdijmYp0=; h=From:To:CC:Subject:Date; b=bs/93JwtMNTVDae9Pfo8yTABfpGHo+svWMQweZmB0dfUr89FkxGhjubDbxx2zVK8G 8UXI89l4s8L7/BlYLs72OIcWLIcf280fFzIafRxqKO2iz8qFpZ3o76IA9vpdRfMcQG SLvMJilpf0oW5sKFa6ZapXfHrmfbLWYaKuLFM+/U= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8JKdKiv002947 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Sep 2019 15:39:20 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 19 Sep 2019 15:39:16 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 19 Sep 2019 15:39:20 -0500 Received: from uda0869644b.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8JKdKIT014276; Thu, 19 Sep 2019 15:39:20 -0500 From: Benoit Parrot To: Hans Verkuil CC: Prabhakar Lad , , , , Benoit Parrot Subject: [Patch 00/13] media: am437x-vpfe: overdue maintenance Date: Thu, 19 Sep 2019 15:41:12 -0500 Message-ID: <20190919204125.15254-1-bparrot@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch series is a collection of patches we have been carrying for a while. A few patches do fix actual bug and v4l2-compliance errors/warnings. Other are drivers re-work to simplify/clarify the code for easier maintenance. We also include the SPDX Licensing update which seemed to have been missed by the global script thus far. Changes since v1: - Address review comment from Joe, Hans and Prabhakar - Cleaned-up the function entry debug log - Split off the pcr change into its own patch - Rework/combine two patches but remove code churn - fix miscellaneous typos ============================= v4l2-compliance SHA: 5b168dc8473911227890526bad26553d9e8ff81b, 32 bits Compliance test for vpfe device /dev/video0: Driver Info: Driver name : vpfe Card type : TI AM437x VPFE Bus info : platform:vpfe 48326000.vpfe Driver version : 5.3.0 Capabilities : 0x85200001 Vide o Capture Read/Write Streaming Extended Pix Format D evice Capabilities Device Caps : 0x05200001 Video Capt ure Read/Write Streaming Extended Pix Format Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls (Input 0): test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 3 Private Controls: 0 Format ioctls (Input 0): test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) fail: v4l2-test-formats.cpp(1419): node->frmsizes_count[pixfmt] > 1 test Cropping: FAIL test Composing: OK (Not Supported) test Scaling: OK (Not Supported) Codec ioctls (Input 0): test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls (Input 0): test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Test input 0: Streaming ioctls: test read/write: OK test blocking wait: OK test MMAP (no poll): OK test MMAP (select): OK test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total for vpfe device /dev/video0: 51, Succeeded: 50, Failed: 1, Warnings: 0 dd ============================ Benoit Parrot (12): media: am437x-vpfe: Fix missing first line media: am437x-vpfe: Rework ISR routine for clarity media: am437x-vpfe: Wait for end of frame before tear-down media: am437x-vpfe: fix start streaming error path media: am437x-vpfe: Streamlined vb2 buffer cleanup media: am437x-vpfe: Setting STD to current value is not an error media: am437x-vpfe: Use a per instance format array instead of a static one media: am437x-vpfe: fix function trace debug log media: am437x-vpfe: Remove print_fourcc helper media: am437x-vpfe: TRY_FMT ioctl is not really trying anything media: am437x-vpfe: Remove per bus width static data media: am437x-vpfe: Switch to SPDX Licensing Dave Gerlach (1): media: am437x-vpfe: Fix suspend path to always handle pinctrl config drivers/media/platform/am437x/am437x-vpfe.c | 878 ++++++++---------- drivers/media/platform/am437x/am437x-vpfe.h | 45 +- .../media/platform/am437x/am437x-vpfe_regs.h | 10 +- 3 files changed, 406 insertions(+), 527 deletions(-)