| Message ID | 20191009175628.20570-1-bparrot@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: dts: dra7: add vpe nodes | expand |
Tony, Ping, I already had comments from Rob but i would like your feedback before sending a v2. Regards, Benoit Benoit Parrot <bparrot@ti.com> wrote on Wed [2019-Oct-09 12:56:25 -0500]: > This patch series adds the needed clkctrl and ty-sysc nodes for VPE module. > We also document the VPE DT bindings. > > Benoit Parrot (3): > dt-bindings: media: ti-vpe: Document VPE driver > ARM: dts: dra7: add vpe clkctrl node > ARM: dts: dra7: Add ti-sysc node for VPE > > .../devicetree/bindings/media/ti-vpe.txt | 48 +++++++++++++++++++ > MAINTAINERS | 1 + > arch/arm/boot/dts/dra7-l4.dtsi | 30 ++++++++++-- > arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++- > drivers/clk/ti/clk-7xx.c | 6 +++ > include/dt-bindings/clock/dra7.h | 10 ++++ > 6 files changed, 108 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt > > -- > 2.17.1 >
* Benoit Parrot <bparrot@ti.com> [191022 16:28]: > Tony, > > Ping, > > I already had comments from Rob but i would like your feedback before > sending a v2. Looks good to me in general other than what Rob commented on. Did not spot any node naming issues here :) Regards, Tony
Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 09:30:48 -0700]: > * Benoit Parrot <bparrot@ti.com> [191022 16:28]: > > Tony, > > > > Ping, > > > > I already had comments from Rob but i would like your feedback before > > sending a v2. > > Looks good to me in general other than what Rob commented > on. Did not spot any node naming issues here :) Would I need to split off the clk*.c/.h as well here though? Benoit > > Regards, > > Tony
* Benoit Parrot <bparrot@ti.com> [191022 16:34]: > Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 09:30:48 -0700]: > > * Benoit Parrot <bparrot@ti.com> [191022 16:28]: > > > Tony, > > > > > > Ping, > > > > > > I already had comments from Rob but i would like your feedback before > > > sending a v2. > > > > Looks good to me in general other than what Rob commented > > on. Did not spot any node naming issues here :) > > Would I need to split off the clk*.c/.h as well here though? Yeah please do patches with just drivers/clk/ti and include/dt-bindings/clock changes in them. then Tero can queue them into an immutable branch that I can merge in too and use as a base for the dts changes. Regards, Tony
Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 09:37:54 -0700]: > * Benoit Parrot <bparrot@ti.com> [191022 16:34]: > > Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 09:30:48 -0700]: > > > * Benoit Parrot <bparrot@ti.com> [191022 16:28]: > > > > Tony, > > > > > > > > Ping, > > > > > > > > I already had comments from Rob but i would like your feedback before > > > > sending a v2. > > > > > > Looks good to me in general other than what Rob commented > > > on. Did not spot any node naming issues here :) > > > > Would I need to split off the clk*.c/.h as well here though? > > Yeah please do patches with just drivers/clk/ti and > include/dt-bindings/clock changes in them. then Tero > can queue them into an immutable branch that I can merge > in too and use as a base for the dts changes. Although the .h is in include/dt-binding. Does it still belong in the same patch as drivers/clk/ti/clk-7xx.c then? Just making sure.... > > Regards, > > Tony
* Benoit Parrot <bparrot@ti.com> [191022 16:45]: > Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 09:37:54 -0700]: > > * Benoit Parrot <bparrot@ti.com> [191022 16:34]: > > > Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 09:30:48 -0700]: > > > > * Benoit Parrot <bparrot@ti.com> [191022 16:28]: > > > > > Tony, > > > > > > > > > > Ping, > > > > > > > > > > I already had comments from Rob but i would like your feedback before > > > > > sending a v2. > > > > > > > > Looks good to me in general other than what Rob commented > > > > on. Did not spot any node naming issues here :) > > > > > > Would I need to split off the clk*.c/.h as well here though? > > > > Yeah please do patches with just drivers/clk/ti and > > include/dt-bindings/clock changes in them. then Tero > > can queue them into an immutable branch that I can merge > > in too and use as a base for the dts changes. > > Although the .h is in include/dt-binding. Does it still belong in the same > patch as drivers/clk/ti/clk-7xx.c then? > > Just making sure.... Yes if it's needed to compile the drivers/clk/ti patch. Otherwise it can stay with the dts changes. Regards, Tony