[0/6] media: fix USB descriptor issues

Message

Johan Hovold Jan. 3, 2020, 4:35 p.m. UTC

This series fixes a number of issues due to missing or incomplete sanity
checks that could lead to NULL-pointer dereferences, memory corruption
or driver misbehaviour when a device has unexpected descriptors.

Johan


Johan Hovold (6):
  media: flexcop-usb: fix endpoint sanity check
  media: ov519: add missing endpoint sanity checks
  media: stv06xx: add missing descriptor sanity checks
  media: xirlink_cit: add missing descriptor sanity checks
  media: dib0700: fix rc endpoint lookup
  media: iguanair: fix endpoint sanity check

 drivers/media/rc/iguanair.c                   |  2 +-
 drivers/media/usb/b2c2/flexcop-usb.c          |  6 +++---
 drivers/media/usb/dvb-usb/dib0700_core.c      |  4 ++--
 drivers/media/usb/gspca/ov519.c               | 10 ++++++++++
 drivers/media/usb/gspca/stv06xx/stv06xx.c     | 19 ++++++++++++++++++-
 .../media/usb/gspca/stv06xx/stv06xx_pb0100.c  |  4 ++++
 drivers/media/usb/gspca/xirlink_cit.c         | 18 +++++++++++++++++-
 7 files changed, 55 insertions(+), 8 deletions(-)

Comments

Johan Hovold Feb. 14, 2020, 8:02 a.m. UTC | #1

On Fri, Jan 03, 2020 at 05:35:07PM +0100, Johan Hovold wrote:
> This series fixes a number of issues due to missing or incomplete sanity
> checks that could lead to NULL-pointer dereferences, memory corruption
> or driver misbehaviour when a device has unexpected descriptors.

> Johan Hovold (6):
>   media: flexcop-usb: fix endpoint sanity check
>   media: ov519: add missing endpoint sanity checks
>   media: stv06xx: add missing descriptor sanity checks
>   media: xirlink_cit: add missing descriptor sanity checks
>   media: dib0700: fix rc endpoint lookup
>   media: iguanair: fix endpoint sanity check

Just sending a reminder about these as it seems only the last one has
made into mainline (and stable) yet.

Johan

Johan Hovold March 12, 2020, 11:23 a.m. UTC | #2

On Fri, Feb 14, 2020 at 09:02:54AM +0100, Johan Hovold wrote:
> On Fri, Jan 03, 2020 at 05:35:07PM +0100, Johan Hovold wrote:
> > This series fixes a number of issues due to missing or incomplete sanity
> > checks that could lead to NULL-pointer dereferences, memory corruption
> > or driver misbehaviour when a device has unexpected descriptors.
> 
> > Johan Hovold (6):
> >   media: flexcop-usb: fix endpoint sanity check
> >   media: ov519: add missing endpoint sanity checks
> >   media: stv06xx: add missing descriptor sanity checks
> >   media: xirlink_cit: add missing descriptor sanity checks
> >   media: dib0700: fix rc endpoint lookup
> >   media: iguanair: fix endpoint sanity check
> 
> Just sending a reminder about these as it seems only the last one has
> made into mainline (and stable) yet.

Another month, another reminder. Three of the above patches still hasn't
been applied.

Johan

Hans Verkuil March 12, 2020, 11:26 a.m. UTC | #3

On 3/12/20 12:23 PM, Johan Hovold wrote:
> On Fri, Feb 14, 2020 at 09:02:54AM +0100, Johan Hovold wrote:
>> On Fri, Jan 03, 2020 at 05:35:07PM +0100, Johan Hovold wrote:
>>> This series fixes a number of issues due to missing or incomplete sanity
>>> checks that could lead to NULL-pointer dereferences, memory corruption
>>> or driver misbehaviour when a device has unexpected descriptors.
>>
>>> Johan Hovold (6):
>>>   media: flexcop-usb: fix endpoint sanity check
>>>   media: ov519: add missing endpoint sanity checks
>>>   media: stv06xx: add missing descriptor sanity checks
>>>   media: xirlink_cit: add missing descriptor sanity checks
>>>   media: dib0700: fix rc endpoint lookup
>>>   media: iguanair: fix endpoint sanity check
>>
>> Just sending a reminder about these as it seems only the last one has
>> made into mainline (and stable) yet.
> 
> Another month, another reminder. Three of the above patches still hasn't
> been applied.

I've delegated these to me and will make a PR today/tomorrow.

Regards,

	Hans

Johan Hovold March 12, 2020, 11:29 a.m. UTC | #4

On Thu, Mar 12, 2020 at 12:26:35PM +0100, Hans Verkuil wrote:
> On 3/12/20 12:23 PM, Johan Hovold wrote:
> > On Fri, Feb 14, 2020 at 09:02:54AM +0100, Johan Hovold wrote:
> >> On Fri, Jan 03, 2020 at 05:35:07PM +0100, Johan Hovold wrote:
> >>> This series fixes a number of issues due to missing or incomplete sanity
> >>> checks that could lead to NULL-pointer dereferences, memory corruption
> >>> or driver misbehaviour when a device has unexpected descriptors.
> >>
> >>> Johan Hovold (6):
> >>>   media: flexcop-usb: fix endpoint sanity check
> >>>   media: ov519: add missing endpoint sanity checks
> >>>   media: stv06xx: add missing descriptor sanity checks
> >>>   media: xirlink_cit: add missing descriptor sanity checks
> >>>   media: dib0700: fix rc endpoint lookup
> >>>   media: iguanair: fix endpoint sanity check
> >>
> >> Just sending a reminder about these as it seems only the last one has
> >> made into mainline (and stable) yet.
> > 
> > Another month, another reminder. Three of the above patches still hasn't
> > been applied.
> 
> I've delegated these to me and will make a PR today/tomorrow.

Thanks, Hans!

Johan