| Message ID | 20200303234256.8928-1-slongerbeam@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: imx: Create media links in bound notifiers | expand |
Hi Sakari, When you have time can you review this series. TIA! Steve On 3/3/20 3:42 PM, Steve Longerbeam wrote: > Move media link creation into the notifier bound callbacks in the > minimum set of subdevices required by imx (imx5/6/7 CSI, > imx6/7 MIPI CSI-2, and video mux). > > History: > > v4: > - Removed the endpoint parsing callback APIs from video-mux and imx drivers > as suggested by Sakari, replacing with endpoint parsing local to the > drivers and the use of v4l2_async_notifier_add_fwnode_remote_subdev(). > As a result convenience function v4l2_async_register_fwnode_subdev() > is no longer used and is reverted. > > v3: > - The changes to the default behaviour in media_entity_get_fwnode_pad(), > and the fixes to current media drivers that call it inconsistently, have > been put-off to another time. Instead this version implements the > get_fwnode_pad operation where required in the imx and video-mux > subdevices to make media link creation work correctly. The > improvements to media_entity_get_fwnode_pad() can wait to another > patch series. > > v2: > - rename/move the notifier-to-state inlines in imx7-mipi-csis.c and > imx7-media-csi.c, suggested by Rui Silva. > - rewrite imx_media_create_links() to only add the missing media links > from the imx6 MIPI CSI-2 receiver. > > > Steve Longerbeam (17): > media: entity: Pass entity to get_fwnode_pad operation > media: video-mux: Parse information from firmware without using > callbacks > media: imx: Parse information from firmware without using callbacks > Revert "media: v4l2-fwnode: Add a convenience function for registering > subdevs with notifiers" > media: imx: csi: Implement get_fwnode_pad op > media: imx: mipi csi-2: Implement get_fwnode_pad op > media: video-mux: Implement get_fwnode_pad op > media: imx: Add imx_media_create_fwnode_pad_link() > media: video-mux: Create media links in bound notifier > media: imx: mipi csi-2: Create media links in bound notifier > media: imx7: mipi csis: Create media links in bound notifier > media: imx7: csi: Create media links in bound notifier > media: imx: csi: Create media links in bound notifier > media: imx: csi: Lookup upstream endpoint with > imx_media_get_pad_fwnode > media: imx: Create missing links from CSI-2 receiver > media: imx: silence a couple debug messages > media: imx: TODO: Remove media link creation todos > > drivers/media/mc/mc-entity.c | 2 +- > drivers/media/platform/video-mux.c | 185 ++++++++++++++++-- > drivers/media/v4l2-core/v4l2-fwnode.c | 62 ------ > drivers/staging/media/imx/TODO | 29 --- > drivers/staging/media/imx/imx-media-csi.c | 136 ++++++++----- > .../staging/media/imx/imx-media-dev-common.c | 50 ++--- > drivers/staging/media/imx/imx-media-dev.c | 2 +- > .../staging/media/imx/imx-media-internal-sd.c | 6 +- > drivers/staging/media/imx/imx-media-of.c | 114 ----------- > drivers/staging/media/imx/imx-media-utils.c | 124 ++++++++++++ > drivers/staging/media/imx/imx-media.h | 9 +- > drivers/staging/media/imx/imx6-mipi-csi2.c | 119 +++++++++-- > drivers/staging/media/imx/imx7-media-csi.c | 100 +++++++--- > drivers/staging/media/imx/imx7-mipi-csis.c | 105 +++++++--- > include/media/media-entity.h | 3 +- > include/media/v4l2-fwnode.h | 38 ---- > 16 files changed, 654 insertions(+), 430 deletions(-) >
Move media link creation into the notifier bound callbacks in the minimum set of subdevices required by imx (imx5/6/7 CSI, imx6/7 MIPI CSI-2, and video mux). History: v4: - Removed the endpoint parsing callback APIs from video-mux and imx drivers as suggested by Sakari, replacing with endpoint parsing local to the drivers and the use of v4l2_async_notifier_add_fwnode_remote_subdev(). As a result convenience function v4l2_async_register_fwnode_subdev() is no longer used and is reverted. v3: - The changes to the default behaviour in media_entity_get_fwnode_pad(), and the fixes to current media drivers that call it inconsistently, have been put-off to another time. Instead this version implements the get_fwnode_pad operation where required in the imx and video-mux subdevices to make media link creation work correctly. The improvements to media_entity_get_fwnode_pad() can wait to another patch series. v2: - rename/move the notifier-to-state inlines in imx7-mipi-csis.c and imx7-media-csi.c, suggested by Rui Silva. - rewrite imx_media_create_links() to only add the missing media links from the imx6 MIPI CSI-2 receiver. Steve Longerbeam (17): media: entity: Pass entity to get_fwnode_pad operation media: video-mux: Parse information from firmware without using callbacks media: imx: Parse information from firmware without using callbacks Revert "media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers" media: imx: csi: Implement get_fwnode_pad op media: imx: mipi csi-2: Implement get_fwnode_pad op media: video-mux: Implement get_fwnode_pad op media: imx: Add imx_media_create_fwnode_pad_link() media: video-mux: Create media links in bound notifier media: imx: mipi csi-2: Create media links in bound notifier media: imx7: mipi csis: Create media links in bound notifier media: imx7: csi: Create media links in bound notifier media: imx: csi: Create media links in bound notifier media: imx: csi: Lookup upstream endpoint with imx_media_get_pad_fwnode media: imx: Create missing links from CSI-2 receiver media: imx: silence a couple debug messages media: imx: TODO: Remove media link creation todos drivers/media/mc/mc-entity.c | 2 +- drivers/media/platform/video-mux.c | 185 ++++++++++++++++-- drivers/media/v4l2-core/v4l2-fwnode.c | 62 ------ drivers/staging/media/imx/TODO | 29 --- drivers/staging/media/imx/imx-media-csi.c | 136 ++++++++----- .../staging/media/imx/imx-media-dev-common.c | 50 ++--- drivers/staging/media/imx/imx-media-dev.c | 2 +- .../staging/media/imx/imx-media-internal-sd.c | 6 +- drivers/staging/media/imx/imx-media-of.c | 114 ----------- drivers/staging/media/imx/imx-media-utils.c | 124 ++++++++++++ drivers/staging/media/imx/imx-media.h | 9 +- drivers/staging/media/imx/imx6-mipi-csi2.c | 119 +++++++++-- drivers/staging/media/imx/imx7-media-csi.c | 100 +++++++--- drivers/staging/media/imx/imx7-mipi-csis.c | 105 +++++++--- include/media/media-entity.h | 3 +- include/media/v4l2-fwnode.h | 38 ---- 16 files changed, 654 insertions(+), 430 deletions(-)