From patchwork Thu Mar 26 21:47:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11461289 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C93C0161F for ; Thu, 26 Mar 2020 21:47:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9C2020774 for ; Thu, 26 Mar 2020 21:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="AIchzlcQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727607AbgCZVr5 (ORCPT ); Thu, 26 Mar 2020 17:47:57 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:11057 "EHLO mail1.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbgCZVrr (ORCPT ); Thu, 26 Mar 2020 17:47:47 -0400 Date: Thu, 26 Mar 2020 21:47:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1585259265; bh=4BPIxWPyres3GFbgESbi2yyrYHq3xdFWvkhO5abjycM=; h=Date:To:From:Cc:Reply-To:Subject:From; b=AIchzlcQWknZzxxaLpAjVULTMlyFmWDlWaLkX5LSrNElDYJId22oT2cAGJQawuHXP H+YL6oKanc+gojwIqei9SQW2cxolS+cE7uNdDh2F//cGTf3MGpRd8NuUppY3vvODIE rfONMv9gbbbfKSXkXVkMKuJFh1JfSj/l0oaIu4jE= To: linux-media@vger.kernel.org From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Helen Koike , Shuah Khan , Mauro Carvalho Chehab , Hans Verkuil , linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org Reply-To: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Subject: [PATCH v2 0/3] media: vimc: Add support for {RGB,BGR,GBR}888 bus formats on debayer source pad Message-ID: <20200326214730.2449707-1-nfraprado@protonmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch series adds support for the missing RGB888_*, BGR888_* and GBR888_* media bus formats on the source pad of debayer subdevices of the vimc driver. These additional bus formats enable a wider range of formats to be configured on the topologies, making it possible to test more real use cases. It also enables video to be streamed in the BGR pixelformat on /dev/video3. The first patch makes it possible to have multiple media bus codes mapping to the same pixelformat, so that, for example, all RGB888_* media bus formats use the same RGB24 pixelformat. The second patch maps the missing RGB888_*, BGR888_* and GBR888_* media bus codes to the RGB24 and BGR24 pixelformats. Since there isn't a GBR24 pixelformat, the GBR888_1X24 bus code maps to the RGB24 pixelformat. The third patch enables the source pad of the debayer subdevice to use the added media bus formats. This patch series passed all tests of v4l2-compliance: $ compliance_git -m /dev/media0 v4l2-compliance SHA: 81e45d957c4db39397f893100b3d2729ef39b052, 64 bits, 64-bit time_t Grand Total for vimc device /dev/media0: 461, Succeeded: 461, Failed: 0, Warnings: 0 As a side note, when listing the pads containing the new formats added, I noticed that MEDIA_BUS_FMT_RGB888_3X8 doesn't have its name displayed by v4l2-ctl, but from my understanding that should be a bug in v4l-utils. $ v4l2-ctl -d /dev/v4l-subdev2 --list-subdev-mbus-codes 1 ioctl: VIDIOC_SUBDEV_ENUM_MBUS_CODE (pad=1) 0x1014: MEDIA_BUS_FMT_GBR888_1X24 0x1013: MEDIA_BUS_FMT_BGR888_1X24 0x101b: MEDIA_BUS_FMT_BGR888_3X8 0x100a: MEDIA_BUS_FMT_RGB888_1X24 0x100b: MEDIA_BUS_FMT_RGB888_2X12_BE 0x100c: MEDIA_BUS_FMT_RGB888_2X12_LE 0x101c 0x1011: MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1012: MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x100f: MEDIA_BUS_FMT_RGB888_1X32_PADHI Changes in v2: - Fix vimc_mbus_code_by_index not checking code array bounds - Change commit messages to reflect v2 changes - Suggested by Helen: - Rename variables - Fix array formatting - Change code array size - Add comment about vimc_mbus_code_by_index return value - Add vimc_deb_is_src_code_valid function - Add other BGR888 and RGB888 formats to BGR24 and RGB24 pixelformats - Add other BGR888 and RGB888 formats to debayer source pad supported formats - Suggested by Ezequiel: - Change cover letter to better explain this patch series You can find v1 here: https://patchwork.linuxtv.org/cover/61391/ Nícolas F. R. A. Prado (3): media: vimc: Support multiple media bus codes for each pixelformat media: vimc: Add missing {RGB,BGR,GBR}888 media bus codes media: vimc: deb: Add support for {RGB,BGR,GBR}888 bus formats on source pad drivers/media/platform/vimc/vimc-common.c | 82 +++++++++++++++------- drivers/media/platform/vimc/vimc-common.h | 11 ++- drivers/media/platform/vimc/vimc-debayer.c | 61 ++++++++++++---- drivers/media/platform/vimc/vimc-scaler.c | 10 ++- drivers/media/platform/vimc/vimc-sensor.c | 6 +- 5 files changed, 126 insertions(+), 44 deletions(-)