| Message ID | 20200503220618.27743-1-jmkrzyszt@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: ov6650: Fix crop rectangle affected by set format | expand |
Hi Sakari, I've seen this series, as well as my two other patches sent shortly after, assigned to you on V4L2 patchwork. Have you already had a chance to look at them? Have you any comments? I'm assuming there is no need to resend them. I'm asking because I still have a few ov650 patches in my queue which depend no those already submitted. I'd like to be sure I'm not going into wrong direction before submitting more. Thanks, Janusz On Monday, May 4, 2020 12:06:15 A.M. CEST Janusz Krzysztofik wrote: > According to subdevice interface specification found in V4L2 API > documentation, set format pad operations should not affect image > geometry set in preceding image processing steps. Unfortunately, that > requirement is not respected by the driver implementation of set format > as it was not the case when that code was still implementing a pair of > now obsolete .s_mbus_fmt() / .try_mbus_fmt() video operations before > they have been merged and reused as an implementation of .set_fmt() pad > operation by commit 717fd5b4907a ("[media] v4l2: replace try_mbus_fmt > by set_fmt"). > > In case of set format active processing path the issue can be fixed > easily by excluding a call to set active selection from that path. That > will effectively limit frame size processing to optimal frame scaling > against active crop rectangle without touching it. Users can just call > set active selection themselves to obtain desired frame size. However, > set format try processing path needs more work. > > First of all, the driver should be extended with set try selection > support. Lack of it constraints video device drivers to not use > subdevice cropping at all while processing user requested active frame > size, otherwise their set try format results might differ from active. > > Next, set format try processing path should use pad config crop > rectangle as a reference, not the active one as it does now. That > issue can be resolved easily as soon as set try selection support is > added to the driver so pad config crop rectangle can be maintained by > users via selection API. > > Last, set format try processing path should give the same results as > active in respect to active vs. pad config crop rectangle geometry. > Both rectangles should be either not touched by set format (that's what > we are going to achieve) or modified the same way, otherwise users > won't be able to obtain equal results from both paths while iterating > through set format and set selection operations in order to obtain > desired frame size. > > We can't begin with modifying set format pad operation as not to touch > crop rectangle since that depends on availability of set try selection > for symmetry. Neither can we begin with adding set try selection since > that in turn depends on equal handling of active and pad config crop > rectangles by set format. We can either implement all required > modifications in a single patch, or begin with fixing current set > format try processing path to appropriately handle pad config crop > rectangle. > > This series implements the latter approach as believed to be more > readable. However, the patches can be squashed if so decided by > subsystem maintainers. > > Janusz Krzysztofik (3): > media: ov6650: Fix set format try processing path > media: ov6650: Add try support to selection API operations > media: ov6650: Fix crop rectangle affected by set format > > drivers/media/i2c/ov6650.c | 115 ++++++++++++++++++++++--------------- > 1 file changed, 70 insertions(+), 45 deletions(-) > >
According to subdevice interface specification found in V4L2 API documentation, set format pad operations should not affect image geometry set in preceding image processing steps. Unfortunately, that requirement is not respected by the driver implementation of set format as it was not the case when that code was still implementing a pair of now obsolete .s_mbus_fmt() / .try_mbus_fmt() video operations before they have been merged and reused as an implementation of .set_fmt() pad operation by commit 717fd5b4907a ("[media] v4l2: replace try_mbus_fmt by set_fmt"). In case of set format active processing path the issue can be fixed easily by excluding a call to set active selection from that path. That will effectively limit frame size processing to optimal frame scaling against active crop rectangle without touching it. Users can just call set active selection themselves to obtain desired frame size. However, set format try processing path needs more work. First of all, the driver should be extended with set try selection support. Lack of it constraints video device drivers to not use subdevice cropping at all while processing user requested active frame size, otherwise their set try format results might differ from active. Next, set format try processing path should use pad config crop rectangle as a reference, not the active one as it does now. That issue can be resolved easily as soon as set try selection support is added to the driver so pad config crop rectangle can be maintained by users via selection API. Last, set format try processing path should give the same results as active in respect to active vs. pad config crop rectangle geometry. Both rectangles should be either not touched by set format (that's what we are going to achieve) or modified the same way, otherwise users won't be able to obtain equal results from both paths while iterating through set format and set selection operations in order to obtain desired frame size. We can't begin with modifying set format pad operation as not to touch crop rectangle since that depends on availability of set try selection for symmetry. Neither can we begin with adding set try selection since that in turn depends on equal handling of active and pad config crop rectangles by set format. We can either implement all required modifications in a single patch, or begin with fixing current set format try processing path to appropriately handle pad config crop rectangle. This series implements the latter approach as believed to be more readable. However, the patches can be squashed if so decided by subsystem maintainers. Janusz Krzysztofik (3): media: ov6650: Fix set format try processing path media: ov6650: Add try support to selection API operations media: ov6650: Fix crop rectangle affected by set format drivers/media/i2c/ov6650.c | 115 ++++++++++++++++++++++--------------- 1 file changed, 70 insertions(+), 45 deletions(-)