From patchwork Thu Jun 11 16:16:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11600389 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9392B912 for ; Thu, 11 Jun 2020 16:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 843B520792 for ; Thu, 11 Jun 2020 16:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726306AbgFKQNl (ORCPT ); Thu, 11 Jun 2020 12:13:41 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:39671 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgFKQNl (ORCPT ); Thu, 11 Jun 2020 12:13:41 -0400 X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id E1869C0006; Thu, 11 Jun 2020 16:13:35 +0000 (UTC) From: Jacopo Mondi To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com Cc: Jacopo Mondi , niklas.soderlund+renesas@ragnatech.se, kieran.bingham@ideasonboard.com, dave.stevenson@raspberrypi.com, hyun.kwon@xilinx.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH v4 0/9] v4l2-subdev: Introduce [g|s]et_mbus_format pad op Date: Thu, 11 Jun 2020 18:16:42 +0200 Message-Id: <20200611161651.264633-1-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello in this v4 I have addressed few minor comments received on v3, but mostly, this new version removes g|s_mbus_config video operations instead of just deprecating them. I also changed a few things in the pxa and ov6650 drivers, ported to use the new operations. Quiting v3 cover letter: ------------------------------------------------------------------------------- Most of the existing users are i2c camera drivers reporting a static media bus configuration though g_mbus_config. Porting them is performed in a single hopefully not controversial patch [2/8] Two existing users stand-out, and they've probably been developed together: pxa_camera and ov6650. Those have bee ported separately in single patches with extensive change logs as their operations semantic had to change to port them to use the new operations. Not having any of those two platforms, the changes have been compile-tested only. The only existing users of the s|g_mbus_config ops are now the soc_camera based drivers currently living in staging. The last three patches are similar to the ones posted in v2, with the exception that they have been updated to use the V4L2_MBUS_* flags as well. ------------------------------------------------------------------------------- Will report again the use cases I'm trying to address here: ------------------------------------------------------------------------------ Quoting: https://patchwork.kernel.org/cover/10855919/ "The use case this series cover is the following one: the Gen-3 R-Car boards include an ADV748x HDMI/CVBS to CSI-2 converter connected to its CSI-2 receivers. The ADV748x chip has recently gained support for routing both HDMI and analogue video streams through its 4 lanes TXA transmitter, specifically to support the Ebisu board that has a single CSI-2 receiver, compared to all other Gen-3 board where the ADV748x TXes are connected to different CSI-2 receivers, and where analogue video is streamed out from the ADV748x single lane TXB transmitter. To properly support transmission of analogue video through TXA, the number of data lanes shall be dynamically reduced to 1, in order to comply with the MIPI CSI-2 minimum clock frequency requirements" During the discussion of the RFC, Dave reported another use case for media bus parameter negotiation on his platform: https://patchwork.kernel.org/patch/10855923/#22569149 Hyun is now using this series to configure GMSL devices. ------------------------------------------------------------------------------ Thanks j v3->v4: - Remove g/s_mbus_config video operation - Adjust pxa quick capture interface to properly handle bus mastering - Reword the two new operations documentation v2->v3: - Re-use v4l2_mbus_config and V4L2_MBUS_* flags - Port existing drivers - Update adv748x and rcar-csi2 patches to use V4L2_MBUS_* flags v1->v2: - Address Sakari's comment to use unsigned int in place of bools - Add two new patches to address documentation - Adjust rcar-csi2 patch as much as possible according to Niklas comments - Add Niklas's tags Jacopo Mondi (9): media: v4l2-subdv: Introduce [get|set]_mbus_config pad ops media: i2c: Use the new get_mbus_config pad op media: i2c: ov6650: Use new [get|set]_mbus_config ops media: pxa_camera: Use the new set_mbus_config op media: v4l2-subdev: Remove [s|g]_mbus_config video ops staging: media: imx: Update TODO entry media: i2c: adv748x: Adjust TXA data lanes number media: i2c: adv748x: Implement get_mbus_config media: rcar-csi2: Negotiate data lanes number drivers/media/i2c/adv7180.c | 7 +- drivers/media/i2c/adv748x/adv748x-core.c | 31 +++- drivers/media/i2c/adv748x/adv748x-csi2.c | 31 ++++ drivers/media/i2c/adv748x/adv748x.h | 1 + drivers/media/i2c/ml86v7667.c | 7 +- drivers/media/i2c/mt9m001.c | 7 +- drivers/media/i2c/mt9m111.c | 7 +- drivers/media/i2c/ov6650.c | 56 ++++-- drivers/media/i2c/ov9640.c | 7 +- drivers/media/i2c/tc358743.c | 7 +- drivers/media/i2c/tvp5150.c | 7 +- drivers/media/platform/pxa_camera.c | 189 ++++++-------------- drivers/media/platform/rcar-vin/rcar-csi2.c | 61 ++++++- drivers/staging/media/imx/TODO | 4 + include/media/v4l2-subdev.h | 37 ++-- 15 files changed, 263 insertions(+), 196 deletions(-) --- 2.27.0