mbox series

[v2,0/4] Tegra Video Decoder driver power management corrections

Message ID 20200624150847.22672-1-digetx@gmail.com (mailing list archive)
Headers show
Series Tegra Video Decoder driver power management corrections | expand

Message

Dmitry Osipenko June 24, 2020, 3:08 p.m. UTC
Hello,

This small series addresses a Runtime PM issue that was discovered during
of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
failure. Secondly it fixes reboot on some Tegra devices due to bootloader
expecting VDE power partition to be ON at the boot time, which wasn't
happening in case of a warm re-booting (i.e. by PMC resetting).

Changelog:

v2: - Extended the commit's message of the "Balance runtime PM use-count on
      resume failure" patch.

    - Re-send for 5.9 inclusion.

Dmitry Osipenko (4):
  media: staging: tegra-vde: Balance runtime PM use-count on resume
    failure
  media: staging: tegra-vde: Runtime PM is always available on Tegra
  media: staging: tegra-vde: Turn ON power domain on shutdown
  media: staging: tegra-vde: Power-cycle hardware on probe

 drivers/staging/media/tegra-vde/vde.c | 45 +++++++++++++++++----------
 1 file changed, 29 insertions(+), 16 deletions(-)

Comments

Hans Verkuil June 24, 2020, 3:16 p.m. UTC | #1
On 24/06/2020 17:08, Dmitry Osipenko wrote:
> Hello,
> 
> This small series addresses a Runtime PM issue that was discovered during
> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
> failure. Secondly it fixes reboot on some Tegra devices due to bootloader
> expecting VDE power partition to be ON at the boot time, which wasn't
> happening in case of a warm re-booting (i.e. by PMC resetting).

Can you rebase this on top of the media_tree master branch? I think a variant
of patch 1 has already been applied. I found a mail today where you mentioned
that you preferred your version (it looks like I missed that) so you'll need to
rework patch 1.

Sorry about this,

	Hans

> 
> Changelog:
> 
> v2: - Extended the commit's message of the "Balance runtime PM use-count on
>       resume failure" patch.
> 
>     - Re-send for 5.9 inclusion.
> 
> Dmitry Osipenko (4):
>   media: staging: tegra-vde: Balance runtime PM use-count on resume
>     failure
>   media: staging: tegra-vde: Runtime PM is always available on Tegra
>   media: staging: tegra-vde: Turn ON power domain on shutdown
>   media: staging: tegra-vde: Power-cycle hardware on probe
> 
>  drivers/staging/media/tegra-vde/vde.c | 45 +++++++++++++++++----------
>  1 file changed, 29 insertions(+), 16 deletions(-)
>
Dmitry Osipenko June 24, 2020, 3:23 p.m. UTC | #2
24.06.2020 18:16, Hans Verkuil пишет:
> On 24/06/2020 17:08, Dmitry Osipenko wrote:
>> Hello,
>>
>> This small series addresses a Runtime PM issue that was discovered during
>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
>> failure. Secondly it fixes reboot on some Tegra devices due to bootloader
>> expecting VDE power partition to be ON at the boot time, which wasn't
>> happening in case of a warm re-booting (i.e. by PMC resetting).
> 
> Can you rebase this on top of the media_tree master branch? I think a variant
> of patch 1 has already been applied. I found a mail today where you mentioned
> that you preferred your version (it looks like I missed that) so you'll need to
> rework patch 1.

Hello Hans,

I'll take a look at what patches has been applied, my bad for sending
the v2 too late. Thank you for the heads up!
Dmitry Osipenko June 26, 2020, 12:17 a.m. UTC | #3
24.06.2020 18:23, Dmitry Osipenko пишет:
> 24.06.2020 18:16, Hans Verkuil пишет:
>> On 24/06/2020 17:08, Dmitry Osipenko wrote:
>>> Hello,
>>>
>>> This small series addresses a Runtime PM issue that was discovered during
>>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
>>> failure. Secondly it fixes reboot on some Tegra devices due to bootloader
>>> expecting VDE power partition to be ON at the boot time, which wasn't
>>> happening in case of a warm re-booting (i.e. by PMC resetting).
>>
>> Can you rebase this on top of the media_tree master branch? I think a variant
>> of patch 1 has already been applied. I found a mail today where you mentioned
>> that you preferred your version (it looks like I missed that) so you'll need to
>> rework patch 1.
> 
> Hello Hans,
> 
> I'll take a look at what patches has been applied, my bad for sending
> the v2 too late. Thank you for the heads up!
> 

I tested the already-applied variant of the patch 1 and it has the same
behaviour as my variant, so it's okay.

Would you want me to send a v3 without the conflicting patch 1 or you
could apply the patches 2-4 from this series?
Hans Verkuil June 26, 2020, 6:58 a.m. UTC | #4
On 26/06/2020 02:17, Dmitry Osipenko wrote:
> 24.06.2020 18:23, Dmitry Osipenko пишет:
>> 24.06.2020 18:16, Hans Verkuil пишет:
>>> On 24/06/2020 17:08, Dmitry Osipenko wrote:
>>>> Hello,
>>>>
>>>> This small series addresses a Runtime PM issue that was discovered during
>>>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
>>>> failure. Secondly it fixes reboot on some Tegra devices due to bootloader
>>>> expecting VDE power partition to be ON at the boot time, which wasn't
>>>> happening in case of a warm re-booting (i.e. by PMC resetting).
>>>
>>> Can you rebase this on top of the media_tree master branch? I think a variant
>>> of patch 1 has already been applied. I found a mail today where you mentioned
>>> that you preferred your version (it looks like I missed that) so you'll need to
>>> rework patch 1.
>>
>> Hello Hans,
>>
>> I'll take a look at what patches has been applied, my bad for sending
>> the v2 too late. Thank you for the heads up!
>>
> 
> I tested the already-applied variant of the patch 1 and it has the same
> behaviour as my variant, so it's okay.
> 
> Would you want me to send a v3 without the conflicting patch 1 or you
> could apply the patches 2-4 from this series?
> 

I'll mark 1/4 as superseded and will apply patches 2-4. No need for you
to do anything.

Regards,

	Hans
Dmitry Osipenko June 26, 2020, 1:23 p.m. UTC | #5
26.06.2020 09:58, Hans Verkuil пишет:
> On 26/06/2020 02:17, Dmitry Osipenko wrote:
>> 24.06.2020 18:23, Dmitry Osipenko пишет:
>>> 24.06.2020 18:16, Hans Verkuil пишет:
>>>> On 24/06/2020 17:08, Dmitry Osipenko wrote:
>>>>> Hello,
>>>>>
>>>>> This small series addresses a Runtime PM issue that was discovered during
>>>>> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume
>>>>> failure. Secondly it fixes reboot on some Tegra devices due to bootloader
>>>>> expecting VDE power partition to be ON at the boot time, which wasn't
>>>>> happening in case of a warm re-booting (i.e. by PMC resetting).
>>>>
>>>> Can you rebase this on top of the media_tree master branch? I think a variant
>>>> of patch 1 has already been applied. I found a mail today where you mentioned
>>>> that you preferred your version (it looks like I missed that) so you'll need to
>>>> rework patch 1.
>>>
>>> Hello Hans,
>>>
>>> I'll take a look at what patches has been applied, my bad for sending
>>> the v2 too late. Thank you for the heads up!
>>>
>>
>> I tested the already-applied variant of the patch 1 and it has the same
>> behaviour as my variant, so it's okay.
>>
>> Would you want me to send a v3 without the conflicting patch 1 or you
>> could apply the patches 2-4 from this series?
>>
> 
> I'll mark 1/4 as superseded and will apply patches 2-4. No need for you
> to do anything.

Thank you!