| Message ID | 20200821145935.20346-1-kevin.lhopital@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support of MIPI CSI-2 for A83T and OV8865 camera | expand |
Hi, On Fri, Aug 21, 2020 at 04:59:28PM +0200, Kévin L'hôpital wrote: > > Kévin L'hôpital (7): > media: sun6i-csi: Fix the bpp for 10-bit bayer formats > dt-bindings: media: i2c: Add documentation for ov8865 > media: i2c: Add support for the OV8865 image sensor > media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the > common header > media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T > ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node > [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 > camera You should have a cover letter here to provide some context. There's a bunch of things that would need to be explained and / or argued for here, in particular: - Why did you need to plumb it into sun6i-csi? - You're naming the CSI part as the A83t CSI, while MIPI-CSI has been supported since the A31(?), is there a reason for that? - This is not documented anywhere, what did you base this work on? Also, I think that documenting the general challenges you faced (which were likely because of the first bullet point above) and how you solved them here would be great to start a discussion if needed. Finally, iirc, Hans requires a v4l2-compliance run for any new driver, which isn't strictly the case for this driver, but isn't really *not* the case either. Maxime
Le Mon, 24 Aug 2020 18:52:44 +0200, Maxime Ripard <maxime@cerno.tech> a écrit : > Hi, > > On Fri, Aug 21, 2020 at 04:59:28PM +0200, Kévin L'hôpital wrote: > > > > Kévin L'hôpital (7): > > media: sun6i-csi: Fix the bpp for 10-bit bayer formats > > dt-bindings: media: i2c: Add documentation for ov8865 > > media: i2c: Add support for the OV8865 image sensor > > media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the > > common header > > media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T > > ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node > > [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 > > camera > > You should have a cover letter here to provide some context. > > There's a bunch of things that would need to be explained and / or > argued for here, in particular: > - Why did you need to plumb it into sun6i-csi? > - You're naming the CSI part as the A83t CSI, while MIPI-CSI has > been supported since the A31(?), is there a reason for that? > - This is not documented anywhere, what did you base this work on? > > Also, I think that documenting the general challenges you faced (which > were likely because of the first bullet point above) and how you > solved them here would be great to start a discussion if needed. > > Finally, iirc, Hans requires a v4l2-compliance run for any new driver, > which isn't strictly the case for this driver, but isn't really *not* > the case either. > > Maxime Thank you very much for the review, I will add all this context. Kévin
Kévin L'hôpital (7): media: sun6i-csi: Fix the bpp for 10-bit bayer formats dt-bindings: media: i2c: Add documentation for ov8865 media: i2c: Add support for the OV8865 image sensor media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the common header media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 camera .../devicetree/bindings/media/i2c/ov8865.txt | 51 + arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 99 + arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov8865.c | 2540 +++++++++++++++++ .../media/platform/sunxi/sun6i-csi/Makefile | 2 +- .../platform/sunxi/sun6i-csi/sun6i_csi.c | 94 +- .../platform/sunxi/sun6i-csi/sun6i_csi.h | 14 +- .../sunxi/sun6i-csi/sun8i_a83t_dphy.c | 20 + .../sunxi/sun6i-csi/sun8i_a83t_dphy.h | 16 + .../sunxi/sun6i-csi/sun8i_a83t_dphy_reg.h | 15 + .../sunxi/sun6i-csi/sun8i_a83t_mipi_csi2.c | 249 ++ .../sunxi/sun6i-csi/sun8i_a83t_mipi_csi2.h | 16 + .../sun6i-csi/sun8i_a83t_mipi_csi2_reg.h | 42 + 15 files changed, 3148 insertions(+), 34 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8865.txt create mode 100644 drivers/media/i2c/ov8865.c create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_dphy.c create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_dphy.h create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_dphy_reg.h create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_mipi_csi2.c create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_mipi_csi2.h create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_mipi_csi2_reg.h