[v3,0/8] ipu3-cio2 format and other fixes

Message

Sakari Ailus Oct. 12, 2020, 6:04 p.m. UTC

Hello all,

This set addresses most notable subdev format related issues, namely the
sub-device sink format being unaccessible. The result of accessing it
varied from oopses to crashes.

since v2:

- Cc the fixes to the stable tree, cleanups to master only

- Add the size checks first, then make size (as well as a bunch of other
  constants) unsigned. Then remove the explicit type from size checks.

- Add a patch to rename the length macro as height (which it really
  is about)

- Add a patch to remove driver queue references to buffers returned to
  vb2 (cc that to stable, too).

since v1:

- Validate try format, too

- Set field in subdev format to V4L2_FIELD_NONE

- Add a comment explaining the lock

- Make values that should be unsigned, unsigned

Sakari Ailus (8):
  ipu3-cio2: Return actual subdev format
  ipu3-cio2: Serialise access to pad format
  ipu3-cio2: Validate mbus format in setting subdev format
  ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE
  ipu3-cio2: Use unsigned values where appropriate
  ipu3-cio2: Remove explicit type from frame size checks
  ipu3-cio2: Rename CIO2_IMAGE_MAX_LENGTH as CIO2_IMAGE_MAX_HEIGHT
  ipu3-cio2: Remove traces of returned buffers

 drivers/media/pci/intel/ipu3/ipu3-cio2.c |  65 +++++-----
 drivers/media/pci/intel/ipu3/ipu3-cio2.h | 157 ++++++++++++-----------
 2 files changed, 114 insertions(+), 108 deletions(-)