[v2,0/4] media: allegro: move driver out of staging

Message

Michael Tretter Dec. 2, 2020, 1:30 p.m. UTC

Hello,

With the V4L2 stateful encoder spec being finished, the Allegro encoder driver
is ready to be moved from staging to mainline.

While not directly related, I used the opportunity to convert the dt-binding
to YAML, to remove the custom draining state handling from the driver and to
rename a badly named field in the MCU messages.

v2 fixes the reported warnings in the YAML dt-bindings.

There are no functional changes in the actual driver since v1, but I am
sending the updated v4l2-compliance result anyway.

Michael

v4l2-compliance 1.21.0-4683, 64 bits, 64-bit time_t
v4l2-compliance SHA: 0aee9991e0c0 2020-12-01 09:48:02

Compliance test for allegro device /dev/video3:

Driver Info:
	Driver name      : allegro
	Card type        : Allegro DVT Video Encoder
	Bus info         : platform:a0009000.video-codec
	Driver version   : 5.10.0
	Capabilities     : 0x84208000
		Video Memory-to-Memory
		Streaming
		Extended Pix Format
		Device Capabilities
	Device Caps      : 0x04208000
		Video Memory-to-Memory
		Streaming
		Extended Pix Format
	Detected Stateful Encoder

Required ioctls:
	test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
	test second /dev/video3 open: OK
	test VIDIOC_QUERYCAP: OK
	test VIDIOC_G/S_PRIORITY: OK
	test for unlimited opens: OK

	test invalid ioctls: OK
Debug ioctls:
	test VIDIOC_DBG_G/S_REGISTER: OK
	test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
	test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
	test VIDIOC_ENUMAUDIO: OK (Not Supported)
	test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDIO: OK (Not Supported)
	Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
	test VIDIOC_G/S_MODULATOR: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_ENUMAUDOUT: OK (Not Supported)
	test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDOUT: OK (Not Supported)
	Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
	test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
	test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
	test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
	test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
	test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
	test VIDIOC_QUERYCTRL: OK
	test VIDIOC_G/S_CTRL: OK
	test VIDIOC_G/S/TRY_EXT_CTRLS: OK
	test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
	test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
	Standard Controls: 16 Private Controls: 0

Format ioctls:
	test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
	test VIDIOC_G/S_PARM: OK
	test VIDIOC_G_FBUF: OK (Not Supported)
	test VIDIOC_G_FMT: OK
	test VIDIOC_TRY_FMT: OK
	test VIDIOC_S_FMT: OK
	test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
	test Cropping: OK (Not Supported)
	test Composing: OK (Not Supported)
	test Scaling: OK (Not Supported)

Codec ioctls:
	test VIDIOC_(TRY_)ENCODER_CMD: OK
	test VIDIOC_G_ENC_INDEX: OK (Not Supported)
	test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
	test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
	test VIDIOC_EXPBUF: OK
	test Requests: OK (Not Supported)

Test input 0:

Streaming ioctls:
	test read/write: OK (Not Supported)
	test blocking wait: OK
	Video Capture: Captured 60 buffers
	test MMAP (select): OK
	Video Capture: Captured 60 buffers
	test MMAP (epoll): OK
	test USERPTR (select): OK (Not Supported)
	test DMABUF: Cannot test, specify --expbuf-device

Total for allegro device /dev/video3: 50, Succeeded: 50, Failed: 0, Warnings: 0

Changelog:

v2:
- Fix make dt_binding_check warnings

Michael Tretter (4):
  media: allegro: move driver out of staging
  dt-bindings: media: allegro,al5e: Convert to YAML
  media: allegro: remove custom drain state handling
  media: allegro: rename stream_id to dst_handle

 .../bindings/media/allegro,al5e.yaml          | 105 ++++++++++
 .../devicetree/bindings/media/allegro.txt     |  43 -----
 MAINTAINERS                                   |   3 +-
 drivers/media/platform/Kconfig                |  15 ++
 drivers/media/platform/Makefile               |   1 +
 .../platform}/allegro-dvt/Makefile            |   0
 .../platform}/allegro-dvt/allegro-core.c      | 180 +++++-------------
 .../platform}/allegro-dvt/allegro-mail.c      |   8 +-
 .../platform}/allegro-dvt/allegro-mail.h      |   4 +-
 .../platform}/allegro-dvt/nal-h264.c          |   0
 .../platform}/allegro-dvt/nal-h264.h          |   0
 drivers/staging/media/Kconfig                 |   2 -
 drivers/staging/media/Makefile                |   1 -
 drivers/staging/media/allegro-dvt/Kconfig     |  16 --
 drivers/staging/media/allegro-dvt/TODO        |   4 -
 15 files changed, 177 insertions(+), 205 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/allegro,al5e.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/allegro.txt
 rename drivers/{staging/media => media/platform}/allegro-dvt/Makefile (100%)
 rename drivers/{staging/media => media/platform}/allegro-dvt/allegro-core.c (95%)
 rename drivers/{staging/media => media/platform}/allegro-dvt/allegro-mail.c (98%)
 rename drivers/{staging/media => media/platform}/allegro-dvt/allegro-mail.h (98%)
 rename drivers/{staging/media => media/platform}/allegro-dvt/nal-h264.c (100%)
 rename drivers/{staging/media => media/platform}/allegro-dvt/nal-h264.h (100%)
 delete mode 100644 drivers/staging/media/allegro-dvt/Kconfig
 delete mode 100644 drivers/staging/media/allegro-dvt/TODO