mbox series

[0/2] rkisp1: Two small fixes

Message ID 20210625082309.24944-1-dafna.hirschfeld@collabora.com (mailing list archive)
Headers show
Series rkisp1: Two small fixes | expand

Message

Dafna Hirschfeld June 25, 2021, 8:23 a.m. UTC 
Two small fixes to rkisp1
1. remove useless vaddr field
2. set the dma address of the capture buffers only once in 'buf_init' callabck
instead of each time the buffer is queued

Dafna Hirschfeld (2):
  media: rkisp1: remove field 'vaddr' from 'rkisp1_buffer'
  media: rkisp1: cap: initialize dma buf address in 'buf_init' cb

 .../media/platform/rockchip/rkisp1/rkisp1-capture.c  | 12 +++++++++++-
 .../media/platform/rockchip/rkisp1/rkisp1-common.h   |  6 +-----
 .../media/platform/rockchip/rkisp1/rkisp1-params.c   |  3 +--
 .../media/platform/rockchip/rkisp1/rkisp1-stats.c    |  6 ++----
 4 files changed, 15 insertions(+), 12 deletions(-)

Comments

Tomasz Figa June 28, 2021, 5:46 a.m. UTC | #1 
On Fri, Jun 25, 2021 at 11:23:07AM +0300, Dafna Hirschfeld wrote:
> Two small fixes to rkisp1
> 1. remove useless vaddr field
> 2. set the dma address of the capture buffers only once in 'buf_init' callabck
> instead of each time the buffer is queued
> 
> Dafna Hirschfeld (2):
>   media: rkisp1: remove field 'vaddr' from 'rkisp1_buffer'
>   media: rkisp1: cap: initialize dma buf address in 'buf_init' cb
> 
>  .../media/platform/rockchip/rkisp1/rkisp1-capture.c  | 12 +++++++++++-
>  .../media/platform/rockchip/rkisp1/rkisp1-common.h   |  6 +-----
>  .../media/platform/rockchip/rkisp1/rkisp1-params.c   |  3 +--
>  .../media/platform/rockchip/rkisp1/rkisp1-stats.c    |  6 ++----
>  4 files changed, 15 insertions(+), 12 deletions(-)

For both patches:

Reviewed-by; Tomasz Figa <tfiga@chromium.org>

Best regards,
Tomasz