[00/11] media: atomisp-ov2680: Cleanups and exposure + gain fixes

Message

Hans de Goede Nov. 7, 2021, 5:15 p.m. UTC

Hi All,

I've finally made some time to look into running the atomisp2 driver
from staging on an Asus T101HA. Thanks to the great work from
Tsuchiya and Mauro I actually got a working picture in camorama
now, which is awesome!

But I noticed that exposure / gain setting was not working, not
even if I first set it using the --exposure option to v4l2n before
running camorama.

There were a number of issues, which this series all fixes,
after this series you can set an exposure + gain with v4l2n
and the run camorama and actually see the difference.

Note despite the cleanups in here the atomisp-ov2680 code still
is far from great, but it works :)

Regards,

Hans

p.s.

I've also given the current media-staging code a real quick
test on a T100HA, fwiw it does not work there atm. I did
not investigate this further (not yet anyways).


Hans de Goede (11):
  media: atomisp-ov2680: Remove a bunch of unused vars from
    ov2680_device
  media: atomisp-ov2680: Turn on power only once
  media: atomisp-ov2680: Push the input_lock taking up into
    ov2680_s_power()
  media: atomisp-ov2680: Remove the ov2680_res and N_RES global
    variables
  media: atomisp-ov2680: Move ov2680_init_registers() call to power_up()
  media: atomisp-ov2680: Save/restore exposure and gain over sensor
    power-down
  media: atomisp-ov2680: Make ov2680_read_reg() support 24 bit registers
  media: atomisp-ov2680: Fix and simplify ov2680_q_exposure()
  media: atomisp-ov2680: Fix ov2680_write_reg() always writing 0 to 16
    bit registers
  media: atomisp-ov2680: Fix ov2680_set_fmt() clobbering the exposure
  media: atomisp-ov2680: Fix ov2680_set_fmt() messing up high exposure
    settings

 .../media/atomisp/i2c/atomisp-ov2680.c        | 167 +++++++-----------
 drivers/staging/media/atomisp/i2c/ov2680.h    |  59 +------
 2 files changed, 71 insertions(+), 155 deletions(-)