From patchwork Mon Nov 8 12:20:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12608345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD29C433EF for ; Mon, 8 Nov 2021 12:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42E9A61284 for ; Mon, 8 Nov 2021 12:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238112AbhKHMWo (ORCPT ); Mon, 8 Nov 2021 07:22:44 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:40183 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238042AbhKHMWo (ORCPT ); Mon, 8 Nov 2021 07:22:44 -0500 Received: (Authenticated sender: jacopo@jmondi.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 140D7240008; Mon, 8 Nov 2021 12:19:56 +0000 (UTC) From: Jacopo Mondi To: Kieran Bingham , Laurent Pinchart , =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= Cc: Jacopo Mondi , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH v3 0/2] max9271: Fix pclk detect silent failure Date: Mon, 8 Nov 2021 13:20:41 +0100 Message-Id: <20211108122043.49187-1-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Repeatedly reading register 0x15 to validate the incoming pixel clock causes sporadic read errors which went silently ignored, causing the camera module to fail to start streaming. Fix that by ignoring the read error and while at it rework the error message handling in all functions. v2->v3 - Remove goto from 1/2 as suggested by Geert v1->v2: - Drop v1 [1/2] - [2/2] new patch. Handle all bus access errors in the call sites Jacopo Mondi (2): media: max9271: Ignore busy loop read errors media: max9271: Fail loud on bus errors in call sites drivers/media/i2c/max9271.c | 116 +++++++++++++++++++++--------------- 1 file changed, 68 insertions(+), 48 deletions(-) --- 2.33.1