From patchwork Fri Feb 18 18:34:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12751746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1751CC433EF for ; Fri, 18 Feb 2022 18:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239234AbiBRSex (ORCPT ); Fri, 18 Feb 2022 13:34:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239224AbiBRSew (ORCPT ); Fri, 18 Feb 2022 13:34:52 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 922EE18F20A for ; Fri, 18 Feb 2022 10:34:33 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 70A3040004; Fri, 18 Feb 2022 18:34:28 +0000 (UTC) From: Jacopo Mondi To: slongerbeam@gmail.com, p.zabel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, martin.kepplinger@puri.sm, rmfrfs@gmail.com, xavier.roumegue@oss.nxp.com, alexander.stein@ew.tq-group.com, dorota.czaplejewicz@puri.sm Cc: kernel@pengutronix.de, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Jacopo Mondi Subject: [PATCH v2 0/7] media: imx: Destage imx7-mipi-csis Date: Fri, 18 Feb 2022 19:34:14 +0100 Message-Id: <20220218183421.583874-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello this series includes patches from two series previously sent: https://lore.kernel.org/linux-media/20220119112024.11339-1-jacopo@jmondi.org/ https://lore.kernel.org/linux-media/20220211180216.290133-1-jacopo@jmondi.org/ v1: https://lore.kernel.org/linux-media/20220214184318.409208-1-jacopo@jmondi.org/T/#t Which can now be marked as superseded. The first 2 patches performs the de-staging of the imx7-mipi-csis driver and are now reviewed. The rest of the series builds on top of the comment received on: https://lore.kernel.org/linux-media/20220119112024.11339-3-jacopo@jmondi.org/ If DUAL pixel mode is used in the CSIS driver, then the CSI block of the IMX8MM SoC needs to be operated in dual mode as well. To do so, use the image format sample size to determine in the CSI bridge if dual or single mode should be used. Laurent could you test on MM to see if it works now ? On top two small patches I was carrying in my tree to add more formats to the CSIS driver, the last one with the caveat that RGB24 is transmitted on the wire with one format and stored in memory with a different one. Series based on top of the most recent media master branch. Thanks j v1->v2: - Remove per-SoC handling in CSI bridge and only use image formats - Add TODO note to the staging driver - Fix PIXEL_DUAL mode comments for imx-mipi-csis - Add output format translation to imx-mipi-csis to handle RGB24 Jacopo Mondi (7): media: imx: De-stage imx7-mipi-csis media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c media: imx: imx7-media-csi: Use dual sampling for YUV 1X16 media: imx: imx-mipi-csis: Set PIXEL_MODE for YUV422 media: imx: imx-mipi-csis: Add RGB565_1X16 media: imx: imx-mipi-csis: Add BGR888 media: imx: imx-mipi-csis: Add output format Documentation/admin-guide/media/imx7.rst | 2 +- ...-mipi-csi2.yaml => nxp,imx-mipi-csi2.yaml} | 2 +- MAINTAINERS | 4 +- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 1 + drivers/media/platform/imx/Kconfig | 24 ++++++++ drivers/media/platform/imx/Makefile | 1 + .../platform/imx/imx-mipi-csis.c} | 59 +++++++++++++++++-- drivers/staging/media/imx/Makefile | 1 - drivers/staging/media/imx/TODO | 26 ++++++++ drivers/staging/media/imx/imx7-media-csi.c | 8 ++- 11 files changed, 117 insertions(+), 12 deletions(-) rename Documentation/devicetree/bindings/media/{nxp,imx7-mipi-csi2.yaml => nxp,imx-mipi-csi2.yaml} (98%) create mode 100644 drivers/media/platform/imx/Kconfig create mode 100644 drivers/media/platform/imx/Makefile rename drivers/{staging/media/imx/imx7-mipi-csis.c => media/platform/imx/imx-mipi-csis.c} (95%) Tested-by: Laurent Pinchart # On i.MX8MM --- 2.35.0