From patchwork Thu May 12 07:40:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Mugnier X-Patchwork-Id: 12847255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEA4C433EF for ; Thu, 12 May 2022 07:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351086AbiELHl5 (ORCPT ); Thu, 12 May 2022 03:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350644AbiELHly (ORCPT ); Thu, 12 May 2022 03:41:54 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCDA31957BA for ; Thu, 12 May 2022 00:41:51 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24C2wsgr021731; Thu, 12 May 2022 09:41:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=wLBGbAmXov550cFzgkB86gpkaqfEnvVPa4/rhnRh2R8=; b=ApiF6K4iaptsSfb5Ngryi4PKAaF4wsTpqxst3e4EnVCqAuUS1U00O8nwgQFmPOPObNav jrMCaoGXteO+LQSPwGhPPDBejcTLCIlI5wIhNmxPEmzYp7TT3icKrY9Q+e9g2Bozajiy Br+mAA0jzryOdF5aroSUEQoLTYLZePqhJuwz/MtEjlPOtgvQmtnLHzVXbXr9DpNJN5+m QIJf1Zg7hoLdt/CnqH953VWxH+FO7RnvFguzR9rKag1JLdckgzYpMA1eRT4FB6uljDjR LLOJ96f2ei/tsbCK9SIZm0XKd7LGJN75VERdAPfsQVO1XuC79+loqcUGhY3W9jnPONSl mA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3fwdw9g4fg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 May 2022 09:41:45 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7B0D710002A; Thu, 12 May 2022 09:41:44 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 66C64214D2B; Thu, 12 May 2022 09:41:44 +0200 (CEST) Received: from localhost (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Thu, 12 May 2022 09:41:44 +0200 From: Benjamin Mugnier To: CC: , , , , , , , Benjamin Mugnier Subject: [PATCH v3 0/5] media: Add ST VGXY61 camera sensor driver Date: Thu, 12 May 2022 09:40:32 +0200 Message-ID: <20220512074037.3829926-1-benjamin.mugnier@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-11_07,2022-05-12_01,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hey, This series adds a driver for the ST VGXY61 camera sensor. This camera sensor is using the i2c bus for control and the csi-2 bus for data. These commits introduce the MEDIA_BUS_FMT_Y16_1X16 as a media bus format (1/5), reserve 16 user controls for the driver (2/5), add a uapi header file to declare a control for the hdr mode (3/5), dt bindings (3/5), and finally the driver (5/5). Tested on DragonBoard 410c and on Raspberry Pi 4. Unfortunately, I was not able to do the freely configurable frame size as advised by Laurent, and I'm stuck. I tried to mimic the ov5693 driver as it seems to work mostly the same but was not successful. I managed to implement the get_selection to set the sensor crop, and set the set_format call to the same frame size. By doing that my captured frame has black lines appearing if I don't use the sensor native resolution, and seem to have issues with matching the sensor internal frame size and the one I want to display (as lines appear wider than they should be). If anyone has an example driver for this please tell me. Any help is appreciated. I hope this fixed frame sizes will be ok, and I could come back to it later once I figure it out. Thanks, Benjamin v2->v3: - Fix errors in dt bindings - Use alphabetical order where applicable - Remove US_PER_MS macro - Rename device specific macros - Fix some control grabs not releasing - Move user controls to public header and add documentation - Rename set_framerate to set_framelength - Rework i2c access - Remove branchings that should never happen - Rework pattern generator setting - Update information on sensor rules of thumb - Remove temperature control - Remove suspend and resume - Move mutex init to probe - Move detect to probe - Fix async_subdev_register order - Support autosuspend - Add init_cfg - Fix controls not updating when sensor was off - Various cleaning - Rebase on master v1->v2: - Move temperature control to v4l2-controls.h as a standard control - Reserve controls in v4l2-controls.h for HDR control - Remove GPIO strobbing controls - Remove references to unused controls in sensor struct - Use v4l2_find_nearest_size - Use V4L2_COLORSPACE_RAW instead of V4L2_COLORSPACE_SRGB - Fill ycbcr_enc, quantization, and xfer_func in v4l2_mbus_framefmt - Change gain from formula to a register RAW write - Change temperature control value directly - Remove clock-name and clock-lanes from device tree bindings - Declare crop zones in mode_info structure - Remove frame_interval functions and add hblank and vblank instead - Update controls dependencies on change - Fix first exposure rule of thumb being too restrictive - Disable hflip and vflip controls while streaming - Change RGB media bus code to Y as the sensor is monochrome - Add Y16 format to v4l2 media bus formats - Add get_selection API - Fix timeout errors while disabling streaming on high framerates - Support pm_runtime - Rebase on master Benjamin Mugnier (5): media: v4l: Add 1X16 16-bit greyscale media bus code definition media: v4l: ctrls: Add user control base for st-vgxy61 controls media: uapi: Add ST VGXY61 header file media: dt-bindings: media: i2c: Add ST VGXY61 camera sensor binding media: i2c: Add driver for ST VGXY61 camera sensor .../bindings/media/i2c/st,st-vgxy61.yaml | 117 + .../userspace-api/media/drivers/st-vgxy61.rst | 23 + .../media/v4l/subdev-formats.rst | 37 + MAINTAINERS | 9 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/st-vgxy61.c | 1940 +++++++++++++++++ include/uapi/linux/media-bus-format.h | 3 +- include/uapi/linux/st-vgxy61.h | 15 + include/uapi/linux/v4l2-controls.h | 5 + 10 files changed, 2159 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml create mode 100644 Documentation/userspace-api/media/drivers/st-vgxy61.rst create mode 100644 drivers/media/i2c/st-vgxy61.c create mode 100644 include/uapi/linux/st-vgxy61.h