From patchwork Thu May 12 09:23:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moudy Ho X-Patchwork-Id: 12847411 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 328F1C433EF for ; Thu, 12 May 2022 09:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351953AbiELJYN (ORCPT ); Thu, 12 May 2022 05:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351949AbiELJXg (ORCPT ); Thu, 12 May 2022 05:23:36 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E9D527E1; Thu, 12 May 2022 02:23:14 -0700 (PDT) X-UUID: b74a88fdf2014188a685aad45fea2a4e-20220512 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:51fa5f9b-00aa-47ad-86db-8d4cbf9b0fa3,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:-20,EDM:0,RT:0,SF:95,FILE:0,RULE:Release_Ham,A CTION:release,TS:75 X-CID-INFO: VERSION:1.1.4,REQID:51fa5f9b-00aa-47ad-86db-8d4cbf9b0fa3,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:-20,EDM:0,RT:0,SF:95,FILE:0,RULE:Spam_GS981B3D,A CTION:quarantine,TS:75 X-CID-META: VersionHash:faefae9,CLOUDID:df37f7f1-ab23-4aed-a67b-f96514452486,C OID:1ce55e839ae7,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,File:nil ,QS:0,BEC:nil X-UUID: b74a88fdf2014188a685aad45fea2a4e-20220512 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1556950587; Thu, 12 May 2022 17:23:09 +0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 12 May 2022 17:23:08 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 May 2022 17:23:07 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 12 May 2022 17:23:07 +0800 From: Moudy Ho To: Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , "Krzysztof Kozlowski" , Hans Verkuil CC: Chun-Kuang Hu , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , Benjamin Gaignard , AngeloGioacchino Del Regno , daoyuan huang , Ping-Hsun Wu , , , , , , , , , Subject: [PATCH v15 0/3] media: mediatek: support mdp3 on mt8183 platform Date: Thu, 12 May 2022 17:23:03 +0800 Message-ID: <20220512092306.6895-1-moudy.ho@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Change since v14: - Rebase on v5.18-rc6 - Depend on: [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=640926 - In response to CMDQ API change, replace the function "cmdq_pkt_flush_async" with the standard APIs of mbox - Fix the description of "mediatek,gce-client-reg" property in MDP3-related bindings Change since v13: - Rebase on v5.18-rc4 - Depend on: [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=636041 - Remove advanced functionality about ISP settings for direct link cases. - Remove the software designation in the mt8183 dts and revise corresponding bindings. Change since v12: - Rebase on linux-next - Depend on: [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=630948 - Remove messages related to routing information in MDP3, and leave the related settings in MMSYS. - Remove unnecessary phandle and redundant property in RDMA dt-binding and adjust the corresponding driver. - Revise MDP3 node name in dts. - Removed unnecessary functions, mutex and work queue in MDP3 driver - Fixed format mapping error for V4L2_PIX_FMT_RGB565X Change since v11: - Rebase on linux-next tag:next-20220316 - Depend on: [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=624281 - Remove redundant hardware index in data-binding suggested by Rob Herring. - Referring to Rob Herring's suggestion to improve some descriptions in the RDMA dt-binding - Move MDP3 file folder from "./drive/media/platform/mtk-mdp3" to "./driver/media/platform/mediatek/mdp3" - Fixed the V4L2 and MDP color format mapping error in RGB565 which checked by Benjamin Gaignard Change since v10: - The routing table needs to be discarded, and the calculation result on the SCP side is used to write a suitable mux setting for 1 input port and 2 output ports. - Adjust dts parsing flow to remove redundant HW IDs. - Fix memory leak caused by no free path information in function "mdp_cmdq_send". Change since v9: - Keep only the MDP3 driver patches and split the remaining mmsys and mutex patches into another mail. - Move mutex mod settings to corresponding driver and make relevant adjustments for this in MDP3 driver. - Fix compile warning reported by kernel test robot. Change since v8: - Rebase on v5.16-rc2. - Refer to Angelo's suggestion, adjust the register writing format to increase readability and significance. - Refer to Angelo's suggestion, adjust or reduce inappropriate debugging messages. - Refer to Rob Herring's suggestion to correct the the binding file to make it with the specification. - Fix compile warning reported by kernel test robot. Change since v7: - Rebase on v5.15-rc6. - Revise several V4L2 M2M settings to pass v4l2-compliance test. - Integrate those same component dt-binding documents of DRM and MDP, and move them under the MMSYS domain. - Split MMSYS and MUTEX into two different files according to their functional properties. Changes since v6: - Refactor GCE event to corresponding node. - Fix dt_binding_check fail. - Fix compilation errors. Changes since v5: - Rebase on v5.14-rc6. - Move MMSYS/Mutex settings to corresponding driver. - Revise the software license description and copyright. - Remove unnecessary enum. or definitions. - Optimize platform/chip definition conditions. - Use general printing functions instead of MDP3 private ones. - Fix compile warning. Changes since v4: - Rebase on v5.13-rc1. - Remove the CMDQ flush flow to match the CMDQ API change. - Integrate four of MDP's direct-link subcomponents into MDP controller node from syscon node to avoid illegal clock usage. - Rewrite dt-binding in a JSON compatible subset of YAML - Fix a bit of macro argument precedence. Changes since v3: - Rebase on v5.9-rc1. - modify code for review comment from Rob Herring, cancel multiple nodes using same register base situation. - control IOMMU port through pm runtime get/put to DMA components' device. - SCP(VPU) driver revision. - stop queuing jobs(remove flush_workqueue()) after mdp_m2m_release(). - add computation of plane address with data_offset. - fix scale ratio check issue. - add default v4l2_format setting. Changes since v2: - modify code for review comment from Tomasz Figa & Alexandre Courbot - review comment from Rob Herring will offer code revision in v4, due to it's related to device node modification, will need to modify code architecture Changes since v1: - modify code for CMDQ v3 API support - EC ipi cmd migration - fix compliance test fail item (m2m cmd with -f) due to there is two problem in runing all format(-f) cmd: 1. out of memory before test complete Due to capture buffer mmap (refcount + 1) after reqbuf but seems no corresponding munmap called before device close. There are total 12XX items(formats) in format test and each format alloc 8 capture/output buffers. 2. unceasingly captureBufs() (randomly) Seems the break statement didn't catch the count == 0 situation: In v4l2-test-buffers.cpp, function: captureBufs() ... count--; if (!node->is_m2m && !count) break; Log is as attachment Hi, This patch is used to present Media Data Path 3 (MDP3) which provided scaling and color format conversion. support using GCE to write register in critical time limitation. support V4L2 m2m device control. Moudy Ho (3): dt-binding: mediatek: add bindings for MediaTek MDP3 components dts: arm64: mt8183: add Mediatek MDP3 nodes media: platform: mtk-mdp3: add Mediatek MDP3 driver .../bindings/media/mediatek,mdp3-rdma.yaml | 85 ++ .../bindings/media/mediatek,mdp3-rsz.yaml | 65 ++ .../bindings/media/mediatek,mdp3-wrot.yaml | 70 ++ .../bindings/soc/mediatek/mediatek,ccorr.yaml | 58 + .../bindings/soc/mediatek/mediatek,wdma.yaml | 71 ++ arch/arm64/boot/dts/mediatek/mt8183.dtsi | 79 +- drivers/media/platform/mediatek/Kconfig | 1 + drivers/media/platform/mediatek/Makefile | 1 + drivers/media/platform/mediatek/mdp3/Kconfig | 20 + drivers/media/platform/mediatek/mdp3/Makefile | 6 + .../platform/mediatek/mdp3/mdp_reg_ccorr.h | 19 + .../platform/mediatek/mdp3/mdp_reg_rdma.h | 65 ++ .../platform/mediatek/mdp3/mdp_reg_rsz.h | 39 + .../platform/mediatek/mdp3/mdp_reg_wdma.h | 47 + .../platform/mediatek/mdp3/mdp_reg_wrot.h | 55 + .../platform/mediatek/mdp3/mtk-img-ipi.h | 290 +++++ .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 486 +++++++++ .../platform/mediatek/mdp3/mtk-mdp3-cmdq.h | 48 + .../platform/mediatek/mdp3/mtk-mdp3-comp.c | 987 ++++++++++++++++++ .../platform/mediatek/mdp3/mtk-mdp3-comp.h | 185 ++++ .../platform/mediatek/mdp3/mtk-mdp3-core.c | 379 +++++++ .../platform/mediatek/mdp3/mtk-mdp3-core.h | 95 ++ .../platform/mediatek/mdp3/mtk-mdp3-m2m.c | 772 ++++++++++++++ .../platform/mediatek/mdp3/mtk-mdp3-m2m.h | 48 + .../platform/mediatek/mdp3/mtk-mdp3-regs.c | 736 +++++++++++++ .../platform/mediatek/mdp3/mtk-mdp3-regs.h | 370 +++++++ .../platform/mediatek/mdp3/mtk-mdp3-vpu.c | 312 ++++++ .../platform/mediatek/mdp3/mtk-mdp3-vpu.h | 78 ++ 28 files changed, 5466 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml create mode 100644 drivers/media/platform/mediatek/mdp3/Kconfig create mode 100644 drivers/media/platform/mediatek/mdp3/Makefile create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_ccorr.h create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_rdma.h create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_rsz.h create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_wdma.h create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_wrot.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-img-ipi.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-m2m.c create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-m2m.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.c create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.h