| Message ID | 20220726021455.1814096-1-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: venus: Fix up buffer handling for HFI_VERSION_1XX | expand |
On 26/07/2022 03:14, Bryan O'Donoghue wrote: > This series fixes two buffer handling bugs. The first bug is trivial and > ~impossible to hit without the second bug but with fixing anyway. Its a > simple NULL pointer handling issue. > > The second bug relates to HFI_VERSION_1XX output buffers. Unfortunately > these have been broken since > > Commit: 9593126dae3e ("media: venus: Add a handling of QC08C compressed format") > > A bit of bisecting the commits in venus found it handily enough. Once the > fix is applied we have I have decode working again on db410c. > > Bryan O'Donoghue (2): > media: venus: dec: Handle the case where find_format fails > media: venus: Fix NV12 decoder buffer discovery on HFI_VERSION_1XX > > drivers/media/platform/qcom/venus/helpers.c | 13 +++++++------ > drivers/media/platform/qcom/venus/vdec.c | 2 ++ > 2 files changed, 9 insertions(+), 6 deletions(-) > Not withstanding my 3am misspelled text above, I've also just validated this changes on RB5/HFI_VERSION_6xx. --- bod
Hi Bryan, Thanks for the patches! On 7/26/22 05:14, Bryan O'Donoghue wrote: > This series fixes two buffer handling bugs. The first bug is trivial and > ~impossible to hit without the second bug but with fixing anyway. Its a > simple NULL pointer handling issue. > > The second bug relates to HFI_VERSION_1XX output buffers. Unfortunately > these have been broken since > > Commit: 9593126dae3e ("media: venus: Add a handling of QC08C compressed format") > > A bit of bisecting the commits in venus found it handily enough. Once the > fix is applied we have I have decode working again on db410c. > > Bryan O'Donoghue (2): > media: venus: dec: Handle the case where find_format fails > media: venus: Fix NV12 decoder buffer discovery on HFI_VERSION_1XX > > drivers/media/platform/qcom/venus/helpers.c | 13 +++++++------ > drivers/media/platform/qcom/venus/vdec.c | 2 ++ > 2 files changed, 9 insertions(+), 6 deletions(-) > Looks good to me. Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
This series fixes two buffer handling bugs. The first bug is trivial and ~impossible to hit without the second bug but with fixing anyway. Its a simple NULL pointer handling issue. The second bug relates to HFI_VERSION_1XX output buffers. Unfortunately these have been broken since Commit: 9593126dae3e ("media: venus: Add a handling of QC08C compressed format") A bit of bisecting the commits in venus found it handily enough. Once the fix is applied we have I have decode working again on db410c. Bryan O'Donoghue (2): media: venus: dec: Handle the case where find_format fails media: venus: Fix NV12 decoder buffer discovery on HFI_VERSION_1XX drivers/media/platform/qcom/venus/helpers.c | 13 +++++++------ drivers/media/platform/qcom/venus/vdec.c | 2 ++ 2 files changed, 9 insertions(+), 6 deletions(-)