From patchwork Mon Oct 3 07:08:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moudy Ho X-Patchwork-Id: 12997116 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA39C433F5 for ; Mon, 3 Oct 2022 07:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiJCHIm (ORCPT ); Mon, 3 Oct 2022 03:08:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbiJCHIl (ORCPT ); Mon, 3 Oct 2022 03:08:41 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D59356FE; Mon, 3 Oct 2022 00:08:37 -0700 (PDT) X-UUID: 2a9c42cef5bd468f848428d8ff8f9aae-20221003 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=SeK8Sk/+yiZcfff3vIcmr/JFhl6MA/TK7AvFrNExFgQ=; b=BG53+uh7uptuDhUZzLaPRcWqRWjcwXBdVEUN1zXRK+TYP+oMSEExWTJ+jK+H03J5Ns9xHm2LrtJwWK4IfPbGl2QOrgoaMvFvbWuiCezETmQQEtVmkd+TRdEcwKiXF3s/eNLiyegiqeO4uoks60rNxijVmdLtGheyH2S2WnS+TdI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:74558886-c25f-482b-948e-65c86153a918,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:90 X-CID-INFO: VERSION:1.1.11,REQID:74558886-c25f-482b-948e-65c86153a918,IP:0,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTIO N:quarantine,TS:90 X-CID-META: VersionHash:39a5ff1,CLOUDID:7e6cd6a3-dc04-435c-b19b-71e131a5fc35,B ulkID:221003150834AGMT48GA,BulkQuantity:0,Recheck:0,SF:38|28|17|19|48|823| 824,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil, COL:0 X-UUID: 2a9c42cef5bd468f848428d8ff8f9aae-20221003 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 223572744; Mon, 03 Oct 2022 15:08:32 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 3 Oct 2022 15:08:31 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 3 Oct 2022 15:08:31 +0800 From: Moudy Ho To: Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil CC: Chun-Kuang Hu , , , , , Moudy Ho Subject: [PATCH v2 0/2] Fix error handling for MDP3 Date: Mon, 3 Oct 2022 15:08:28 +0800 Message-ID: <20221003070830.23697-1-moudy.ho@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Changes since v1: - Rename goto label in mdp_comp_clock_on() from "err_unwind" to "err_revert" to make more readable. Hi, This series fixes some error handling in MDP3 in response to the bug report submitted by Dan Carpenter (Message ID = YxB1E00e8D6P4W2e@kili) Moudy Ho (2): media: platform: mtk-mdp3: fix error handling in mdp_cmdq_send() media: platform: mtk-mdp3: fix error handling about components clock_on .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 51 ++++++++++--------- .../platform/mediatek/mdp3/mtk-mdp3-comp.c | 24 ++++++--- 2 files changed, 45 insertions(+), 30 deletions(-)