From patchwork Fri Nov 4 14:24:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 13032104 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD41C4332F for ; Fri, 4 Nov 2022 14:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbiKDO2Z (ORCPT ); Fri, 4 Nov 2022 10:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232411AbiKDO12 (ORCPT ); Fri, 4 Nov 2022 10:27:28 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A3E317E1 for ; Fri, 4 Nov 2022 07:25:10 -0700 (PDT) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 2BCC5100013; Fri, 4 Nov 2022 14:25:06 +0000 (UTC) From: Jacopo Mondi To: =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart Cc: Jacopo Mondi , linux-media@vger.kernel.org, Dave Stevenson Subject: [PATCH v3 00/10] media: ar0521: Add analog gain, rework clock tree Date: Fri, 4 Nov 2022 15:24:43 +0100 Message-Id: <20221104142452.117135-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, this series adds a few features to the ar0521 driver to enable its usage with libcamera. In particular: - enum_frame_sizes - global analog gain control - LINK_FREQ - Rework blanking handligs v3 (Dave) - Check __v4l2_ctrl_modify_range() return value - Make LINK_FREQ readonly to avoid additional churn in s_ctrl - Fix trivial early return in s_ctrl - Use exposure's default value when modifying the controls' limits - Change the exposure default to 0x70 to match the register default value v2: - I have dropped the most controverse part that allows to change the link frequency to obtain 60FPS. It can be eventually be applied on top. - Use register 0x3028 to control analog gain not to overwrite the global digital gain. - Fix the HBLANK/VBLANK max by using the values read from on-chip registers. - Fix handling of LINK_FREQ in s_cltr (but do not make the control read only). - Fix errors reported by 0-days: - use do_div() for 64-bit division - declare variables in function scope and not in case scope in s_ctrl Jacopo Mondi (10): media: ar0521: Implement enum_frame_sizes media: ar0521: Add V4L2_CID_ANALOG_GAIN media: ar0521: Set maximum resolution to 2592x1944 media: ar0521: Rework PLL computation media: ar0521: Refuse unsupported controls media: ar0521: Add LINK_FREQ control media: ar0521: Adjust exposure and blankings limits media: ar0521: Setup controls at s_stream time media: ar0521: Rework startup sequence media: ar0521: Tab-align definitions drivers/media/i2c/ar0521.c | 352 ++++++++++++++++++++++++++----------- 1 file changed, 250 insertions(+), 102 deletions(-) Acked-by: Krzysztof Hałasa --- 2.38.1