From patchwork Mon Nov 7 20:49:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 13035207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B563C433FE for ; Mon, 7 Nov 2022 20:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbiKGUuY (ORCPT ); Mon, 7 Nov 2022 15:50:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbiKGUuV (ORCPT ); Mon, 7 Nov 2022 15:50:21 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF361EEDD for ; Mon, 7 Nov 2022 12:50:19 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 23294FF807; Mon, 7 Nov 2022 20:50:15 +0000 (UTC) From: Jacopo Mondi To: Sakari Ailus , Laurent Pinchart , Dave Stevenson , Hans Verkuil , Mauro Carvalho Chehab Cc: Jacopo Mondi , Linux Media Mailing List Subject: [PATCH 0/3] Documentation: media: camera_sensor: Document blankings handling Date: Mon, 7 Nov 2022 21:49:56 +0100 Message-Id: <20221107204959.37691-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, this series updates the camera-sensor documentation to indicate that vertical and horizontal blankings should be updated when a new image format is applied on the sensor. 1/3 is more for discussion than inclusion, as I noticed the documentation and the CCS driver use the analogue crop rectangle sizes to compute blanking limits while most driver use the visible size. Which ones are correct ? As I interpret "Figure 47 Line and Frame Blanking Definitions" in CSI-2 spec (I have version 1.01.00 r0.04 2-Apr-2009) it seems clear to me that blankings surround the visible size ("valid data"). However it is also correct to consider blanking limits are a property of the pixel array usually represented by a minx/max limits of some "total output size" register. I wonder if it makes any real difference in practice... 3/3 also documents that exposure limits should be updated when a new vertical blankings are applied. I haven't documented if the actual control value should be reset to some know value as the init-time default or to its minimum value, as described in https://lore.kernel.org/linux-media/20221019065801.4n7alfivhffbvgzo@uno.localdomain/T/ A question for Dave: should the registration of events handler callbacks be documented too as clarified in: https://www.spinics.net/lists/linux-media/msg220715.html Thanks! j Jacopo Mondi (3): Documentation: media: camera-sensor: Correct frame interval documentation: media: camera_sensor: Document blankings handling documentation: media: camera_sensor: Update exposure on blanking change .../driver-api/media/camera-sensor.rst | 69 +++++++++++++++++-- 1 file changed, 65 insertions(+), 4 deletions(-) --- 2.38.1