From patchwork Wed Feb 8 09:08:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moudy Ho X-Patchwork-Id: 13132597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A32C636D3 for ; Wed, 8 Feb 2023 09:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbjBHJJg (ORCPT ); Wed, 8 Feb 2023 04:09:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230516AbjBHJJS (ORCPT ); Wed, 8 Feb 2023 04:09:18 -0500 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9447545BF7; Wed, 8 Feb 2023 01:09:09 -0800 (PST) X-UUID: 386d8ed6a79011eda06fc9ecc4dadd91-20230208 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=ei/6uPK/ojtiWveDJEO+7ga2HZYYiDyJhSp0YQzgkuE=; b=T1yjCfbVss8M2WUFR9lD/CjqZR/slfGLCygNoU7OwDAAi7Vdqn/sd8JTZyL1On2gsRHpZpe7ZWrV8El0DzPZ80Nw748cmUaD4+/zyFJOsdCsNtX8QeZUmEYI1a8sFWjc1XW6t4ccSimfs/jHKFiITcjPzi9EjlGpDa3Puz4tqSI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.19,REQID:f9b40eb5-1467-4010-b7d0-12dca2541b0e,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:885ddb2,CLOUDID:d320458e-8530-4eff-9f77-222cf6e2895b,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-UUID: 386d8ed6a79011eda06fc9ecc4dadd91-20230208 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 794025807; Wed, 08 Feb 2023 17:08:58 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 8 Feb 2023 17:08:56 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 8 Feb 2023 17:08:56 +0800 From: Moudy Ho To: Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , Ping-Hsun Wu CC: , , , , , Moudy Ho Subject: [PATCH v6 00/12] Add support for multiple chips Date: Wed, 8 Feb 2023 17:08:43 +0800 Message-ID: <20230208090855.18934-1-moudy.ho@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Changes since v5: - Rebase on linux-next. - Integrate the chip configuration into a source file called "mdp_cfg_data.c" instead of a header file. - Fix undefined reference to __udividi3 caused by patch [1/12]. - Fix parentheses issue reported by check script. - Fix compilation and smatch errors Changes since v4: - Rebase on linux-next. - Fix potential frame size overflow in "mtk-mdp3-regs.c". - Fix OOB in MDP3 component clocks in "mtk-mdp3-comp.*". - Reconfigure the shared memory between MDP3 kerenl and SCP. Changes since v3: - Rebase on linux-next. - In the file "mtk-mdp3-m2m.c", use the limited resolution defined by each platform to replace the default format. - Add platform ID in driver data, and refine shared memory structure preprocessing. - Simplify the way to get mutex ID in function "mdp_path_subfrm_require". Changes since v2: - Depend on : [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=687004 - Split the shared memory header(mtk-img-ipi.h) by preprocessing instead, and classify the generic parts into "mtk-mdp3-type.h", and move chip-specific parts to"mt8183/mdp3-comp-mt8183.h". Changes since v1: - Depend on : [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=687004 - For hardware-specific structures in the shared memory header(mtk-img-ipi.h), split the relevant functions and structure definitions. Hi, To support multiple chips, a chip configuration header file needs to be created and the relevant information split and moved into it. The v4l2-compliance test results list is as follows: v4l2-compliance 1.23.0-4942, 32 bits, 32-bit time_t v4l2-compliance SHA: 4cf258c24026 2022-07-28 15:43:45 Compliance test for mtk-mdp3 device /dev/video0: Driver Info: Driver name : mtk-mdp3 Card type : MediaTek MDP3 Bus info : platform:14001000.dma-controlle Driver version : 6.2.0 Capabilities : 0x84204000 Video Memory-to-Memory Multiplanar Streaming Extended Pix Format Device Capabilities Device Caps : 0x04204000 Video Memory-to-Memory Multiplanar Streaming Extended Pix Format Required ioctls: test VIDIOC_QUERYCAP: OK test invalid ioctls: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls: test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK test Composing: OK test Scaling: OK Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) test TIME32/64: OK Test input 0: Streaming ioctls: test read/write: OK (Not Supported) test blocking wait: OK (snip) test MMAP (no poll): OK (snip) test MMAP (select): OK (snip) test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Stream using all formats: (snip) Total for mtk-mdp3 device /dev/video0: 1174, Succeeded: 1174, Failed: 0, Warnings: 0 Moudy Ho (12): media: platform: mtk-mdp3: fix potential frame size overflow in mdp_try_fmt_mplane() media: platform: mtk-mdp3: add files for chip configuration media: platform: mtk-mdp3: chip config split about component settings media: platform: mtk-mdp3: chip config split about subcomponents media: platform: mtk-mdp3: chip config split about color format media: platform: mtk-mdp3: chip config split about resolution limitations media: platform: mtk-mdp3: chip config split about pipe info media: platform: mtk-mdp3: extend mdp_color format for compressed mode media: platform: mtk-mdp3: dynamically allocate component clocks media: platform: mtk-mdp3: Split general definitions used in MDP3 media: platform: mtk-mdp3: decompose hardware-related information in shared memory media: platform: mtk-mdp3: reconfigure shared memory drivers/media/platform/mediatek/mdp3/Makefile | 2 +- .../platform/mediatek/mdp3/mdp_cfg_data.c | 454 +++++++++++++++ .../platform/mediatek/mdp3/mdp_sm_mt8183.h | 144 +++++ .../platform/mediatek/mdp3/mtk-img-ipi.h | 189 +----- .../platform/mediatek/mdp3/mtk-mdp3-cfg.h | 20 + .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 148 +++-- .../platform/mediatek/mdp3/mtk-mdp3-comp.c | 538 +++++++++++------- .../platform/mediatek/mdp3/mtk-mdp3-comp.h | 24 +- .../platform/mediatek/mdp3/mtk-mdp3-core.c | 46 +- .../platform/mediatek/mdp3/mtk-mdp3-core.h | 18 +- .../platform/mediatek/mdp3/mtk-mdp3-m2m.c | 28 +- .../platform/mediatek/mdp3/mtk-mdp3-m2m.h | 1 - .../platform/mediatek/mdp3/mtk-mdp3-regs.c | 293 +--------- .../platform/mediatek/mdp3/mtk-mdp3-regs.h | 214 +++---- .../platform/mediatek/mdp3/mtk-mdp3-type.h | 53 ++ .../platform/mediatek/mdp3/mtk-mdp3-vpu.c | 193 +++---- .../platform/mediatek/mdp3/mtk-mdp3-vpu.h | 29 +- 17 files changed, 1429 insertions(+), 965 deletions(-) create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_sm_mt8183.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cfg.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-type.h