From patchwork Fri Mar 10 06:23:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Irui Wang X-Patchwork-Id: 13168780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E752EC64EC4 for ; Fri, 10 Mar 2023 06:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbjCJGYN (ORCPT ); Fri, 10 Mar 2023 01:24:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbjCJGYL (ORCPT ); Fri, 10 Mar 2023 01:24:11 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB8AC104607; Thu, 9 Mar 2023 22:24:04 -0800 (PST) X-UUID: 24edeb2ebf0c11ed945fc101203acc17-20230310 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=zNawnoaaHjlLZq3/CNT/WHhi0vSTAU+m29M2fAmbgCA=; b=tUgHH60PhS9uyBNX4flwLHzKQ2vNiXhBwEcOaKItoBbViPQZe2ufgeTJci+aFx2E2XUu45fW6pQXl/ThTWXRysCJwgrQ4GJXU5hkEvermZj7jXcI+ucrENccCeGpOqv2LQsmefAWzKuRJktAoKEdM4Kl3w3B+5q0RJYAWnODVLU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.20,REQID:6fc2e3da-2c78-4e83-8ac0-1f62c3734726,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:25b5999,CLOUDID:e0af5ff5-ddba-41c3-91d9-10eeade8eac7,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-UUID: 24edeb2ebf0c11ed945fc101203acc17-20230310 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 157988475; Fri, 10 Mar 2023 14:23:59 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Fri, 10 Mar 2023 14:23:58 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Fri, 10 Mar 2023 14:23:57 +0800 From: Irui Wang To: Hans Verkuil , Mauro Carvalho Chehab , Matthias Brugger , , , kyrie wu CC: , , , , , Tomasz Figa , , , Yunfei Dong , Irui Wang Subject: [V2,0/7] Fixes jpeg crash issue in cuj test Date: Fri, 10 Mar 2023 14:23:48 +0800 Message-ID: <20230310062355.9963-1-irui.wang@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: kyrie wu This series is used to fix jpeg dec & enc crash in cuj test. The problem was found frequently that executing CUJ ui.EverydayMultiTaskingCUJ.*_ytmusic test cases on Tomato/Dojo devices with the HW jpeg decoder enabled. Firstly the single core and multi-core judgment methods were modified to make the driver compatible with both cases. Secondly, the jpeg dec & enc worker initialization method and the timing issue of remove buffer were corrected, eliminating crash problems. Finally, some variables and hw dev initialization methods are refactored to reduce code redundancy and improve program robustness. This series has been tested with MT8195 & MT8188. Jpeg encoding and decoding worked for these devices. Patch 1 fixes single core and multi-core judgment methods. Patch 2 optimized jpeg single core initial methods. Patch 3 optimized sw flow of jpeg enc&dec worker to remove buffer. Patch 4 reconstructs the initialization mode of worker. Patch 5 Remove some unnecessary variables. Patch 6 refactor some variables. Patch 7 refactor hw dev initializaiton sw flow. --- Changes compared with v1 - No change compared with v1 kyrie wu (7): media: mtk-jpeg: Fixes jpeghw multi-core judgement media: mtk-jpeg: add jpeg single core initial function media: mtk-jpeg: Fixes jpeg enc&dec worker sw flow media: mtk-jpeg: reconstructs the initialization mode of worker media: mtk-jpeg: Remove some unnecessary variables media: mtk-jpeg: refactor some variables media: mtk-jpeg: refactor hw dev initializaiton .../platform/mediatek/jpeg/mtk_jpeg_core.c | 130 +++++++++++------- .../platform/mediatek/jpeg/mtk_jpeg_core.h | 28 ++-- .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 43 ++---- .../platform/mediatek/jpeg/mtk_jpeg_enc_hw.c | 38 ++--- 4 files changed, 113 insertions(+), 126 deletions(-)