From patchwork Mon Apr 3 15:39:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13198319 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879FDC76196 for ; Mon, 3 Apr 2023 15:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232494AbjDCPlw (ORCPT ); Mon, 3 Apr 2023 11:41:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbjDCPlu (ORCPT ); Mon, 3 Apr 2023 11:41:50 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADA6026BD for ; Mon, 3 Apr 2023 08:41:47 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjMIC-0004b4-3b; Mon, 03 Apr 2023 17:40:24 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pjMI6-008iaO-0i; Mon, 03 Apr 2023 17:40:18 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pjMI5-00AHwO-5x; Mon, 03 Apr 2023 17:40:17 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman , Deepak R Varma , Yuan Can , Simon Horman , Sven Van Asbroeck , Vaibhav Hiremath , Johan Hovold , Alex Elder , Eugen Hristev , Mauro Carvalho Chehab , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Steve Longerbeam , Philipp Zabel , Shawn Guo , Sascha Hauer , Neil Armstrong , Kevin Hilman , Laurent Pinchart , Ezequiel Garcia , Maxime Ripard , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Parthiban Veerasooran , Christian Gromm , Davidlohr Bueso , Marc Dietrich , Florian Fainelli , Ray Jui , Scott Branden , Umang Jain , Andy Shevchenko , Adrien Thierry , Stefan Wahren , "Fabio M. De Francesco" , Phil Elwell , Jakob Koschel Cc: linux-staging@lists.linux.dev, kernel@pengutronix.de, greybus-dev@lists.linaro.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , NXP Linux Team , Jerome Brunet , Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org Subject: [PATCH 00/24] staging: Convert to platform remove callback returning void Date: Mon, 3 Apr 2023 17:39:50 +0200 Message-Id: <20230403154014.2564054-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5012; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=QcqVobs2IGjtDB50UkJ1/XzbU0MSF7u4i5A5EQTdJQg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKvM0O0Tc0pjx/M/6GF+i1BCxRCmy/MPnr7RU1 yFBMKjXOfaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCrzNAAKCRCPgPtYfRL+ Tpy2CACy6x0vU06fdXyxll9SO1keGvUJwPKWx+3c3iql31e1Lm+qBWx4HjLGWAH1BCBwe3626DH lDN1BYh6O1PbPw6fq7eefH5DBIAVGnQSOsyyOFUmo5y3kXQn60JKzxX7xSKuHzUxXXkaj6BYFEl dl3VmQyiYF0+g1PGODFTQSeX9kxjPWoD5g9e11a2P8dLs8Iu1lwVEIyHyEyjcsrYsB3Wj23JY5E t8/rn6+663fTt7WDV/oQ0q40Q54RNHtq2Ou/9xwLL/Jm63tGZ6gAnvbnQcFoAji4hrf+apNVsp/ aW4zaDe6809yWD3o9ofDidHCWNev/88M0ILROQDh07UCEMyG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, this series adapts the platform drivers below drivers/staging to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields a resource leak. By changing the remove callback to return void driver authors cannot reasonably assume any more that there is some kind of cleanup later. All drivers in staging already return zero in their remove callback, so they can be trivially converted. The changes to the individual drivers are all orthogonal. If I need to resend some patches because of some review feedback, I'd like to only send the patches that actually needed changes, so please pick up the remaining patches that don't need changing to reduce the amount of mail. Best regards Uwe Uwe Kleine-König (24): staging: axis-fifo: Convert to platform remove callback returning void staging: emxx_udc: Convert to platform remove callback returning void staging: fieldbus: arcx-anybus: Convert to platform remove callback returning void staging: greybus: arche-apb-ctrl: Convert to platform remove callback returning void staging: greybus: arche: Convert to platform remove callback returning void staging: media: atmel-sama5d2-isc: Convert to platform remove callback returning void staging: media: atmel-sama7g5-isc: Convert to platform remove callback returning void staging: media: imx-media-csi: Convert to platform remove callback returning void staging: media: imx-media-dev: Convert to platform remove callback returning void staging: media: imx6-mipi-csi2: Convert to platform remove callback returning void staging: media: imx8mq-mipi-csi2: Convert to platform remove callback returning void staging: media: meson: vdec: Convert to platform remove callback returning void staging: media: omap4iss: Convert to platform remove callback returning void staging: media: rkvdec: Convert to platform remove callback returning void staging: media: sunxi: cedrus: Convert to platform remove callback returning void staging: media: sun6i-isp: Convert to platform remove callback returning void staging: most: dim2: Convert to platform remove callback returning void staging: nvec: Convert to platform remove callback returning void staging: nvec: nvec_kbd: Convert to platform remove callback returning void staging: nvec_power: Convert to platform remove callback returning void staging: nvec_ps2: Convert to platform remove callback returning void staging: octeon: ethernet: Convert to platform remove callback returning void staging: vc04_services: bcm2835-camera: Convert to platform remove callback returning void staging: vc04_services: vchiq_arm: Convert to platform remove callback returning void drivers/staging/axis-fifo/axis-fifo.c | 6 ++---- drivers/staging/emxx_udc/emxx_udc.c | 6 ++---- drivers/staging/fieldbus/anybuss/arcx-anybus.c | 5 ++--- drivers/staging/greybus/arche-apb-ctrl.c | 6 ++---- drivers/staging/greybus/arche-platform.c | 6 ++---- drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 6 ++---- drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 6 ++---- drivers/staging/media/imx/imx-media-csi.c | 6 ++---- drivers/staging/media/imx/imx-media-dev.c | 6 ++---- drivers/staging/media/imx/imx6-mipi-csi2.c | 6 ++---- drivers/staging/media/imx/imx8mq-mipi-csi2.c | 6 ++---- drivers/staging/media/meson/vdec/vdec.c | 6 ++---- drivers/staging/media/omap4iss/iss.c | 6 ++---- drivers/staging/media/rkvdec/rkvdec.c | 5 ++--- drivers/staging/media/sunxi/cedrus/cedrus.c | 6 ++---- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 6 ++---- drivers/staging/most/dim2/dim2.c | 6 ++---- drivers/staging/nvec/nvec.c | 6 ++---- drivers/staging/nvec/nvec_kbd.c | 6 ++---- drivers/staging/nvec/nvec_power.c | 6 ++---- drivers/staging/nvec/nvec_ps2.c | 6 ++---- drivers/staging/octeon/ethernet.c | 5 ++--- .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 ++---- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 ++---- 24 files changed, 48 insertions(+), 93 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6