[v3,00/13] Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards

Message

Artur Weber May 1, 2023, 7:55 p.m. UTC

This patches re-introduces the Exynos4212 platform and adds support
for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it:

 - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi)
 - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g)
 - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte)

What works:

 - Display and backlight
 - Touchscreen (without touchkeys)
 - GPIO buttons, hall sensor
 - WiFi and Bluetooth
 - USB, fuel gauge, charging
 - Accelerometer and magnetometer
 - WiFi model only: light sensor

Display panel bindings used by the Tab3 DTSI are added in a separate
patchset - "[PATCH 0/3] Add Samsung S6D7AA0 panel controller driver":
https://lore.kernel.org/all/[e-mail]/

LP855X binding updates used by the Tab3 DTSI are added in a separate
patchset - "[PATCH 0/4] video: backlight: lp855x: modernize bindings":
https://lore.kernel.org/all/[e-mail]/

Changed in v2:
 - Added note about display panel bindings to cover letter and
   Tab3 DTSI commit

Changed in v3:
 - Addressed review comments
 - Tab3 DTS tweaks (remove broken RTC, add CPU thermal node)
 - Fixed typos in Exynos DTSIs

Artur Weber (13):
  dt-bindings: soc: samsung: add Exynos4212 PMU compatible
  dt-bindings: clock: add Exynos4212 clock compatible
  ARM: exynos: Re-introduce Exynos4212 support
  soc: samsung: Re-introduce Exynos4212 support
  clk: samsung: Add Exynos4212 compatible to CLKOUT driver
  clk: samsung: Re-add support for Exynos4212 CPU clock
  Revert "media: exynos4-is: Remove dependency on obsolete SoC support"
  Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB"
  ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi
  ARM: dts: Re-introduce Exynos4212 DTSI
  ARM: dts: exynos: Fix some typos in comments
  dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards
  ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards

 .../bindings/arm/samsung/samsung-boards.yaml  |   10 +
 .../bindings/clock/samsung,exynos-clock.yaml  |    1 +
 .../bindings/soc/samsung/exynos-pmu.yaml      |    5 +
 arch/arm/boot/dts/Makefile                    |    3 +
 arch/arm/boot/dts/exynos3250-pinctrl.dtsi     |    4 +-
 arch/arm/boot/dts/exynos3250.dtsi             |    2 +-
 arch/arm/boot/dts/exynos4.dtsi                |    2 +-
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi     |    4 +-
 arch/arm/boot/dts/exynos4212-tab3-3g8.dts     |   29 +
 arch/arm/boot/dts/exynos4212-tab3-lte8.dts    |   44 +
 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts   |   26 +
 arch/arm/boot/dts/exynos4212-tab3.dtsi        | 1171 +++++++++++++++++
 arch/arm/boot/dts/exynos4212.dtsi             |  157 +++
 arch/arm/boot/dts/exynos4412.dtsi             |  646 +--------
 ...2-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} |    6 +-
 .../dts/{exynos4412.dtsi => exynos4x12.dtsi}  |  165 +--
 arch/arm/boot/dts/exynos5.dtsi                |    2 +-
 arch/arm/boot/dts/exynos5250-pinctrl.dtsi     |    4 +-
 arch/arm/boot/dts/exynos5250.dtsi             |    2 +-
 arch/arm/boot/dts/exynos5260-pinctrl.dtsi     |    2 +-
 arch/arm/boot/dts/exynos5410.dtsi             |    2 +-
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi     |    2 +-
 arch/arm/boot/dts/exynos5420.dtsi             |    2 +-
 arch/arm/boot/dts/exynos5800.dtsi             |    2 +-
 arch/arm/boot/dts/s3c6400.dtsi                |    2 +-
 arch/arm/boot/dts/s3c6410.dtsi                |    2 +-
 arch/arm/boot/dts/s3c64xx.dtsi                |    2 +-
 arch/arm/boot/dts/s5pv210-pinctrl.dtsi        |    2 +-
 arch/arm/boot/dts/s5pv210.dtsi                |    2 +-
 arch/arm/mach-exynos/Kconfig                  |    5 +
 arch/arm/mach-exynos/common.h                 |    8 +
 arch/arm/mach-exynos/exynos.c                 |    2 +
 arch/arm/mach-exynos/firmware.c               |    8 +-
 arch/arm/mach-exynos/pm.c                     |    2 +-
 arch/arm/mach-exynos/suspend.c                |    4 +
 drivers/clk/samsung/clk-exynos-clkout.c       |    3 +
 drivers/clk/samsung/clk-exynos4.c             |   44 +-
 .../media/platform/samsung/exynos4-is/Kconfig |    2 +-
 .../platform/samsung/exynos4-is/fimc-core.c   |    2 +-
 .../platform/samsung/exynos4-is/fimc-lite.c   |    2 +-
 drivers/phy/samsung/Kconfig                   |    2 +-
 drivers/soc/samsung/exynos-pmu.c              |    9 +
 drivers/soc/samsung/exynos-pmu.h              |    2 +
 drivers/soc/samsung/exynos4-pmu.c             |   13 +-
 44 files changed, 1534 insertions(+), 837 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts
 create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi
 create mode 100644 arch/arm/boot/dts/exynos4212.dtsi
 rename arch/arm/boot/dts/{exynos4412-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} (99%)
 copy arch/arm/boot/dts/{exynos4412.dtsi => exynos4x12.dtsi} (81%)


base-commit: e154a338e16cc3b3bbd54c891253319d22383746

Comments

Krzysztof Kozlowski May 9, 2023, 6:22 p.m. UTC | #1

On 01/05/2023 21:55, Artur Weber wrote:
> This patches re-introduces the Exynos4212 platform and adds support
> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it:
> 
>  - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi)
>  - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g)
>  - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte)
> 
> What works:
> 
>  - Display and backlight
>  - Touchscreen (without touchkeys)
>  - GPIO buttons, hall sensor
>  - WiFi and Bluetooth
>  - USB, fuel gauge, charging
>  - Accelerometer and magnetometer
>  - WiFi model only: light sensor


Thanks for the patches, nice work.

I applied parts of the set. Please:
1. Split the patchset per subsystems, so separate to media, phy and me.
2. Check reviews and resend bindings for display and LP855X.
3. Rebase and check/fix DTS and send a new version. I cannot apply DTS
without bindings being reviewed.


Best regards,
Krzysztof