mbox series

[0/9] media: atomisp: Add support for v4l2-async sensor registration

Message ID 20230518153733.195306-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series media: atomisp: Add support for v4l2-async sensor registration | expand

Message

Hans de Goede May 18, 2023, 3:37 p.m. UTC
Hi All,

I'm quite happy to present this patch series which makes it possible
to use v4l2-async sensor registration together with the atomisp code :)

This has been tested with both the gc0310 and the ov2680 sensor drivers.

For now it also is still possible to use the old atomisp_gmin_platform
based sensor drivers. This is mainly intended for testing while moving
other sensor drivers over to runtime-pm + v4l2-async.

Regards,

Hans


Hans de Goede (9):
  media: atomisp: Drop MRFLD_PORT_NUM define
  media: atomisp: Remove unused fields from struct atomisp_input_subdev
  media: atomisp: Remove atomisp_video_init() parametrization
  media: atomisp: Rename __get_mipi_port() to
    atomisp_port_to_mipi_port()
  media: atomisp: Store number of sensor lanes per port in struct
    atomisp_device
  media: atomisp: Delay mapping sensors to inputs till
    atomisp_register_device_nodes()
  media: atomisp: Move pad linking to atomisp_register_device_nodes()
  media: atomisp: Allow camera_mipi_info to be NULL
  media: atomisp: Add support for v4l2-async sensor registration

 drivers/staging/media/atomisp/Makefile        |   1 +
 .../atomisp/include/linux/atomisp_platform.h  |   1 +
 .../staging/media/atomisp/pci/atomisp-regs.h  |   1 -
 .../staging/media/atomisp/pci/atomisp_cmd.c   |  41 +-
 .../staging/media/atomisp/pci/atomisp_cmd.h   |   4 +-
 .../staging/media/atomisp/pci/atomisp_csi2.c  |  10 +-
 .../staging/media/atomisp/pci/atomisp_csi2.h  |  64 ++
 .../media/atomisp/pci/atomisp_csi2_bridge.c   | 592 ++++++++++++++++++
 .../staging/media/atomisp/pci/atomisp_fops.c  |   2 +-
 .../media/atomisp/pci/atomisp_gmin_platform.c |   2 +
 .../media/atomisp/pci/atomisp_internal.h      |  11 +-
 .../staging/media/atomisp/pci/atomisp_ioctl.c |   2 +-
 .../media/atomisp/pci/atomisp_subdev.c        |  37 +-
 .../media/atomisp/pci/atomisp_subdev.h        |   3 -
 .../staging/media/atomisp/pci/atomisp_v4l2.c  | 220 +++----
 .../staging/media/atomisp/pci/atomisp_v4l2.h  |   4 +-
 16 files changed, 793 insertions(+), 202 deletions(-)
 create mode 100644 drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c

Comments

Andy Shevchenko May 18, 2023, 4:19 p.m. UTC | #1
On Thu, May 18, 2023 at 6:37 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> I'm quite happy to present this patch series which makes it possible
> to use v4l2-async sensor registration together with the atomisp code :)
>
> This has been tested with both the gc0310 and the ov2680 sensor drivers.
>
> For now it also is still possible to use the old atomisp_gmin_platform
> based sensor drivers. This is mainly intended for testing while moving
> other sensor drivers over to runtime-pm + v4l2-async.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
for non-commented ones or in case you resolve remarks my way.

Definitely this does not apply to patch 9/9 which is WIP and requires
more review, I'm still planning to go through it (not done yet).
Hans de Goede May 18, 2023, 4:36 p.m. UTC | #2
Hi,

On 5/18/23 18:19, Andy Shevchenko wrote:
> On Thu, May 18, 2023 at 6:37 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi All,
>>
>> I'm quite happy to present this patch series which makes it possible
>> to use v4l2-async sensor registration together with the atomisp code :)
>>
>> This has been tested with both the gc0310 and the ov2680 sensor drivers.
>>
>> For now it also is still possible to use the old atomisp_gmin_platform
>> based sensor drivers. This is mainly intended for testing while moving
>> other sensor drivers over to runtime-pm + v4l2-async.
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> for non-commented ones or in case you resolve remarks my way.
> 
> Definitely this does not apply to patch 9/9 which is WIP and requires
> more review, I'm still planning to go through it (not done yet).

Ugh, my bad I forgot to change the commit message of 9/9 from
my pov other then the commit message 9/9 is ready for merging

I have tested 9/9 with both the gc0310 and ov2680 drivers with
all mixes of 0 / 1 / both sensors using async (and the others
"classic" atomisp) enumeration and that all works well.

Regards,

Hans