mbox series

[v3,0/3] media: imx: imx7-media-csi: Fix width alignment

Message ID 20230725200249.15447-1-laurent.pinchart@ideasonboard.com (mailing list archive)
Headers show
Series media: imx: imx7-media-csi: Fix width alignment | expand

Message

Laurent Pinchart July 25, 2023, 8:02 p.m. UTC 
Hello,

This patch series is an attempt to fix the issue reported by Tim Harvey
in [1].

Both Alexander Stein and Fabio Estevam gave this a try in [2] and [3]
respectively, with Alexander's self-nacking his patches and Fabio's
solution receiving requests for changes during review.

Compared to those attempts, this version implements a simpler fix for
the issue (in patch 1/3), before addressing a TODO item (patch 2/3) and
cleaning up includes as a drive-by improvement (patch 3/3).

The series doesn't need to be merged in one go. Patch 1/3 can get merged
as a fix for v6.5, while patches 2/3 and 3/3 can wait until v6.6.

Tim, would you be able to test this ?

[1] https://lore.kernel.org/linux-media/CAJ+vNU0BOVLTL17ofgHwtexbpuMYwH_aGUC==EXABUtHHiv_ag@mail.gmail.com/
[2] https://lore.kernel.org/linux-media/20230720074129.3680269-1-alexander.stein@ew.tq-group.com
[3] https://lore.kernel.org/linux-media/20230720222543.1740198-1-festevam@gmail.com

Fabio Estevam (1):
  media: imx: imx7-media-csi: Fix applying format constraints

Laurent Pinchart (2):
  media: imx: imx7-media-csi: Fix frame sizes enumeration
  media: imx: imx7-media-csi: Include headers explicitly

 drivers/media/platform/nxp/imx7-media-csi.c | 48 +++++++++++++++------
 1 file changed, 34 insertions(+), 14 deletions(-)

Comments

Tim Harvey Aug. 17, 2023, 10:24 p.m. UTC | #1 
On Tue, Jul 25, 2023 at 1:02 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hello,
>
> This patch series is an attempt to fix the issue reported by Tim Harvey
> in [1].
>
> Both Alexander Stein and Fabio Estevam gave this a try in [2] and [3]
> respectively, with Alexander's self-nacking his patches and Fabio's
> solution receiving requests for changes during review.
>
> Compared to those attempts, this version implements a simpler fix for
> the issue (in patch 1/3), before addressing a TODO item (patch 2/3) and
> cleaning up includes as a drive-by improvement (patch 3/3).
>
> The series doesn't need to be merged in one go. Patch 1/3 can get merged
> as a fix for v6.5, while patches 2/3 and 3/3 can wait until v6.6.
>
> Tim, would you be able to test this ?
>
> [1] https://lore.kernel.org/linux-media/CAJ+vNU0BOVLTL17ofgHwtexbpuMYwH_aGUC==EXABUtHHiv_ag@mail.gmail.com/
> [2] https://lore.kernel.org/linux-media/20230720074129.3680269-1-alexander.stein@ew.tq-group.com
> [3] https://lore.kernel.org/linux-media/20230720222543.1740198-1-festevam@gmail.com
>
> Fabio Estevam (1):
>   media: imx: imx7-media-csi: Fix applying format constraints
>
> Laurent Pinchart (2):
>   media: imx: imx7-media-csi: Fix frame sizes enumeration
>   media: imx: imx7-media-csi: Include headers explicitly
>
>  drivers/media/platform/nxp/imx7-media-csi.c | 48 +++++++++++++++------
>  1 file changed, 34 insertions(+), 14 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>

Laurent,

Thanks for working on this. This series does not apply directly on
v6.5-rc6 which is where the regression is that 'media: imx:
imx7-media-csi: Fix applying format constraints' fixes. Regardless
I've manually applied the series on top of v5.6-rc6 and it does
resolve the regression. Note that Fabio's v2 fix applies fine on top
of v6.5-rc6 and resolves the regression in v6.5.

Tested-by: Tim Harvey <tharvey@gateworks.com> # imx8mm-gw72xx-0x with
imx219 image sensor

I'm not clear how to go about getting the first patch in the series
properly applied to v5.6 to resolve the regression.

Best regards,

Tim