[0/2] media: siano: Fix two bugs in smsdvb_debugfs_create()

Message

Jinjie Ruan Sept. 14, 2023, 3:50 a.m. UTC

As debugfs_create_file() returns ERR_PTR and never NULL, check NULL is not
correct to catch the error.

And if kzalloc() fails in smsdvb_debugfs_create(), the dir and file which
is created by debugfs_create_dir() and debugfs_create_file() is
not freed.

This patch set fix the above 2 bugs.

Jinjie Ruan (2):
  media: siano: Fix the NULL vs IS_ERR() bug for debugfs_create_file()
  media: siano: Fix the missing err path in smsdvb_debugfs_create()

 drivers/media/common/siano/smsdvb-debugfs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jinjie Ruan Sept. 28, 2023, 1:24 a.m. UTC | #1

Ping.

On 2023/9/14 11:50, Jinjie Ruan wrote:
> As debugfs_create_file() returns ERR_PTR and never NULL, check NULL is not
> correct to catch the error.
> 
> And if kzalloc() fails in smsdvb_debugfs_create(), the dir and file which
> is created by debugfs_create_dir() and debugfs_create_file() is
> not freed.
> 
> This patch set fix the above 2 bugs.
> 
> Jinjie Ruan (2):
>   media: siano: Fix the NULL vs IS_ERR() bug for debugfs_create_file()
>   media: siano: Fix the missing err path in smsdvb_debugfs_create()
> 
>  drivers/media/common/siano/smsdvb-debugfs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>