This series implement Hans's RFC: https://www.spinics.net/lists/linux-media/msg244455.html
To summarize Hans's proposal it is needed to distinguish two cases:
- the minimal number of buffers to be allocated when calling
VIDIOC_REQBUFS.
- the minimale number of buffers to be present before start streaming
(mostly for DMA engine purpose).
Until now drivers use vb2_queue min_buffers_needed field in the both
cases but before introduce delete buffers we need to clarify for which
usage each of them use min_buffers_needed field.
I have done this in 3 steps:
- add min_reqbufs_allocation field and convert all the drivers that I
believe use min_buffers_needed field for VIDIOC_REQBUF purpose.
- add min_dma_buffers_needed field and convert all the drivers with DMA
engine needs.
- remove min_buffers_needed from videobuf2 core.
The branch with all patches is here:
https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/commits/clean_min_need_buffers_v1
I have tested with this command line, I haven't notice issues:
./test-media -kmemleak mc
Regards,
Benjamin
Benjamin Gaignard (55):
videobuf2: Add min_reqbufs_allocation field to vb2_queue structure
media: test-drivers: Stop abusing of min_buffers_needed field
media: usb: cx231xx: Stop abusing of min_buffers_needed field
media: usb: dvb-usb: cxusb-analog: Stop abusing of min_buffers_needed
field
media: usb: gspca: Stop abusing of min_buffers_needed field
media: atmel: Stop abusing of min_buffers_needed field
media: imx8-isi: Stop abusing of min_buffers_needed field
media: imx7-media-csi: Stop abusing of min_buffers_needed field
media: chips-media: coda: Stop abusing of min_buffers_needed field
media: nuvoton: Stop abusing of min_buffers_needed field
media: sti: hva: Stop abusing of min_buffers_needed field
media: rockchip: rkisp1: Stop abusing of min_buffers_needed field
media: aspeed: Stop abusing of min_buffers_needed field
media: microchip: Stop abusing of min_buffers_needed field
media: amphion: Stop abusing of min_buffers_needed field
media: qcom: venus: Stop abusing of min_buffers_needed field
media: sun4i-csi: Stop abusing of min_buffers_needed field
media: sunxi: sun8i-di: Stop abusing of min_buffers_needed field
media: sun8i-rotate: Stop abusing of min_buffers_needed field
media: sunxi: sun6i-csi: Stop abusing of min_buffers_needed field
media: i2c: video-i2c: Stop abusing of min_buffers_needed field
media: dvb-core: Stop abusing of min_buffers_needed field
media: imx: Stop abusing of min_buffers_needed field
media: atmel: Stop abusing of min_buffers_needed field
media: ipu3: Stop abusing of min_buffers_needed field
media: starfive: Stop abusing of min_buffers_needed field
media: sun6i-isp: Stop abusing of min_buffers_needed field
media: tegra-video: Stop abusing of min_buffers_needed field
media: ti: am437x: Stop abusing of min_buffers_needed field
media: ti: cal: Stop abusing of min_buffers_needed field
media: ti: davinci: Stop abusing of min_buffers_needed field
media: saa7146: Stop abusing of min_buffers_needed field
input: touchscreen: atmel: Stop abusing of min_buffers_needed field
input: touchscreen: sur40: Stop abusing of min_buffers_needed field
videobuf2: core: Add min_dma_buffers_needed field to vb2_queue
media: stm32: stm32-dcmi: Use min_dma_buffers_needed field
media: renesas: Use min_dma_buffers_needed field
media: ti: j721e-csi2rx: Use min_dma_buffers_needed field
media: ti: omap: Use min_dma_buffers_needed field
samples: v4l2: pci: Use min_dma_buffers_needed field
media: pci: intel: ipu3: Use min_dma_buffers_needed field
media: pci: dt3155: Use min_dma_buffers_needed field
media: pci: bt8xx: Use min_dma_buffers_needed field
media: pci: cx18: Use min_dma_buffers_needed field
media: pci: mgb4: Use min_dma_buffers_needed field
media: pci: tw68: Use min_dma_buffers_needed field
media: pci: cx25821: Use min_dma_buffers_needed field
media: pci: tw5864: Use min_dma_buffers_needed field
media: pci: tw686x: Use min_dma_buffers_needed field
media: pci: cx88: Use min_dma_buffers_needed field
media: pci: cx23885: Use min_dma_buffers_needed field
media: pci: zoran: Use min_dma_buffers_needed field
media: pci: cobalt: Use min_dma_buffers_needed field
media: meson: vdec: Use min_dma_buffers_needed field
media: videobuf2: core: Remove 'min_buffers_needed' field
drivers/input/touchscreen/atmel_mxt_ts.c | 2 +-
drivers/input/touchscreen/sur40.c | 2 +-
drivers/media/common/saa7146/saa7146_fops.c | 2 +-
.../media/common/videobuf2/videobuf2-core.c | 26 +++++++++++--------
drivers/media/dvb-core/dvb_vb2.c | 2 +-
drivers/media/i2c/video-i2c.c | 2 +-
drivers/media/pci/bt8xx/bttv-driver.c | 2 +-
drivers/media/pci/cobalt/cobalt-v4l2.c | 2 +-
drivers/media/pci/cx18/cx18-streams.c | 2 +-
drivers/media/pci/cx23885/cx23885-417.c | 2 +-
drivers/media/pci/cx23885/cx23885-dvb.c | 2 +-
drivers/media/pci/cx23885/cx23885-video.c | 4 +--
drivers/media/pci/cx25821/cx25821-video.c | 2 +-
drivers/media/pci/cx88/cx88-blackbird.c | 2 +-
drivers/media/pci/cx88/cx88-dvb.c | 2 +-
drivers/media/pci/cx88/cx88-video.c | 4 +--
drivers/media/pci/dt3155/dt3155.c | 2 +-
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +-
drivers/media/pci/mgb4/mgb4_vin.c | 2 +-
drivers/media/pci/mgb4/mgb4_vout.c | 2 +-
drivers/media/pci/tw5864/tw5864-video.c | 2 +-
drivers/media/pci/tw68/tw68-video.c | 2 +-
drivers/media/pci/tw686x/tw686x-video.c | 2 +-
drivers/media/pci/zoran/zoran_driver.c | 5 +---
drivers/media/platform/amphion/vpu_v4l2.c | 4 +--
drivers/media/platform/aspeed/aspeed-video.c | 2 +-
drivers/media/platform/atmel/atmel-isi.c | 2 +-
.../platform/chips-media/coda/coda-common.c | 2 +-
.../platform/microchip/microchip-isc-base.c | 2 +-
drivers/media/platform/nuvoton/npcm-video.c | 2 +-
drivers/media/platform/nxp/imx7-media-csi.c | 2 +-
.../platform/nxp/imx8-isi/imx8-isi-video.c | 2 +-
drivers/media/platform/qcom/venus/vdec.c | 4 +--
drivers/media/platform/qcom/venus/venc.c | 4 +--
.../platform/renesas/rcar-vin/rcar-dma.c | 2 +-
drivers/media/platform/renesas/renesas-ceu.c | 2 +-
.../platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +-
drivers/media/platform/renesas/sh_vou.c | 2 +-
.../platform/rockchip/rkisp1/rkisp1-capture.c | 2 +-
drivers/media/platform/st/sti/hva/hva-v4l2.c | 4 +--
drivers/media/platform/st/stm32/stm32-dcmi.c | 2 +-
.../platform/sunxi/sun4i-csi/sun4i_dma.c | 2 +-
.../sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +-
.../media/platform/sunxi/sun8i-di/sun8i-di.c | 4 +--
.../sunxi/sun8i-rotate/sun8i_rotate.c | 4 +--
.../media/platform/ti/am437x/am437x-vpfe.c | 2 +-
drivers/media/platform/ti/cal/cal-video.c | 2 +-
.../media/platform/ti/davinci/vpif_capture.c | 2 +-
.../media/platform/ti/davinci/vpif_display.c | 2 +-
.../platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
drivers/media/platform/ti/omap/omap_vout.c | 2 +-
.../media/test-drivers/vimc/vimc-capture.c | 2 +-
drivers/media/test-drivers/vivid/vivid-core.c | 4 +--
drivers/media/usb/cx231xx/cx231xx-417.c | 2 +-
drivers/media/usb/cx231xx/cx231xx-video.c | 4 +--
drivers/media/usb/dvb-usb/cxusb-analog.c | 2 +-
drivers/media/usb/gspca/gspca.c | 6 ++---
.../media/deprecated/atmel/atmel-isc-base.c | 2 +-
drivers/staging/media/imx/imx-media-capture.c | 2 +-
drivers/staging/media/ipu3/ipu3-v4l2.c | 2 +-
drivers/staging/media/meson/vdec/vdec.c | 6 ++---
.../staging/media/starfive/camss/stf-video.c | 2 +-
.../media/sunxi/sun6i-isp/sun6i_isp_capture.c | 2 +-
.../media/sunxi/sun6i-isp/sun6i_isp_params.c | 2 +-
drivers/staging/media/tegra-video/vi.c | 2 +-
include/media/videobuf2-core.h | 10 +++++--
samples/v4l/v4l2-pci-skeleton.c | 2 +-
67 files changed, 102 insertions(+), 95 deletions(-)
This series implement Hans's RFC: https://www.spinics.net/lists/linux-media/msg244455.html To summarize Hans's proposal it is needed to distinguish two cases: - the minimal number of buffers to be allocated when calling VIDIOC_REQBUFS. - the minimale number of buffers to be present before start streaming (mostly for DMA engine purpose). Until now drivers use vb2_queue min_buffers_needed field in the both cases but before introduce delete buffers we need to clarify for which usage each of them use min_buffers_needed field. I have done this in 3 steps: - add min_reqbufs_allocation field and convert all the drivers that I believe use min_buffers_needed field for VIDIOC_REQBUF purpose. - add min_dma_buffers_needed field and convert all the drivers with DMA engine needs. - remove min_buffers_needed from videobuf2 core. The branch with all patches is here: https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/commits/clean_min_need_buffers_v1 I have tested with this command line, I haven't notice issues: ./test-media -kmemleak mc Regards, Benjamin Benjamin Gaignard (55): videobuf2: Add min_reqbufs_allocation field to vb2_queue structure media: test-drivers: Stop abusing of min_buffers_needed field media: usb: cx231xx: Stop abusing of min_buffers_needed field media: usb: dvb-usb: cxusb-analog: Stop abusing of min_buffers_needed field media: usb: gspca: Stop abusing of min_buffers_needed field media: atmel: Stop abusing of min_buffers_needed field media: imx8-isi: Stop abusing of min_buffers_needed field media: imx7-media-csi: Stop abusing of min_buffers_needed field media: chips-media: coda: Stop abusing of min_buffers_needed field media: nuvoton: Stop abusing of min_buffers_needed field media: sti: hva: Stop abusing of min_buffers_needed field media: rockchip: rkisp1: Stop abusing of min_buffers_needed field media: aspeed: Stop abusing of min_buffers_needed field media: microchip: Stop abusing of min_buffers_needed field media: amphion: Stop abusing of min_buffers_needed field media: qcom: venus: Stop abusing of min_buffers_needed field media: sun4i-csi: Stop abusing of min_buffers_needed field media: sunxi: sun8i-di: Stop abusing of min_buffers_needed field media: sun8i-rotate: Stop abusing of min_buffers_needed field media: sunxi: sun6i-csi: Stop abusing of min_buffers_needed field media: i2c: video-i2c: Stop abusing of min_buffers_needed field media: dvb-core: Stop abusing of min_buffers_needed field media: imx: Stop abusing of min_buffers_needed field media: atmel: Stop abusing of min_buffers_needed field media: ipu3: Stop abusing of min_buffers_needed field media: starfive: Stop abusing of min_buffers_needed field media: sun6i-isp: Stop abusing of min_buffers_needed field media: tegra-video: Stop abusing of min_buffers_needed field media: ti: am437x: Stop abusing of min_buffers_needed field media: ti: cal: Stop abusing of min_buffers_needed field media: ti: davinci: Stop abusing of min_buffers_needed field media: saa7146: Stop abusing of min_buffers_needed field input: touchscreen: atmel: Stop abusing of min_buffers_needed field input: touchscreen: sur40: Stop abusing of min_buffers_needed field videobuf2: core: Add min_dma_buffers_needed field to vb2_queue media: stm32: stm32-dcmi: Use min_dma_buffers_needed field media: renesas: Use min_dma_buffers_needed field media: ti: j721e-csi2rx: Use min_dma_buffers_needed field media: ti: omap: Use min_dma_buffers_needed field samples: v4l2: pci: Use min_dma_buffers_needed field media: pci: intel: ipu3: Use min_dma_buffers_needed field media: pci: dt3155: Use min_dma_buffers_needed field media: pci: bt8xx: Use min_dma_buffers_needed field media: pci: cx18: Use min_dma_buffers_needed field media: pci: mgb4: Use min_dma_buffers_needed field media: pci: tw68: Use min_dma_buffers_needed field media: pci: cx25821: Use min_dma_buffers_needed field media: pci: tw5864: Use min_dma_buffers_needed field media: pci: tw686x: Use min_dma_buffers_needed field media: pci: cx88: Use min_dma_buffers_needed field media: pci: cx23885: Use min_dma_buffers_needed field media: pci: zoran: Use min_dma_buffers_needed field media: pci: cobalt: Use min_dma_buffers_needed field media: meson: vdec: Use min_dma_buffers_needed field media: videobuf2: core: Remove 'min_buffers_needed' field drivers/input/touchscreen/atmel_mxt_ts.c | 2 +- drivers/input/touchscreen/sur40.c | 2 +- drivers/media/common/saa7146/saa7146_fops.c | 2 +- .../media/common/videobuf2/videobuf2-core.c | 26 +++++++++++-------- drivers/media/dvb-core/dvb_vb2.c | 2 +- drivers/media/i2c/video-i2c.c | 2 +- drivers/media/pci/bt8xx/bttv-driver.c | 2 +- drivers/media/pci/cobalt/cobalt-v4l2.c | 2 +- drivers/media/pci/cx18/cx18-streams.c | 2 +- drivers/media/pci/cx23885/cx23885-417.c | 2 +- drivers/media/pci/cx23885/cx23885-dvb.c | 2 +- drivers/media/pci/cx23885/cx23885-video.c | 4 +-- drivers/media/pci/cx25821/cx25821-video.c | 2 +- drivers/media/pci/cx88/cx88-blackbird.c | 2 +- drivers/media/pci/cx88/cx88-dvb.c | 2 +- drivers/media/pci/cx88/cx88-video.c | 4 +-- drivers/media/pci/dt3155/dt3155.c | 2 +- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- drivers/media/pci/mgb4/mgb4_vin.c | 2 +- drivers/media/pci/mgb4/mgb4_vout.c | 2 +- drivers/media/pci/tw5864/tw5864-video.c | 2 +- drivers/media/pci/tw68/tw68-video.c | 2 +- drivers/media/pci/tw686x/tw686x-video.c | 2 +- drivers/media/pci/zoran/zoran_driver.c | 5 +--- drivers/media/platform/amphion/vpu_v4l2.c | 4 +-- drivers/media/platform/aspeed/aspeed-video.c | 2 +- drivers/media/platform/atmel/atmel-isi.c | 2 +- .../platform/chips-media/coda/coda-common.c | 2 +- .../platform/microchip/microchip-isc-base.c | 2 +- drivers/media/platform/nuvoton/npcm-video.c | 2 +- drivers/media/platform/nxp/imx7-media-csi.c | 2 +- .../platform/nxp/imx8-isi/imx8-isi-video.c | 2 +- drivers/media/platform/qcom/venus/vdec.c | 4 +-- drivers/media/platform/qcom/venus/venc.c | 4 +-- .../platform/renesas/rcar-vin/rcar-dma.c | 2 +- drivers/media/platform/renesas/renesas-ceu.c | 2 +- .../platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- drivers/media/platform/renesas/sh_vou.c | 2 +- .../platform/rockchip/rkisp1/rkisp1-capture.c | 2 +- drivers/media/platform/st/sti/hva/hva-v4l2.c | 4 +-- drivers/media/platform/st/stm32/stm32-dcmi.c | 2 +- .../platform/sunxi/sun4i-csi/sun4i_dma.c | 2 +- .../sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +- .../media/platform/sunxi/sun8i-di/sun8i-di.c | 4 +-- .../sunxi/sun8i-rotate/sun8i_rotate.c | 4 +-- .../media/platform/ti/am437x/am437x-vpfe.c | 2 +- drivers/media/platform/ti/cal/cal-video.c | 2 +- .../media/platform/ti/davinci/vpif_capture.c | 2 +- .../media/platform/ti/davinci/vpif_display.c | 2 +- .../platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +- drivers/media/platform/ti/omap/omap_vout.c | 2 +- .../media/test-drivers/vimc/vimc-capture.c | 2 +- drivers/media/test-drivers/vivid/vivid-core.c | 4 +-- drivers/media/usb/cx231xx/cx231xx-417.c | 2 +- drivers/media/usb/cx231xx/cx231xx-video.c | 4 +-- drivers/media/usb/dvb-usb/cxusb-analog.c | 2 +- drivers/media/usb/gspca/gspca.c | 6 ++--- .../media/deprecated/atmel/atmel-isc-base.c | 2 +- drivers/staging/media/imx/imx-media-capture.c | 2 +- drivers/staging/media/ipu3/ipu3-v4l2.c | 2 +- drivers/staging/media/meson/vdec/vdec.c | 6 ++--- .../staging/media/starfive/camss/stf-video.c | 2 +- .../media/sunxi/sun6i-isp/sun6i_isp_capture.c | 2 +- .../media/sunxi/sun6i-isp/sun6i_isp_params.c | 2 +- drivers/staging/media/tegra-video/vi.c | 2 +- include/media/videobuf2-core.h | 10 +++++-- samples/v4l/v4l2-pci-skeleton.c | 2 +- 67 files changed, 102 insertions(+), 95 deletions(-)