| Message ID | 20231215090813.15610-1-benjamin.gaignard@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add DELETE_BUF ioctl | expand |
Le 15/12/2023 à 10:08, Benjamin Gaignard a écrit : > Unlike when resolution change on keyframes, dynamic resolution change > on inter frames doesn't allow to do a stream off/on sequence because > it is need to keep all previous references alive to decode inter frames. > This constraint have two main problems: > - more memory consumption. > - more buffers in use. > To solve these issue this series introduce DELETE_BUFS ioctl and remove > the 32 buffers limit per queue. > > VP9 conformance tests using fluster give a score of 210/305. > The 23 of the 24 resize inter tests (vp90-2-21-resize_inter_* files) are ok > but require to use postprocessor. > > Kernel branch is available here: > https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/commits/remove_vb2_queue_limit_v16 > > GStreamer branch to use DELETE_BUF ioctl and testing dynamic resolution > change is here: > https://gitlab.freedesktop.org/benjamin.gaignard1/gstreamer/-/commits/VP9_drc > > changes in version 16: > - The 50 patches related to add helpers for queue num_bufefrs have already been merged. > - 'min_queued_buffers' patch has been merged too. > - Add 'min_reqbufs_allocation' field in vb2_queue structure. > - Take care of 'min_queued_buffers' when deleting buffers > - Add more check about buffers range limit when deleting buffers. A little ping after the holidays about this series. Thanks, Benjamin > > changes in version 15: > - Check that PLANE_INDEX_BITS value match with VIDEO_MAX_PLANES. > - Add a check on vb->vb2_queue in vb2_queue_add_buffer() > - Fix the remarks done by Hans, Thomasz and Andrzej. Thanks for the time > they spend (again) on the review. > > changes in version 14: > - Add max_num_buffers fields in v4l2_create_buffers32 structure and copy > it from/to user data. > - Fix patch 44 commit header. > - Fix v4l_print_create_buffers() log. > > Benjamin Gaignard (8): > videobuf2: Add min_reqbufs_allocation field to vb2_queue structure > media: test-drivers: Set REQBUFS minimum number of buffers > media: core: Rework how create_buf index returned value is computed > media: core: Add bitmap manage bufs array entries > media: core: Free range of buffers > media: v4l2: Add DELETE_BUFS ioctl > media: v4l2: Add mem2mem helpers for DELETE_BUFS ioctl > media: test-drivers: Use helper for DELETE_BUFS ioctl > > .../userspace-api/media/v4l/user-func.rst | 1 + > .../media/v4l/vidioc-delete-bufs.rst | 79 ++++++++ > .../media/v4l/vidioc-reqbufs.rst | 1 + > .../media/common/videobuf2/videobuf2-core.c | 171 +++++++++++++----- > .../media/common/videobuf2/videobuf2-v4l2.c | 40 +++- > .../media/platform/verisilicon/hantro_drv.c | 1 + > .../media/platform/verisilicon/hantro_v4l2.c | 1 + > .../media/test-drivers/vicodec/vicodec-core.c | 2 + > drivers/media/test-drivers/vim2m.c | 2 + > .../media/test-drivers/vimc/vimc-capture.c | 4 +- > drivers/media/test-drivers/visl/visl-video.c | 2 + > drivers/media/test-drivers/vivid/vivid-core.c | 17 +- > drivers/media/v4l2-core/v4l2-dev.c | 1 + > drivers/media/v4l2-core/v4l2-ioctl.c | 19 ++ > drivers/media/v4l2-core/v4l2-mem2mem.c | 20 ++ > include/media/v4l2-ioctl.h | 4 + > include/media/v4l2-mem2mem.h | 12 ++ > include/media/videobuf2-core.h | 47 ++++- > include/media/videobuf2-v4l2.h | 13 ++ > include/uapi/linux/videodev2.h | 17 ++ > 20 files changed, 386 insertions(+), 68 deletions(-) > create mode 100644 Documentation/userspace-api/media/v4l/vidioc-delete-bufs.rst >