mbox series

[0/9] media: atomisp: Changes for libcamera support

Message ID 20240217112438.15240-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series media: atomisp: Changes for libcamera support | expand

Message

Hans de Goede Feb. 17, 2024, 11:24 a.m. UTC
Hi All,

Here is a series of cleanups (prep work) + some small(ish)
changes to make the atomisp driver work with libcamera.

This has been tested with libcamera's simple pipelinehandler
together with an ov2680 sensor.

Regards,

Hans

p.s.

Andy, I known I still need to do some small cleanups from my last
pull-requests. I have this on my TODO list :)


Hans de Goede (9):
  media: atomisp: Remove isp_subdev_propagate()
  media: atomisp: Rename atomisp_set_crop_and_fmt()
  media: atomisp: Remove custom VCM handling
  media: atomisp: Remove ISP controls which get passed through to the
    camera
  media: atomisp: Stop setting sd->devnode for the ATOMISP_SUBDEV
    v4l2-subdev
  media: atomisp: Add DMABUF support
  media: atomisp: Change ISP subdev name to "ATOM ISP"
  media: atomisp: Make MC link from ISP to /dev/video# output node
    immutable
  media: atomisp: Implement link_setup op for ISP subdev MC entity

 .../media/atomisp/include/linux/atomisp.h     |  24 --
 .../atomisp/include/linux/atomisp_platform.h  |   5 +-
 .../staging/media/atomisp/pci/atomisp_cmd.c   |  12 +-
 .../media/atomisp/pci/atomisp_internal.h      |   4 -
 .../staging/media/atomisp/pci/atomisp_ioctl.c | 333 +-----------------
 .../media/atomisp/pci/atomisp_subdev.c        |  95 +++--
 .../staging/media/atomisp/pci/atomisp_v4l2.c  |  18 +-
 7 files changed, 72 insertions(+), 419 deletions(-)

Comments

Andy Shevchenko Feb. 17, 2024, 6:53 p.m. UTC | #1
On Sat, Feb 17, 2024 at 1:24 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> Here is a series of cleanups (prep work) + some small(ish)
> changes to make the atomisp driver work with libcamera.
>
> This has been tested with libcamera's simple pipelinehandler
> together with an ov2680 sensor.

With some minor comments,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


> p.s.
>
> Andy, I known I still need to do some small cleanups from my last
> pull-requests. I have this on my TODO list :)

Hope you will find time to address. Thanks for maintaining this driver!
Hans de Goede Feb. 18, 2024, 11:15 a.m. UTC | #2
Hi Andy,

On 2/17/24 19:53, Andy Shevchenko wrote:
> On Sat, Feb 17, 2024 at 1:24 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi All,
>>
>> Here is a series of cleanups (prep work) + some small(ish)
>> changes to make the atomisp driver work with libcamera.
>>
>> This has been tested with libcamera's simple pipelinehandler
>> together with an ov2680 sensor.
> 
> With some minor comments,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Thank you for all the reviews.

Regards,

Hans