mbox series

[v2,0/5] media: uapi: pisp_be: More late fixes

Message ID 20240628132948.871568-1-jacopo.mondi@ideasonboard.com (mailing list archive)
Headers show
Series media: uapi: pisp_be: More late fixes | expand

Message

Jacopo Mondi June 28, 2024, 1:29 p.m. UTC
A few more late fixes for the PiSP BE driver, just merged in media stage.

I kindly ask to prioritize these ones to make sure they get in at the same time
as the PiSP BE driver.

The first shouldn't be controversial: BIT() should not be in uAPI.

The second patch has been blessed by RPi and the third one is a request
from Sakari to rename format identifier macros to use capital letters.

The fourth and the fifth fixes are new and steam from having tested the
following software stack:

	RaspberryPi v6.6 BSP kernel with the PiSP BE driver backported +
	libpisp ported to use the header from this series +
	libcamera ported to use the header from this series

The last two patches complete the header to the latest version of the uAPI
from the BSP driver and are actual fixes as the driver logic expects a certain
size and ordering of fields in the config structure.

I have now compared with pahole the size of the pisp_be_config structures
between mainline and the BSP and they match, so the uAPI is actually now
inter-changable.

All the components are available at:
https://github.com/jmondi/libpisp/tree/pispbe/port-to-v11-header
https://github.com/jmondi/libcamera/tree/pispbe/rpi-main/port-to-mainline
https://github.com/jmondi/raspberrypi-linux/tree/pispbe/rpi-6.6.y/backport-mainline-pispbe

(I used github just to be ready to send pull requests to the RPi repositories)

CI pipeline:
https://gitlab.freedesktop.org/linux-media/users/jmondi/-/pipelines/1212611

Jacopo Mondi (5):
  media: uapi: pisp_be_config: Drop BIT() from uAPI
  media: uapi: pisp_common: Add 32 bpp format test
  media: uapi: pisp_common: Capitalize all macros
  media: uapi: pisp_be_config: Re-sort pisp_be_tiles_config
  media: uapi: pisp_be_config: Add extra config fields

 .../linux/media/raspberrypi/pisp_be_config.h  | 45 ++++++++++++++++++-
 .../linux/media/raspberrypi/pisp_common.h     | 39 ++++++++--------
 2 files changed, 64 insertions(+), 20 deletions(-)

--
2.45.2