| Message ID | 20241125092146.1561901-1-yuji2.ishikawa@toshiba.co.jp (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Toshiba Visconti Video Input Interface driver | expand |
On 25/11/2024 10:21, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the MIPI CSI-2 Receiver found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> How newly added patch can have already Rb tag? Was this review really, really performed internally or you just satisfy some internal managers requirements and fake the stats? > --- > > Changelog v12: > - Newly add bindings for CSI2RX driver > > .../media/toshiba,visconti5-csi2rx.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > new file mode 100644 > index 000000000000..5488072bc82a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti5-csi2rx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > + > +description: |- Drop |- > + Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI CSI-2 video > + stream. Use with VIIF device. T.B.D > + > +properties: > + compatible: > + const: toshiba,visconti5-csi2rx Why this is called "RX"? Can you have a TX? I had impression that one cannot. > + > + reg: > + items: > + - description: Registers for CSI2 receiver control > + > + interrupts: > + items: > + - description: CSI2 Receiver Interrupt > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port node, single endpoint describing the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: CSI2 receiver supports 1, 2, 3 or 4 data lanes > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port node, single endpoint describing the Visconti VIIF. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - interrupts > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + csi2rx@1c008000 { csi@ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
This series is the Video Input Interface driver for Toshiba's ARM SoC, Visconti. This provides DT binding documentation, device driver, documentation and MAINTAINER files. A visconti VIIF driver instance exposes 1 media control device file, 3 video device files for capture and 2 video device files for controlling image signal processor. Detailed HW/SW are described in documentation directory. The VIIF hardware has CSI2 receiver, image signal processor and video DMAC. The device driver depends on two other drivers under development; clock framework driver and IOMMU driver. Corresponding features will be added later. Best regards, Yuji Changelog v2: - Resend v1 because a patch exceeds size limit. Changelog v3: - Add documentation to describe SW and HW - Adapted to media control framework - Introduced ISP subdevice, capture device - Remove private IOCTLs and add vendor specific V4L2 controls - Change function name avoiding camelcase and uppercase letters Changelog v4: - Split patches because a patch exceeds size limit - fix dt-bindings document - stop specifying ID numbers for driver instance explicitly at device tree - use pm_runtime to trigger initialization of HW along with open/close of device files. - add a entry for a header file at MAINTAINERS file Changelog v5: - Fix coding style problem in viif.c (patch 2/6) Changelog v6: - add register definition of BUS-IF and MPU in dt-bindings - add CSI2RX subdevice (separated from ISP subdevice) - change directory layout (moved to media/platform/toshiba/visconti) - change source file layout (removed hwd_xxxx.c) - pointer to userland memory is removed from uAPI parameters - change register access (from struct style to macro style) - remove unused macros Changelog v7: - remove redundant "bindings" from header and description text - fix multiline text of "description" - change "compatible" to "visconti5-viif" - explicitly define allowed properties for port::endpoint - remove unused variables - update kerneldoc comments - update references to headers Changelog v8: - rename bindings description file - remove/simplify items in bindings - update operations around v4l2_async_notifier - use v4l2_async_connection instead of v4l2_async_subdev - use dev_err_probe() - better error handling at probe - remove redundant mutex - add V4L2_CTRL_TYPE_VISCONTI_ISP constant Changelog v9: - dictionary ordering of dt-bindings properties - applied sparse checker - call div64_u64 for 64bit division - rebase to media_staging tree - fix warning for cast between ptr and dma_addr_t Changelog v10: - add an independent entry in MAINTAINERS - add paddings to uAPI structs - use parameter buffer to control ISP (instead of vendor specific controls) Changelog v11: - stop merging sensor's controls and capture device's - fix strange indents at initializations - remove feature VB2_USERPTR from viif_params and viif_stats - fix usage in the document Changelog v12: - Separated CSI2RX driver and made it independent driver - Add a bindings for CSI2RX driver - Add description of parameter/statistics interface to v4l2-ioctl.c - use PM_RUNTIME_OPS macro for power management routines - use v4l2_subdev_enable_streams() to start streaming - implement callback enable_streams and disable_streams, instead of s_stream - add spinlocks for variables shared among interrupt handlers - use guard(spinlock)(locked_variable) macros - call pm_runtime APIs at start/stop streaming, instead of file handle callbacks - add new "resizer" subdevice between ISP and Capture devices. - update capability of sub path capture: capture only RAW8 or RAW16 - document: add description of CSI2RX driver - document: add description of resizer subdevice - document: add block diagrams of VIIF and ISP - document: update usage of the driver Yuji Ishikawa (8): dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface media: uapi: add visconti viif meta buffer format media: platform: visconti: Add Toshiba Visconti CSI-2 Receiver driver media: platform: visconti: Add Toshiba Visconti Video Input Interface driver media: platform: visconti: Add streaming interface for ISP parameters and status documentation: media: add documentation for Toshiba Visconti Video Input Interface driver MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface .../admin-guide/media/v4l-drivers.rst | 1 + .../admin-guide/media/visconti-viif.dot | 22 + .../admin-guide/media/visconti-viif.rst | 435 ++++ .../media/toshiba,visconti5-csi2rx.yaml | 104 + .../media/toshiba,visconti5-viif.yaml | 95 + .../userspace-api/media/v4l/meta-formats.rst | 1 + .../media/v4l/metafmt-visconti-viif.rst | 48 + MAINTAINERS | 12 + drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 1 + drivers/media/platform/toshiba/Kconfig | 6 + drivers/media/platform/toshiba/Makefile | 2 + .../media/platform/toshiba/visconti/Kconfig | 34 + .../media/platform/toshiba/visconti/Makefile | 10 + .../platform/toshiba/visconti/csi2rx_drv.c | 791 +++++++ .../media/platform/toshiba/visconti/viif.c | 598 +++++ .../media/platform/toshiba/visconti/viif.h | 379 +++ .../platform/toshiba/visconti/viif_capture.c | 1285 +++++++++++ .../platform/toshiba/visconti/viif_capture.h | 21 + .../platform/toshiba/visconti/viif_common.c | 239 ++ .../platform/toshiba/visconti/viif_common.h | 45 + .../platform/toshiba/visconti/viif_isp.c | 911 ++++++++ .../platform/toshiba/visconti/viif_isp.h | 19 + .../platform/toshiba/visconti/viif_params.c | 2034 +++++++++++++++++ .../platform/toshiba/visconti/viif_params.h | 24 + .../platform/toshiba/visconti/viif_regs.h | 717 ++++++ .../platform/toshiba/visconti/viif_resizer.c | 491 ++++ .../platform/toshiba/visconti/viif_resizer.h | 18 + .../platform/toshiba/visconti/viif_stats.c | 301 +++ .../platform/toshiba/visconti/viif_stats.h | 14 + drivers/media/v4l2-core/v4l2-ioctl.c | 2 + include/uapi/linux/videodev2.h | 4 + include/uapi/linux/visconti_viif.h | 1921 ++++++++++++++++ 33 files changed, 10586 insertions(+) create mode 100644 Documentation/admin-guide/media/visconti-viif.dot create mode 100644 Documentation/admin-guide/media/visconti-viif.rst create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml create mode 100644 Documentation/userspace-api/media/v4l/metafmt-visconti-viif.rst create mode 100644 drivers/media/platform/toshiba/Kconfig create mode 100644 drivers/media/platform/toshiba/Makefile create mode 100644 drivers/media/platform/toshiba/visconti/Kconfig create mode 100644 drivers/media/platform/toshiba/visconti/Makefile create mode 100644 drivers/media/platform/toshiba/visconti/csi2rx_drv.c create mode 100644 drivers/media/platform/toshiba/visconti/viif.c create mode 100644 drivers/media/platform/toshiba/visconti/viif.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_capture.c create mode 100644 drivers/media/platform/toshiba/visconti/viif_capture.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_common.c create mode 100644 drivers/media/platform/toshiba/visconti/viif_common.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_isp.c create mode 100644 drivers/media/platform/toshiba/visconti/viif_isp.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_params.c create mode 100644 drivers/media/platform/toshiba/visconti/viif_params.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_regs.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_resizer.c create mode 100644 drivers/media/platform/toshiba/visconti/viif_resizer.h create mode 100644 drivers/media/platform/toshiba/visconti/viif_stats.c create mode 100644 drivers/media/platform/toshiba/visconti/viif_stats.h create mode 100644 include/uapi/linux/visconti_viif.h