mbox series

[RFC,0/1] Set uvc_no_drop parameter for MJPEG_NO_EOF quirk

Message ID 20241217112138.1891708-1-isaac.scott@ideasonboard.com (mailing list archive)
Headers show
Series Set uvc_no_drop parameter for MJPEG_NO_EOF quirk | expand

Message

Isaac Scott Dec. 17, 2024, 11:21 a.m. UTC 
This patch refers to the UVC_QUIRK_MJPEG_NO_EOF quirk. The series can be
viewed at: 

https://lore.kernel.org/all/20241128145144.61475-1-isaac.scott@ideasonboard.com/

In use cases where a camera needs to use the UVC_QUIRK_MJPEG_NO_EOF,
erroneous frames that do not conform to MJPEG standards are correctly
being marked as erroneous. However, if this happens, we should avoid
losing a whole frame of data by enabling the uvc_no_drop parameter. Only
the buffer containing the EOF is lost, so it does not make sense to drop
the entirety of an otherwise correct buffer just because of this issue.
The frame should be marked as erroneous, but the otherwise correct frame
should be passed to user space.

To do this, you would have to enable the uvc_no_drop parameter. To avoid
the extra steps needed to configure the kernel in such a way, enable the
no_drop parameter by default to comply with this use case.


Isaac Scott (1):
  media: uvcvideo: Add no drop parameter by default for MJPEG_NO_EOF
    quirk

 drivers/media/usb/uvc/uvc_driver.c | 7 +++++++
 1 file changed, 7 insertions(+)