| Message ID | 20250123-v4h-iif-v1-0-7b4e5299939f@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: renesas: vsp1: Add support for IIF | expand |
Hi Jacopo, Thanks for your series. On 2025-01-23 18:04:01 +0100, Jacopo Mondi wrote: > The IIF (ISP InterFace) is specialized BRU version that reads data from > external memory using two RPF instances and feed it to the ISP. > > The IIF support is modeled in the vsp1 driver as a new, simple, entity type. > > IIF is part of VSPX, a version of the VSP2 IP specialized for ISP > interfacing. To prepare to support VSPX, support IIF first by > introducing a new entity and by adjusting the RPF/WPF drivers to > operate correctly when an IIF is present. > > Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com> I'm no expert on the VSP1, but the changes looks good. For the whole series, Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > Jacopo Mondi (6): > media: vsp1: Add support IIF ISP Interface > media: vsp1: Enable FREE interrupt > media: vsp1: dl: Use singleshot DL for VSPX > media: vsp1: rwpf: Break out format handling > media: vsp1: rwpf: Support RAW Bayer and ISP config > media: vsp1: rwpf: Support operations with IIF > > drivers/media/platform/renesas/vsp1/Makefile | 2 +- > drivers/media/platform/renesas/vsp1/vsp1.h | 3 + > drivers/media/platform/renesas/vsp1/vsp1_dl.c | 7 +- > drivers/media/platform/renesas/vsp1/vsp1_drv.c | 14 ++- > drivers/media/platform/renesas/vsp1/vsp1_entity.c | 8 ++ > drivers/media/platform/renesas/vsp1/vsp1_entity.h | 1 + > drivers/media/platform/renesas/vsp1/vsp1_iif.c | 134 ++++++++++++++++++++++ > drivers/media/platform/renesas/vsp1/vsp1_iif.h | 31 +++++ > drivers/media/platform/renesas/vsp1/vsp1_pipe.c | 1 + > drivers/media/platform/renesas/vsp1/vsp1_pipe.h | 1 + > drivers/media/platform/renesas/vsp1/vsp1_regs.h | 7 ++ > drivers/media/platform/renesas/vsp1/vsp1_rpf.c | 66 ++++++----- > drivers/media/platform/renesas/vsp1/vsp1_rwpf.c | 42 +++++-- > drivers/media/platform/renesas/vsp1/vsp1_wpf.c | 23 +++- > 14 files changed, 293 insertions(+), 47 deletions(-) > --- > base-commit: 94794b5ce4d90ab134b0b101a02fddf6e74c437d > change-id: 20250123-v4h-iif-a1dda640c95d > > Best regards, > -- > Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com> >
The IIF (ISP InterFace) is specialized BRU version that reads data from external memory using two RPF instances and feed it to the ISP. The IIF support is modeled in the vsp1 driver as a new, simple, entity type. IIF is part of VSPX, a version of the VSP2 IP specialized for ISP interfacing. To prepare to support VSPX, support IIF first by introducing a new entity and by adjusting the RPF/WPF drivers to operate correctly when an IIF is present. Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com> --- Jacopo Mondi (6): media: vsp1: Add support IIF ISP Interface media: vsp1: Enable FREE interrupt media: vsp1: dl: Use singleshot DL for VSPX media: vsp1: rwpf: Break out format handling media: vsp1: rwpf: Support RAW Bayer and ISP config media: vsp1: rwpf: Support operations with IIF drivers/media/platform/renesas/vsp1/Makefile | 2 +- drivers/media/platform/renesas/vsp1/vsp1.h | 3 + drivers/media/platform/renesas/vsp1/vsp1_dl.c | 7 +- drivers/media/platform/renesas/vsp1/vsp1_drv.c | 14 ++- drivers/media/platform/renesas/vsp1/vsp1_entity.c | 8 ++ drivers/media/platform/renesas/vsp1/vsp1_entity.h | 1 + drivers/media/platform/renesas/vsp1/vsp1_iif.c | 134 ++++++++++++++++++++++ drivers/media/platform/renesas/vsp1/vsp1_iif.h | 31 +++++ drivers/media/platform/renesas/vsp1/vsp1_pipe.c | 1 + drivers/media/platform/renesas/vsp1/vsp1_pipe.h | 1 + drivers/media/platform/renesas/vsp1/vsp1_regs.h | 7 ++ drivers/media/platform/renesas/vsp1/vsp1_rpf.c | 66 ++++++----- drivers/media/platform/renesas/vsp1/vsp1_rwpf.c | 42 +++++-- drivers/media/platform/renesas/vsp1/vsp1_wpf.c | 23 +++- 14 files changed, 293 insertions(+), 47 deletions(-) --- base-commit: 94794b5ce4d90ab134b0b101a02fddf6e74c437d change-id: 20250123-v4h-iif-a1dda640c95d Best regards,