mbox series

[RFC,0/3] Enable support for error detection in CSI2RX

Message ID 20250212131244.1397722-1-y-abhilashchandra@ti.com (mailing list archive)
Headers show
Series Enable support for error detection in CSI2RX | expand

Message

Yemike Abhilash Chandra Feb. 12, 2025, 1:12 p.m. UTC
This patch series enables the csi2rx_err_irq interrupt to record any errors
that occur during streaming. It also adds support for the VIDIOC_LOG_STATUS
ioctl, which outputs the current device status to the kernel log.

The IRQ handler records any errors encountered during streaming.
Additionally, VIDIOC_LOG_STATUS can be invoked from user space to retrieve
the latest status.

Logs with interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/58ced4df0158efad6f453b4d96463723
Logs without interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/d807230b2a624b7a38effed89efdd148

Yemike Abhilash Chandra (3):
  dt-bindings: media: cdns,csi2rx.yaml: Add optional interrupts for
    cdns-csi2rx
  media: cadence: csi2rx: Enable csi2rx_err_irq interrupt and add
    support for VIDIOC_LOG_STATUS
  media: ti: j721e-csi2rx: Add support for VIDIOC_LOG_STATUS

 .../bindings/media/cdns,csi2rx.yaml           |  11 ++
 drivers/media/platform/cadence/cdns-csi2rx.c  | 104 +++++++++++++++++-
 .../platform/ti/j721e-csi2rx/j721e-csi2rx.c   |  10 ++
 3 files changed, 124 insertions(+), 1 deletion(-)

Comments

Conor Dooley Feb. 12, 2025, 7:16 p.m. UTC | #1
On Wed, Feb 12, 2025 at 06:42:41PM +0530, Yemike Abhilash Chandra wrote:
> This patch series enables the csi2rx_err_irq interrupt to record any errors
> that occur during streaming. It also adds support for the VIDIOC_LOG_STATUS
> ioctl, which outputs the current device status to the kernel log.
> 
> The IRQ handler records any errors encountered during streaming.
> Additionally, VIDIOC_LOG_STATUS can be invoked from user space to retrieve
> the latest status.
> 
> Logs with interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/58ced4df0158efad6f453b4d96463723
> Logs without interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/d807230b2a624b7a38effed89efdd148

What is actually RFC about this patchset, rather than just being v1?
Yemike Abhilash Chandra Feb. 13, 2025, 7:10 a.m. UTC | #2
On 13/02/25 00:46, Conor Dooley wrote:
> On Wed, Feb 12, 2025 at 06:42:41PM +0530, Yemike Abhilash Chandra wrote:
>> This patch series enables the csi2rx_err_irq interrupt to record any errors
>> that occur during streaming. It also adds support for the VIDIOC_LOG_STATUS
>> ioctl, which outputs the current device status to the kernel log.
>>
>> The IRQ handler records any errors encountered during streaming.
>> Additionally, VIDIOC_LOG_STATUS can be invoked from user space to retrieve
>> the latest status.
>>
>> Logs with interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/58ced4df0158efad6f453b4d96463723
>> Logs without interrupt in DT: https://gist.github.com/Yemike-Abhilash-Chandra/d807230b2a624b7a38effed89efdd148
> 
> What is actually RFC about this patchset, rather than just being v1?

I sent this as an RFC to gather input from different vendors using the
cdns,csi2rx driver and its device tree bindings. so I just wanted to
get their feedback as well. If there are no concerns from any of the them,
I will proceed with sending this as v1.

Thanks and Regards,
Yemike Abhilash Chandra