From patchwork Wed Jun 19 23:05:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gergo Koteles X-Patchwork-Id: 13704710 Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E6A768EC; Wed, 19 Jun 2024 23:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.85.9.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718838440; cv=none; b=kHNObyZTxWuBM/mEG9/XnY7FdoKz6y38vLsB65sAFP/zbMlHbWIEcxjIKAu/+uf8nRKLmhThHYbaJkkFswJObUVjgYxz8olvr+PvRWbAjwcquLR/8ydkdXqkYD8KNDrR/nuQbNhgmkEWMm66SBbwunAhLol8TXHcsNwKhjOZga8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718838440; c=relaxed/simple; bh=9HsR6ljcoMUVKNNH+pR4AbSIfJq+cfzP3SRKSNQEtfE=; h=From:To:Cc:Subject:Date:Message-ID:Mime-Version:Content-Type; b=UtSySJGLdzbTmge+hzcAB3Lo0LOXk5XTVO9hVZAv/RMe0u6OCEbE2HuxffDIVSJ0WOzrjuxcX60MltfFVG3h8uEmL3F8cyNmLiUvXX/G6yxDzl/psQwLconTGB8r4kueBbPDjKjDX74VvQXaiYXUXCSODO78Cv50eMEdDXfCcZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu; spf=pass smtp.mailfrom=irl.hu; arc=none smtp.client-ip=95.85.9.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from fedori.lan (51b69c7d.dsl.pool.telekom.hu [::ffff:81.182.156.125]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 000000000006FE9C.00000000667364A5.002E43E5; Thu, 20 Jun 2024 01:07:17 +0200 From: Gergo Koteles To: Laurent Pinchart , Mauro Carvalho Chehab , John Bauer , ribalda@chromium.org, linh.tp.vu@gmail.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Gergo Koteles Subject: [PATCH v4 0/1] media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix Date: Thu, 20 Jun 2024 01:05:12 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 Hello, I applied Ricardo's suggestion. And I found a few ways to improve the style. I've also added Ricardo's reviewed-by tag as these are just style changes. --- Changes in v4: - Based on Ricardo's suggestion, only query the min value in uvc_ctrl_set if necessary - Rename is_relative_ptz_ctrl function to uvc_ctrl_is_relative_ptz for consistency - Rename 'relative speed implementation' to 'relative PTZ controls' in comments - Fix indentation of comments - Reduce the length of the new lines to 80 - Link to v3: https://lore.kernel.org/all/cover.1718726777.git.soyer@irl.hu/ Changes in v3: - Based on Ricardo's suggestion, I squashed the two patches. - Link to v2: https://lore.kernel.org/all/20240405-uvc-fix-relative-ptz-speed-v1-0-c32cdb2a899d@securitylive.com/ Changes in v2: - Made recommended changes, moved control check to helper function and removed dead code. - Link to v1: https://lore.kernel.org/all/20240326-uvc-relative-ptz-speed-fix-v1-1-453fd5ccfd37@securitylive.com/ --- John Bauer (1): media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix. drivers/media/usb/uvc/uvc_ctrl.c | 42 ++++++++++++++++++++++++++------ 1 file changed, 35 insertions(+), 7 deletions(-)