From patchwork Mon Sep 23 01:44:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925621 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BD6D9BFF05 for ; Mon, 23 Sep 2013 01:44:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0740D2052D for ; Mon, 23 Sep 2013 01:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D437E20529 for ; Mon, 23 Sep 2013 01:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994Ab3IWBot (ORCPT ); Sun, 22 Sep 2013 21:44:49 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34567 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775Ab3IWBos (ORCPT ); Sun, 22 Sep 2013 21:44:48 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00J4E24TWMH0@mailout3.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:44:35 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 53.D1.20109.30D9F325; Mon, 23 Sep 2013 10:44:35 +0900 (KST) X-AuditID: cbfee68f-b7f1e6d000004e8d-32-523f9d0391fd Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 7B.19.09055.30D9F325; Mon, 23 Sep 2013 10:44:35 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK00EID26BAV50@mmp1.samsung.com>; Mon, 23 Sep 2013 10:44:35 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' , 'Hans Verkuil' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 01/10] [media] saa7146: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:44:35 +0900 Message-id: <003701ceb7fe$750dadd0$5f290970$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAAmiw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t8zfV3mufZBBn/aFSxOTX7GZHF54SVW i54NW1ktLq6Td2Dx6NuyitHj8yY5j1NfP7MHMEdx2aSk5mSWpRbp2yVwZexe7lZwi63i4LKp 7A2M51m7GDk5JARMJDraDzBC2GISF+6tZ+ti5OIQEljGKHH5/Gc2mKIV3w8wQyQWMUr8bZrF AuH8YpRovbmZBaSKTUBN4suXw+wgtoiAkcSO+XOYuhg5OJgFsiSebfcACQsJ2Eo0z/4INpRT wE7i997NTCC2sICPRPPjJ8wgNouAqsTDWf1gNi9Q/bnDa9ghbEGJH5Pvga1iFtCSWL/zOBOE LS+xec1bZpBVEgLqEo/+6oKYIBdcf24CUSEise/FO0aQiyUEDrFLvGq5zwaxSkDi2+RDLBCt shKbDjBDvCspcXDFDZYJjBKzkCyehWTxLCSLZyFZsYCRZRWjaGpBckFxUnqRsV5xYm5xaV66 XnJ+7iZGSBT272C8e8D6EGMy0PqJzFKiyfnAKM4riTc0NjOyMDUxNTYytzQjTVhJnFetxTpQ SCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA6PakpWXbrxaxbrmUO4bvskJc/SLuc0nql/4FJ0b GD3Z4ebnJ1cDUhz+tvgsf+8jfWi/Oo/2klvXt9f/87ikVegj/qk5azOjBm+uj4D/1+zEY1Jh Zu4nnOYqy196wLOQgS3Zoi3ybpOe1ZGMjX4Giasa3ttcOppacHx/uryiSxCTlFvDM6XKCCWW 4oxEQy3mouJEAM3lN47YAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsVy+t9jAV3mufZBBv+my1icmvyMyeLywkus Fj0btrJaXFwn78Di0bdlFaPH501yHqe+fmYPYI5qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneO NzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAdqmpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3 JAiux8gADSSsY8zYvdyt4BZbxcFlU9kbGM+zdjFyckgImEis+H6AGcIWk7hwbz1bFyMXh5DA IkaJv02zWCCcX4wSrTc3s4BUsQmoSXz5cpgdxBYRMJLYMX8OUxcjBwezQJbEs+0eIGEhAVuJ 5tkf2UBsTgE7id97NzOB2MICPhLNj5+ALWMRUJV4OKsfzOYFqj93eA07hC0o8WPyPbBVzAJa Eut3HmeCsOUlNq95ywyySkJAXeLRX10QE+SC689NICpEJPa9eMc4gVFoFpJBs5AMmoVk0Cwk LQsYWVYxiqYWJBcUJ6XnGuoVJ+YWl+al6yXn525iBMf4M6kdjCsbLA4xCnAwKvHwRiTaBwmx JpYVV+YeYpTgYFYS4W3qBArxpiRWVqUW5ccXleakFh9iTAb6cyKzlGhyPjD95JXEGxqbmBlZ GplZGJmYm5MmrCTOe6DVOlBIID2xJDU7NbUgtQhmCxMHp1QDY6jN8efBqkJxK6YlOU7rOt5t LzGd7bdzuK+9itD2nSyV7yUsMl819Rz9bGTNknCkYu9qnrc7Pu149pJdJX5XWeS8vNJUycsm c/kbYzu4p8Y+tZ18y32GdbLA+RzpZLnbD8r6H3xXWfhNbM/bf5FPMp/liRbx/mlcmbxh4tKJ nOlrD86U3CzOrsRSnJFoqMVcVJwIAOauCPc1AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/common/saa7146/saa7146_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/common/saa7146/saa7146_core.c b/drivers/media/common/saa7146/saa7146_core.c index bb6ee51..2c86f1a 100644 --- a/drivers/media/common/saa7146/saa7146_core.c +++ b/drivers/media/common/saa7146/saa7146_core.c @@ -524,8 +524,6 @@ static void saa7146_remove_one(struct pci_dev *pdev) DEB_EE("dev:%p\n", dev); dev->ext->detach(dev); - /* Zero the PCI drvdata after use. */ - pci_set_drvdata(pdev, NULL); /* shut down all video dma transfers */ saa7146_write(dev, MC1, 0x00ff0000);