From patchwork Mon Sep 23 01:45:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925671 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D007E9F476 for ; Mon, 23 Sep 2013 01:46:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 185912039F for ; Mon, 23 Sep 2013 01:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 469F4202DD for ; Mon, 23 Sep 2013 01:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390Ab3IWBqB (ORCPT ); Sun, 22 Sep 2013 21:46:01 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41917 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753150Ab3IWBp7 (ORCPT ); Sun, 22 Sep 2013 21:45:59 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK0026N28FKMD0@mailout2.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:45:53 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 2F.82.20109.15D9F325; Mon, 23 Sep 2013 10:45:53 +0900 (KST) X-AuditID: cbfee68f-b7f1e6d000004e8d-b1-523f9d51abb8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 32.69.09055.15D9F325; Mon, 23 Sep 2013 10:45:53 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK005GR28GOIL0@mmp2.samsung.com>; Mon, 23 Sep 2013 10:45:53 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' , 'Manu Abraham' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 02/10] [media] mantis: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:45:52 +0900 Message-id: <003801ceb7fe$a35891f0$ea09b5d0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAC/+A Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t8zQ93AufZBBp9WCVl8+b2L0eLywkus Fj0btrJaXFwn78DisXPWXXaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgymh4cZ2xoJu9YuYc ngbGz6xdjJwcEgImEpNff2OCsMUkLtxbz9bFyMUhJLCMUeLvymNMMEX7T19mhUhMZ5TYc34V O0hCSOAXo8TVVYogNpuAmsSXL4fB4iICRhI75s8Ba2YWyJNoODePDaLeVqJ59kcwm1PATuL3 3s1gNcIC3hKt26axgNgsAqoSWw4uArN5gepXz9zOCGELSvyYfI8FYqaWxPqdx6Hmy0tsXvOW uYuRA+hQdYlHf3VhTrh67DQbRImIxL4X7xhB7pcQ2MUu8X5FKyvELgGJb5MPsUD0ykpsOsAM 8a+kxMEVN1gmMErMQrJ5FpLNs5BsnoVkxQJGllWMoqkFyQXFSelFxnrFibnFpXnpesn5uZsY IXHYv4Px7gHrQ4zJQOsnMkuJJucD4zivJN7Q2MzIwtTE1NjI3NKMNGElcV61FutAIYH0xJLU 7NTUgtSi+KLSnNTiQ4xMHJxSDYyb1n1xEGyMiMk4o/osWD8rfmPPNOYNHSyZ+a/2KbQW26VO mVh604Xx3TTWU9cUmZjSdfe2yX45Knjee+6/V9sZ3jL8SmwRimztSFM49+C99Ks89uvyt2/0 NZ4ySa6cb/58lX3Im8Rnyjpp7r76e/eZGoruMb3T0ttw88x6h3l5h9tNngRMD1RiKc5INNRi LipOBAAvBYFV2QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsVy+t9jQd3AufZBBtPa+S2+/N7FaHF54SVW i54NW1ktLq6Td2Dx2DnrLrtH35ZVjB6fN8kFMEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvH m5oZGOoaWlqYKynkJeam2iq5+AToumXmAG1TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesb EgTXY2SABhLWMWY0vLjOWNDNXjFzDk8D42fWLkZODgkBE4n9py9D2WISF+6tZ+ti5OIQEpjO KLHn/Cp2kISQwC9GiaurFEFsNgE1iS9fDoPFRQSMJHbMn8MEYjML5Ek0nJvHBlFvK9E8+yOY zSlgJ/F772awGmEBb4nWbdNYQGwWAVWJLQcXgdm8QPWrZ25nhLAFJX5MvscCMVNLYv3O41Dz 5SU2r3nL3MXIAXSousSjv7owJ1w9dpoNokREYt+Ld4wTGIVmIZk0C8mkWUgmzULSsoCRZRWj aGpBckFxUnquoV5xYm5xaV66XnJ+7iZGcJQ/k9rBuLLB4hCjAAejEg9vRKJ9kBBrYllxZe4h RgkOZiUR3qZOoBBvSmJlVWpRfnxRaU5q8SHGZKBHJzJLiSbnAxNQXkm8obGJmZGlkZmFkYm5 OWnCSuK8B1qtA4UE0hNLUrNTUwtSi2C2MHFwSjUwHmiY5qD/+6DrlhPR77cfKq3xPvtIbvKX 6ZmPul0l7A1tXW9uW6nDOuUg2/5i9RXcjPv8/wlc45+28+FMBVXN5WvmHksKlhBZ2G/tH3Pe deJNvXdnnUQmMvfFhz+5+6ln8ZPXnKqs95611RfHlbknBWk7qeW9reP4uHHzp+VFPktbT3KJ TdIQV2Ipzkg01GIuKk4EAC6AwAs2AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/mantis/mantis_pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/mantis/mantis_pci.c b/drivers/media/pci/mantis/mantis_pci.c index a846036..9e89e04 100644 --- a/drivers/media/pci/mantis/mantis_pci.c +++ b/drivers/media/pci/mantis/mantis_pci.c @@ -143,7 +143,6 @@ fail1: fail0: dprintk(MANTIS_ERROR, 1, "ERROR: <%d> exiting", ret); - pci_set_drvdata(pdev, NULL); return ret; } EXPORT_SYMBOL_GPL(mantis_pci_init); @@ -161,7 +160,6 @@ void mantis_pci_exit(struct mantis_pci *mantis) } pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); } EXPORT_SYMBOL_GPL(mantis_pci_exit);