From patchwork Mon Sep 23 01:47:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925691 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 98421BFF05 for ; Mon, 23 Sep 2013 01:47:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D6D6B20529 for ; Mon, 23 Sep 2013 01:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0C1D2039F for ; Mon, 23 Sep 2013 01:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290Ab3IWBrM (ORCPT ); Sun, 22 Sep 2013 21:47:12 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:16877 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753137Ab3IWBrL (ORCPT ); Sun, 22 Sep 2013 21:47:11 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00CUB298UWC0@mailout4.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:47:10 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id AB.CB.31253.E9D9F325; Mon, 23 Sep 2013 10:47:10 +0900 (KST) X-AuditID: cbfee690-b7f3b6d000007a15-59-523f9d9eb1b5 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 9C.29.05832.E9D9F325; Mon, 23 Sep 2013 10:47:10 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK005YR2AMXPH0@mmp2.samsung.com>; Mon, 23 Sep 2013 10:47:10 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 03/10] [media] pt1: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:47:10 +0900 Message-id: <003901ceb7fe$d16d23d0$74476b70$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAF9ww Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t8zQ915c+2DDN78kLW4vPASq0XPhq2s FhfXyTswe/RtWcXo8XmTXABTFJdNSmpOZllqkb5dAlfG8lvCBYfYKyZv+8bcwLiCrYuRk0NC wETi1/+dTBC2mMSFe+vB4kICyxglPszQgKlZuv4McxcjF1B8OqPExJkHWCCcX4wSl+ZOA+tg E1CT+PLlMDuILSJgJLFj/hywqcwCzhIvNs1lhphqK9E8+yNYPaeAncTvvZvBaoQFPCTWdnwC inNwsAioSsz/ZAkS5gUqX7vuNTuELSjxY/I9FoiRWhLrdx6HGi8vsXnNW2aQVgkBdYlHf3Vh LrjetZUVokREYt+Ld4wgJ0sIrGOXuHH9OdgcFgEBiW+TD7FA9MpKbDrADPGvpMTBFTdYJjBK zEKyeRaSzbOQbJ6FZMUCRpZVjKKpBckFxUnpRSZ6xYm5xaV56XrJ+bmbGCERN2EH470D1ocY k4HWT2SWEk3OB0ZsXkm8obGZkYWpiamxkbmlGWnCSuK86i3WgUIC6YklqdmpqQWpRfFFpTmp xYcYmTg4pRoYeS5P02V86OXH/3fxvO5dM9J2ixdZ8wQa6M6UXp6V41Xc9dUubHvu1x2WByuZ Wr/VND+TLA5NYHJUVX72YVu57ZlDH+YHVUzacuj/UW0jn7nOD+a69Cw/pVTA1BRpFnpk1oxn GfwaR18tXncuONz91KeuH4b6lxkFWZp3P/pkuYixysRUz/GoEktxRqKhFnNRcSIArXM3HM4C AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsVy+t9jQd15c+2DDE5elbK4vPASq0XPhq2s FhfXyTswe/RtWcXo8XmTXABTVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmS Ql5ibqqtkotPgK5bZg7QDiWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYR1j xvJbwgWH2Csmb/vG3MC4gq2LkZNDQsBEYun6M8wQtpjEhXvrgeJcHEIC0xklJs48wALh/GKU uDR3GlgHm4CaxJcvh9lBbBEBI4kd8+cwgdjMAs4SLzbNBZskJGAr0Tz7I1g9p4CdxO+9m8Fq hAU8JNZ2fAKKc3CwCKhKzP9kCRLmBSpfu+41O4QtKPFj8j0WiJFaEut3HocaLy+xec1bZpBW CQF1iUd/dWEuuN61lRWiRERi34t3jBMYhWYhmTQLyaRZSCbNQtKygJFlFaNoakFyQXFSeq6R XnFibnFpXrpecn7uJkZwRD+T3sG4qsHiEKMAB6MSD29kon2QEGtiWXFl7iFGCQ5mJRHepk6g EG9KYmVValF+fFFpTmrxIcZkoD8nMkuJJucDk01eSbyhsYmZkaWRmYWRibk5acJK4rwHW60D hQTSE0tSs1NTC1KLYLYwcXBKNTBqic39wfN2h6bH8WoXM+65luX9S/U9zX9xzO0LW8D1hTVP rcHmd0DcV8fXXIqz73UcWf3hhejFog62q8+ytlwqWDCzQGhqePS2iQHahdmNHJo+/x9pqFt6 vpd89OHJFYeKffvXL40xn//07oxtQSclOcRaF9/6PuFtE9Plh09OvFa4ZLcoa0qYEktxRqKh FnNRcSIAK/zJBiwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/pt1/pt1.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c index 75ce142..db887b0 100644 --- a/drivers/media/pci/pt1/pt1.c +++ b/drivers/media/pci/pt1/pt1.c @@ -1076,7 +1076,6 @@ static void pt1_remove(struct pci_dev *pdev) pt1_update_power(pt1); pt1_cleanup_adapters(pt1); i2c_del_adapter(&pt1->i2c_adap); - pci_set_drvdata(pdev, NULL); kfree(pt1); pci_iounmap(pdev, regs); pci_release_regions(pdev); @@ -1198,7 +1197,6 @@ err_i2c_del_adapter: err_pt1_cleanup_adapters: pt1_cleanup_adapters(pt1); err_kfree: - pci_set_drvdata(pdev, NULL); kfree(pt1); err_pci_iounmap: pci_iounmap(pdev, regs);