From patchwork Mon Sep 23 01:48:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925701 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 319A8BFF05 for ; Mon, 23 Sep 2013 01:48:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 69A992052D for ; Mon, 23 Sep 2013 01:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45FEA20529 for ; Mon, 23 Sep 2013 01:48:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050Ab3IWBse (ORCPT ); Sun, 22 Sep 2013 21:48:34 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:42534 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752880Ab3IWBse (ORCPT ); Sun, 22 Sep 2013 21:48:34 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00G9J2CCEPE0@mailout2.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:48:33 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 2F.96.17682.DED9F325; Mon, 23 Sep 2013 10:48:29 +0900 (KST) X-AuditID: cbfee68e-b7f756d000004512-51-523f9ded7615 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id DD.79.05832.DED9F325; Mon, 23 Sep 2013 10:48:29 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK005KB2CTDTM0@mmp2.samsung.com>; Mon, 23 Sep 2013 10:48:29 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' , "'Igor M. Liplianin'" References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 04/10] [media] dm1105: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:48:29 +0900 Message-id: <003a01ceb7ff$00b812d0$02283870$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAIxyA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsVy+t8zQ923c+2DDCZ/NrK4vPASq0XPhq2s Fise3WS2uLhO3oHFY+r7Q6wefVtWMXp83iQXwBzFZZOSmpNZllqkb5fAlXFx/y+WglXsFV97 J7M0ME5k62Lk5JAQMJHYv2wSE4QtJnHh3nqgOBeHkMAyRokv368xwRTd2XyeBSIxnVHi85lb TBDOL0aJk5uXsINUsQmoSXz5chjMFhEwktgxfw5YN7NAnsSX82+YQWwhAVuJ5tkfwVZzCthJ /N67GaxGWMBb4si2D2A2i4CqxMu3N1lAbF6g+terP0PZghI/Jt9jgZipJbF+53Go+fISm9e8 BZrPAXSpusSjv7ogJsgJ7+brQFSISOx78Y4R5GQJgX3sEjNmb2KFWCUg8W3yIRaIVlmJTQeY If6VlDi44gbLBEaJWUgWz0KyeBaSxbOQrFjAyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cT IyQS+3Yw3jxgfYgxGWj9RGYp0eR8YCTnlcQbGpsZWZiamBobmVuakSasJM6r1mIdKCSQnliS mp2aWpBaFF9UmpNafIiRiYNTqoGRc/NCG9N3bTU6KgvUTBdPDOM12XVL9tImucfnGALfx33y /HI7WrXZZWq0xFrPtFZz64IJQfPNM+z4TVc8MVxnIb5c2L1aUFhpc8SSU43PzhvOSlKoNWLX FLN+dajgQj5nwHrFHSpGZ26v6Bdff5/jipQQj3gjzwEPd26v7otGq4/mOfzp+qTEUpyRaKjF XFScCAAhOIey2gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCKsWRmVeSWpSXmKPExsVy+t9jQd23c+2DDC5v17e4vPASq0XPhq2s Fise3WS2uLhO3oHFY+r7Q6wefVtWMXp83iQXwBzVwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8c b2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RNSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5v SBBcj5EBGkhYx5hxcf8vloJV7BVfeyezNDBOZOti5OSQEDCRuLP5PAuELSZx4d56oDgXh5DA dEaJz2duMUE4vxglTm5ewg5SxSagJvHly2EwW0TASGLH/DlMIDazQJ7El/NvmEFsIQFbiebZ H8E2cArYSfzeuxmsRljAW+LItg9gNouAqsTLtzfBNvMC1b9e/RnKFpT4MfkeC8RMLYn1O49D zZeX2LzmLdB8DqBL1SUe/dUFMUFOeDdfB6JCRGLfi3eMExiFZiEZNAvJoFlIBs1C0rKAkWUV o2hqQXJBcVJ6rpFecWJucWleul5yfu4mRnCcP5PewbiqweIQowAHoxIPb2SifZAQa2JZcWXu IUYJDmYlEd6mTqAQb0piZVVqUX58UWlOavEhxmSgPycyS4km5wNTUF5JvKGxiZmRpZGZhZGJ uTlpwkrivAdbrQOFBNITS1KzU1MLUotgtjBxcEo1MOo8bg+1+i/DZq13+PGttthk1ivGGy/x t+575Hm16WNWtulhkUcnbTa9qSrtevhoYbq/0bRr7l7n8uddTWnbxbHqweuHa2rFTb7ea85s q3S6vPfswj8MMsZMsjvyBTOySrmXf/iVE7dis3Qxh//Fl3Pn72eumPU5tqc9PNbswaup7teP nUnoe6bEUpyRaKjFXFScCADJ1J1UNwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/dm1105/dm1105.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index ab797fe..e985e3b 100644 --- a/drivers/media/pci/dm1105/dm1105.c +++ b/drivers/media/pci/dm1105/dm1105.c @@ -1178,7 +1178,6 @@ err_pci_release_regions: err_pci_disable_device: pci_disable_device(pdev); err_kfree: - pci_set_drvdata(pdev, NULL); kfree(dev); return ret; } @@ -1211,7 +1210,6 @@ static void dm1105_remove(struct pci_dev *pdev) pci_iounmap(pdev, dev->io_mem); pci_release_regions(pdev); pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); dm1105_devcount--; kfree(dev); }