From patchwork Mon Sep 23 01:50:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925711 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F8A99F476 for ; Mon, 23 Sep 2013 01:50:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9586320537 for ; Mon, 23 Sep 2013 01:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ABDC2052D for ; Mon, 23 Sep 2013 01:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192Ab3IWBuV (ORCPT ); Sun, 22 Sep 2013 21:50:21 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51481 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061Ab3IWBuU (ORCPT ); Sun, 22 Sep 2013 21:50:20 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK006VA2F9HR60@mailout1.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:50:19 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 5A.7D.31253.A5E9F325; Mon, 23 Sep 2013 10:50:18 +0900 (KST) X-AuditID: cbfee690-b7f3b6d000007a15-53-523f9e5a6f5c Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 4B.E9.05832.A5E9F325; Mon, 23 Sep 2013 10:50:18 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK0060U2FUADH0@mmp2.samsung.com>; Mon, 23 Sep 2013 10:50:18 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 05/10] [media] ngene: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:50:18 +0900 Message-id: <003b01ceb7ff$41b1adf0$c51509d0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAALuGg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t8zA92oefZBBlu+GVtcXniJ1aJnw1ZW i4vr5B2YPfq2rGL0+LxJLoApissmJTUnsyy1SN8ugSujv6ubveAvW8XpX9OYGhhfsnYxcnJI CJhI/H2xjB3CFpO4cG89WxcjF4eQwDJGicud8+GKdq5vZoVITGeUuLl6PiOE84tR4ueSVWwg VWwCahJfvhwGGyUiYCSxY/4cJhCbWcBZ4sWmucwgtpCArUTz7I9g9ZwCdhK/924GqxEW8JJ4 v2MHWJxFQFXi9YaPjCA2L1D96iXzoGxBiR+T77FAzNSSWL/zONR8eYnNa94CzecAulRd4tFf XZgTdn7azQhRIiKx78U7sJslBNaxS/xa3cQIsUtA4tvkQywQvbISmw4wQzwsKXFwxQ2WCYwS s5BsnoVk8ywkm2chWbGAkWUVo2hqQXJBcVJ6kYlecWJucWleul5yfu4mRkjcTdjBeO+A9SHG ZKD1E5mlRJPzgXGbVxJvaGxmZGFqYmpsZG5pRpqwkjiveot1oJBAemJJanZqakFqUXxRaU5q 8SFGJg5OqQbGmMXuV6/NcJno2nyId5915UGDL/uaXjdofUgo4Kgo6PAp9ZSo3VlRrrnvkpHh EcvZMR8vHn23KrJie36Tv1uBlsEJhym8yu59olKG14L12Z4/zc5z/2NkW3hHYKaT+4PlarHK 80ySp9wVLtdZFvl2zawnCxXTTu+Rmau+koNP906cZZljSqkSS3FGoqEWc1FxIgB9xoGd0QIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsVy+t9jQd2oefZBBgsvG1hcXniJ1aJnw1ZW i4vr5B2YPfq2rGL0+LxJLoApqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJ IS8xN9VWycUnQNctMwdoh5JCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4x o7+rm73gL1vF6V/TmBoYX7J2MXJySAiYSOxc3wxli0lcuLeerYuRi0NIYDqjxM3V8xkhnF+M Ej+XrGIDqWITUJP48uUwO4gtImAksWP+HCYQm1nAWeLFprnMILaQgK1E8+yPYPWcAnYSv/du BqsRFvCSeL9jB1icRUBV4vWGj4wgNi9Q/eol86BsQYkfk++xQMzUkli/8zjUfHmJzWveAs3n ALpUXeLRX12YE3Z+2s0IUSIise/FO8YJjEKzkEyahWTSLCSTZiFpWcDIsopRNLUguaA4KT3X SK84Mbe4NC9dLzk/dxMjOKqfSe9gXNVgcYhRgINRiYc3MtE+SIg1say4MvcQowQHs5IIb1Mn UIg3JbGyKrUoP76oNCe1+BBjMtCjE5mlRJPzgQknryTe0NjEzMjSyMzCyMTcnDRhJXHeg63W gUIC6YklqdmpqQWpRTBbmDg4pRoYN3xs+/58leqrHTe7I7fYP3Fd/Sl2X7dB7xRvtn2uPb3v fRbIhWtxJ0fJTT604b3sjaY57mU/70zxSrflSF0QbJ83Z3pS+mF2Vx6nxdmL5bqVVnAGubQ6 XJaV9jbplpbISAxcxqbEsc7igWdwMpeivu5iqeUe+c81OV0D1DtV69inucX5+CixFGckGmox FxUnAgCGGVODLgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/ngene/ngene-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c index 37ebc42..8402ed6 100644 --- a/drivers/media/pci/ngene/ngene-core.c +++ b/drivers/media/pci/ngene/ngene-core.c @@ -1648,7 +1648,6 @@ void ngene_remove(struct pci_dev *pdev) cxd_detach(dev); ngene_stop(dev); ngene_release_buffers(dev); - pci_set_drvdata(pdev, NULL); pci_disable_device(pdev); } @@ -1702,6 +1701,5 @@ fail1: ngene_release_buffers(dev); fail0: pci_disable_device(pci_dev); - pci_set_drvdata(pci_dev, NULL); return stat; }