From patchwork Mon Sep 23 01:51:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925741 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5EBDDBFF05 for ; Mon, 23 Sep 2013 01:51:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9B3CA200E7 for ; Mon, 23 Sep 2013 01:51:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D024A200DE for ; Mon, 23 Sep 2013 01:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872Ab3IWBv1 (ORCPT ); Sun, 22 Sep 2013 21:51:27 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:36198 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434Ab3IWBv1 (ORCPT ); Sun, 22 Sep 2013 21:51:27 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00CHP2GICS90@mailout3.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:51:21 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id B1.CF.29948.89E9F325; Mon, 23 Sep 2013 10:51:20 +0900 (KST) X-AuditID: cbfee691-b7f4a6d0000074fc-1c-523f9e982d7d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 9C.9A.09055.89E9F325; Mon, 23 Sep 2013 10:51:20 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK00EHJ2HKIE70@mmp1.samsung.com>; Mon, 23 Sep 2013 10:51:20 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 06/10] [media] pluto2: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:51:20 +0900 Message-id: <003c01ceb7ff$66b56330$34202990$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAPyDQ Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t8zY90Z8+yDDG6/trK4vPASq0XPhq2s FhfXyTswe/RtWcXo8XmTXABTFJdNSmpOZllqkb5dAlfGsRP/mQqms1fsuTKfvYHxP2sXIyeH hICJRGf7bjYIW0ziwr31QDYXh5DAMkaJK5O3McEUPb2zjB0isYhR4uazW4wQzi9Gid3/F4C1 swmoSXz5cpgdxBYRMJLYMX8OWDezgLPEi01zmUFsIQFbiebZH8HqOQXsJH7v3QxWIyzgLTH9 6xYwm0VAVeLA+1tAczg4eIHqb0ypBAnzCghK/Jh8jwVipJbE+p3HocbLS2xe85YZpFxCQF3i 0V9dmAsmXZwKVSIise/FO0aIXzaxSzR+KoTYJCDxbfIhFohWWYlNB5ghSiQlDq64wTKBUWIW ksWzkCyehWTxLCQbFjCyrGIUTS1ILihOSi8y1StOzC0uzUvXS87P3cQIibmJOxjvH7A+xJgM tH4is5Rocj4wZvNK4g2NzYwsTE1MjY3MLc1IE1YS51VvsQ4UEkhPLEnNTk0tSC2KLyrNSS0+ xMjEwSnVwFj+wjG3Pawhtmb9tSkPWQVUzt0s9Y+QmS4n66p9+cDV0Jq/mSrXzN+kXGV7rNPg 9kiSkSX+4+YTTOG3GoRVlv3dcXLzi99/PFw7MxYJTyirXcVmt6LCVXC9igNjrIw781XnA0LW ymGP8hYYH5EN7Cro3nh8Je/+iMqfi5m8985lEln8XWVqmRJLcUaioRZzUXEiALLGO2DPAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsVy+t9jAd0Z8+yDDN7dNre4vPASq0XPhq2s FhfXyTswe/RtWcXo8XmTXABTVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmS Ql5ibqqtkotPgK5bZg7QDiWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYR1j xrET/5kKprNX7Lkyn72B8T9rFyMnh4SAicTTO8vYIWwxiQv31rN1MXJxCAksYpS4+ewWI4Tz i1Fi9/8FbCBVbAJqEl++HAbrEBEwktgxfw4TiM0s4CzxYtNcZhBbSMBWonn2R7B6TgE7id97 N4PVCAt4S0z/ugXMZhFQlTjw/hbQHA4OXqD6G1MqQcK8AoISPybfY4EYqSWxfudxqPHyEpvX vGUGKZcQUJd49FcX5oJJF6dClYhI7HvxjnECo9AsJJNmIZk0C8mkWUhaFjCyrGIUTS1ILihO Ss811CtOzC0uzUvXS87P3cQIjulnUjsYVzZYHGIU4GBU4uGNSLQPEmJNLCuuzD3EKMHBrCTC 29QJFOJNSaysSi3Kjy8qzUktPsSYDPTnRGYp0eR8YLrJK4k3NDYxM7I0MrMwMjE3J01YSZz3 QKt1oJBAemJJanZqakFqEcwWJg5OqQbGXSuf7qwo+PWBi83O4J/D9KjVmtY8URPk5VartDS5 Gj+J3LJf8dXiMldxIes3vza/uxt/fKuwcTvHv4aEyEWuXyv/cCuwaG6VUnwko3D17U539WuP Na1V9eV1DQw0/KxYVs+/+/jybHmWuL36F6vq/6syN3/rSgyv6LfUNQ/5OWfdg1k/LF4qsRRn JBpqMRcVJwIAlpPlUi0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/pluto2/pluto2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/pluto2/pluto2.c b/drivers/media/pci/pluto2/pluto2.c index 4938285..8164d74 100644 --- a/drivers/media/pci/pluto2/pluto2.c +++ b/drivers/media/pci/pluto2/pluto2.c @@ -736,7 +736,6 @@ err_pci_release_regions: err_pci_disable_device: pci_disable_device(pdev); err_kfree: - pci_set_drvdata(pdev, NULL); kfree(pluto); goto out; } @@ -765,7 +764,6 @@ static void pluto2_remove(struct pci_dev *pdev) pci_iounmap(pdev, pluto->io_mem); pci_release_regions(pdev); pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); kfree(pluto); }