From patchwork Mon Sep 23 01:53:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925901 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 74618BFF05 for ; Mon, 23 Sep 2013 01:53:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AE84B200F8 for ; Mon, 23 Sep 2013 01:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98B59200E7 for ; Mon, 23 Sep 2013 01:53:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752990Ab3IWBxi (ORCPT ); Sun, 22 Sep 2013 21:53:38 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:18414 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752816Ab3IWBxi (ORCPT ); Sun, 22 Sep 2013 21:53:38 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00H9N2KHCZG0@mailout4.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:53:36 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 57.AF.31253.E1F9F325; Mon, 23 Sep 2013 10:53:34 +0900 (KST) X-AuditID: cbfee690-b7f3b6d000007a15-49-523f9f1eb5a9 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 5A.1B.09055.E1F9F325; Mon, 23 Sep 2013 10:53:34 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK00EA12LAAV90@mmp1.samsung.com>; Mon, 23 Sep 2013 10:53:34 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' , 'Patrick Boettcher' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 08/10] [media] b2c2: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:53:34 +0900 Message-id: <003e01ceb7ff$b6730da0$235928e0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAUECg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsVy+t8zQ125+fZBBvfvWFlcXniJ1aJnw1ZW i4vr5C1O31/O7sDi0dQ/j9Wjb8sqRo/Pm+QCmKO4bFJSczLLUov07RK4Mo7P28NY8JWjYm// XKYGxnPsXYwcHBICJhITr5l2MXICmWISF+6tZ+ti5OIQEljGKDHx61sWiISJxOybTUwQiUWM Em9u7WKFcH4xSszceZIZpIpNQE3iy5fD7CC2iICRxI75c5hAbGaBSonZV5rAbCEBW4nm2R/Z QGxOATuJ33s3g8WFBTwlzvz+wApiswioStxq7gHbzAtUv/70GSYIW1Dix+R7LBAztSTW7zwO NV9eYvOat8wQ36hLPPqrC3PC55Nv2SBKRCT2vXjHCHKzhMAudolle88zQewSkPg2+RALRK+s xKYDzBAPS0ocXHGDZQKjxCwkm2ch2TwLyeZZSFYsYGRZxSiaWpBcUJyUXmSiV5yYW1yal66X nJ+7iRESiRN2MN47YH2IMRlo/URmKdHkfGAk55XEGxqbGVmYmpgaG5lbmpEmrCTOq95iHSgk kJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBcbmD7J5Jcj8O1AlsrvfXOvHCad/xkv6wM08KDwS9 uL0ugPvDXZ3oNaoXmJ+kJ2uIT097lBVWlvCJxV7NqEG6giPOQ31Jg2JOv0eVjEyryZGlX/9y FBofExLew6H14VFwuPFuvdoDHyPWFrx4eNUw4ceBj7+0q99tyZv+3v8rg1jr5bBNseUxSizF GYmGWsxFxYkAbJ2oFdoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsVy+t9jAV25+fZBBgv6zC0uL7zEatGzYSur xcV18han7y9nd2DxaOqfx+rRt2UVo8fnTXIBzFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7x pmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QNuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqG BMH1GBmggYR1jBnH5+1hLPjKUbG3fy5TA+M59i5GTg4JAROJ2TebmCBsMYkL99azdTFycQgJ LGKUeHNrFyuE84tRYubOk8wgVWwCahJfvhwG6xYRMJLYMX8OWDezQKXE7CsQk4QEbCWaZ39k A7E5Bewkfu/dDBYXFvCUOPP7AyuIzSKgKnGruYcFxOYFql9/+gwThC0o8WPyPRaImVoS63ce h5ovL7F5zVugGziALlWXePRXF+aEzyffskGUiEjse/GOcQKj0Cwkk2YhmTQLyaRZSFoWMLKs YhRNLUguKE5KzzXUK07MLS7NS9dLzs/dxAiO9GdSOxhXNlgcYhTgYFTi4Y1ItA8SYk0sK67M PcQowcGsJMLb1AkU4k1JrKxKLcqPLyrNSS0+xJgM9OhEZinR5HxgEsoriTc0NjEzsjQyszAy MTcnTVhJnPdAq3WgkEB6YklqdmpqQWoRzBYmDk6pBsZDwmu9ki5zb3Y6b+aibv5x/88pbfKy trne+xlZWcX1PDuVJrZx1jxZx/5d/1GwtKpXqXi9eMb3+5rtc7KlBUT5zt8KTfzgkiDt9FAg KcpOO/c2B09f0uupfLl7V2qJyesePHk4Ui1H9Yul3AHODIHDZYdSZ07R7eFulJok+KO6Ybtz sNUWJZbijERDLeai4kQA19uACDgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/b2c2/flexcop-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/b2c2/flexcop-pci.c b/drivers/media/pci/b2c2/flexcop-pci.c index 447afbd..8b5e0b3 100644 --- a/drivers/media/pci/b2c2/flexcop-pci.c +++ b/drivers/media/pci/b2c2/flexcop-pci.c @@ -319,7 +319,6 @@ static int flexcop_pci_init(struct flexcop_pci *fc_pci) err_pci_iounmap: pci_iounmap(fc_pci->pdev, fc_pci->io_mem); - pci_set_drvdata(fc_pci->pdev, NULL); err_pci_release_regions: pci_release_regions(fc_pci->pdev); err_pci_disable_device: @@ -332,7 +331,6 @@ static void flexcop_pci_exit(struct flexcop_pci *fc_pci) if (fc_pci->init_state & FC_PCI_INIT) { free_irq(fc_pci->pdev->irq, fc_pci); pci_iounmap(fc_pci->pdev, fc_pci->io_mem); - pci_set_drvdata(fc_pci->pdev, NULL); pci_release_regions(fc_pci->pdev); pci_disable_device(fc_pci->pdev); }