From patchwork Mon Sep 23 01:54:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925911 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A9A899F288 for ; Mon, 23 Sep 2013 01:54:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E1E98200F8 for ; Mon, 23 Sep 2013 01:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 138D2200E7 for ; Mon, 23 Sep 2013 01:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172Ab3IWByf (ORCPT ); Sun, 22 Sep 2013 21:54:35 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:18561 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152Ab3IWBye (ORCPT ); Sun, 22 Sep 2013 21:54:34 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00CCW2MPUWD0@mailout4.samsung.com> for linux-media@vger.kernel.org; Mon, 23 Sep 2013 10:54:28 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 39.0B.30629.35F9F325; Mon, 23 Sep 2013 10:54:27 +0900 (KST) X-AuditID: cbfee68d-b7fe86d0000077a5-bc-523f9f532606 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id F5.5B.09055.35F9F325; Mon, 23 Sep 2013 10:54:27 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK00ECR2MRH280@mmp1.samsung.com>; Mon, 23 Sep 2013 10:54:27 +0900 (KST) From: Jingoo Han To: 'Mauro Carvalho Chehab' Cc: linux-media@vger.kernel.org, 'Jingoo Han' , 'Hans Verkuil' References: <003601ceb7fe$462af680$d280e380$%han@samsung.com> In-reply-to: <003601ceb7fe$462af680$d280e380$%han@samsung.com> Subject: [PATCH 09/10] [media] cx88: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:54:27 +0900 Message-id: <003f01ceb7ff$d60bbcc0$82233640$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63/kYUWuo+na92TD2gsbPKJKhaiAAAXFbA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsVy+t8zA93g+fZBBs/PG1gs+bmLyeLywkus Fj0btrJaXFwn78DiMeX3RlaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgypjy7jR7wRzeiiNv W5kaGOdzdzFyckgImEhMeH+WGcIWk7hwbz1bFyMXh5DAMkaJBe0HWbsYOcCKjh8ygIgvYpRo etDHCOH8YpR41f+BHaSbTUBN4suXw2C2iICRxI75c5hAbGaBPInNH2+xgthCArYSzbM/soHY nAJ2Er/3bgarERbwlPh6agpYL4uAqsT6VcvB4rxA9Y2zT7JC2IISPybfY4GYqSWxfudxqPny EpvXvGWGOFRd4tFfXZgT/k6eC1UiIrHvxTuwmyUEdrFL9E78xAaxS0Di2+RDLBC9shKbDkAD QlLi4IobLBMYJWYh2TwLyeZZSDbPQrJiASPLKkbR1ILkguKk9CJDveLE3OLSvHS95PzcTYyQ SOzdwXj7gPUhxmSg9ROZpUST84GRnFcSb2hsZmRhamJqbGRuaUaasJI4r1qLdaCQQHpiSWp2 ampBalF8UWlOavEhRiYOTqkGxqSbha7XZ/4MW2Ade7vi3wJ5dT3+FZr7zkXLV7Q371kx27ro 5ZUH+0pL18zdfJVpaZVY98LUJ+deb2Fev3ClPHemsV9+AGfSkp6GSUabJs1leqjGmPC6sXnN pu82ekHvL+hG2wmocJbvfHXzeevUpLvX174xVpzglm9wYn1mgdzek/8tZ3yaw67EUpyRaKjF XFScCAAa87GE2gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCKsWRmVeSWpSXmKPExsVy+t9jAd3g+fZBBs33dSyW/NzFZHF54SVW i54NW1ktLq6Td2DxmPJ7I6tH35ZVjB6fN8kFMEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvH m5oZGOoaWlqYKynkJeam2iq5+AToumXmAG1TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesb EgTXY2SABhLWMWZMeXeavWAOb8WRt61MDYzzubsYOTgkBEwkjh8y6GLkBDLFJC7cW8/WxcjF ISSwiFGi6UEfI4Tzi1HiVf8HdpAqNgE1iS9fDoPZIgJGEjvmz2ECsZkF8iQ2f7zFCmILCdhK NM/+yAZicwrYSfzeuxmsRljAU+LrqSlgvSwCqhLrVy0Hi/MC1TfOPskKYQtK/Jh8jwVippbE +p3HoebLS2xe85YZ4mh1iUd/dWFO+Dt5LlSJiMS+F+8YJzAKzUIyaRaSSbOQTJqFpGUBI8sq RtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjOA4fya1g3Flg8UhRgEORiUe3ohE+yAh1sSy4src Q4wSHMxKIrxNnUAh3pTEyqrUovz4otKc1OJDjMlAj05klhJNzgemoLySeENjEzMjSyMzCyMT c3PShJXEeQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYOy/EHHrrmP7bfM0vSX+d3ozGYQu3hNY YsXi4S7V8VP+096SmRwlkSdPLTwaKprEwLe9ROxrjVOjwZqNHD3L7kWX/jL7vv5WTNLH3iVr rDwt5DQnljl4Xmc89vdc0OVl5xwqVjX6S55K/XzFZfm9qQlik95dDnY7M0O2xZUnW1KuNuZz 58mIV0osxRmJhlrMRcWJAC+ladk3AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/media/pci/cx88/cx88-alsa.c | 2 -- drivers/media/pci/cx88/cx88-mpeg.c | 1 - drivers/media/pci/cx88/cx88-video.c | 1 - 3 files changed, 4 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-alsa.c b/drivers/media/pci/cx88/cx88-alsa.c index aba5b1c..05428bf 100644 --- a/drivers/media/pci/cx88/cx88-alsa.c +++ b/drivers/media/pci/cx88/cx88-alsa.c @@ -935,8 +935,6 @@ static void cx88_audio_finidev(struct pci_dev *pci) snd_card_free((void *)card); - pci_set_drvdata(pci, NULL); - devno--; } diff --git a/drivers/media/pci/cx88/cx88-mpeg.c b/drivers/media/pci/cx88/cx88-mpeg.c index 2d3507e..86d2008 100644 --- a/drivers/media/pci/cx88/cx88-mpeg.c +++ b/drivers/media/pci/cx88/cx88-mpeg.c @@ -520,7 +520,6 @@ static void cx8802_fini_common(struct cx8802_dev *dev) /* unregister stuff */ free_irq(dev->pci->irq, dev); - pci_set_drvdata(dev->pci, NULL); /* free memory */ btcx_riscmem_free(dev->pci,&dev->mpegq.stopper); diff --git a/drivers/media/pci/cx88/cx88-video.c b/drivers/media/pci/cx88/cx88-video.c index ecf21d9..d3c2c7f 100644 --- a/drivers/media/pci/cx88/cx88-video.c +++ b/drivers/media/pci/cx88/cx88-video.c @@ -1922,7 +1922,6 @@ static void cx8800_finidev(struct pci_dev *pci_dev) free_irq(pci_dev->irq, dev); cx8800_unregister_video(dev); - pci_set_drvdata(pci_dev, NULL); /* free memory */ btcx_riscmem_free(dev->pci,&dev->vidq.stopper);