From patchwork Fri Sep 14 09:56:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 10600589 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 79559933 for ; Fri, 14 Sep 2018 09:56:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5475E2B450 for ; Fri, 14 Sep 2018 09:56:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 48AC12B4AB; Fri, 14 Sep 2018 09:56:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19CF32B450 for ; Fri, 14 Sep 2018 09:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbeINPKS (ORCPT ); Fri, 14 Sep 2018 11:10:18 -0400 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:57262 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbeINPKS (ORCPT ); Fri, 14 Sep 2018 11:10:18 -0400 Received: from [IPv6:2001:420:44c1:2579:9054:f36a:9810:f0c2] ([IPv6:2001:420:44c1:2579:9054:f36a:9810:f0c2]) by smtp-cloud7.xs4all.net with ESMTPA id 0kpwgZJPkw2L80kq0gZKeB; Fri, 14 Sep 2018 11:56:32 +0200 To: Linux Media Mailing List From: Hans Verkuil Subject: [PATCH for request_api branch] v4l2-ctrls.c: fix smatch error Message-ID: <0964af69-fd97-ecca-467e-a11b5e731666@xs4all.nl> Date: Fri, 14 Sep 2018 11:56:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-US X-CMAE-Envelope: MS4wfB4vAJ8vJTwmEIFaykA7w0iatIaFpTnAODah7dlsCfg5OnqoQGxNVCUbB29AENWA8NsbE/eTzZT+/BOIucy+pybeHDq0ttfBIeA5ZgW1+DKbgvMHmnfn evE8iXcmM03KGg0MgIXdZBpwjDwx0rNsSyN2qESgv9AAGvCuheefUxOQrGWVmb6czqYP4hUyoZmdcgjFnclrU8gwXGYmOYhIn8YDRM14FLvCfEbBAYY5t7To 5g1mkrGAIm5jHqxA4CR0+UgaUmdtxD/ydmfsuK/FCxKoibLrY+g1JDoOhrcxIork Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix this smatch error: drivers/media/v4l2-core/v4l2-ctrls.c:2971 v4l2_ctrl_request_clone() error: uninitialized symbol 'err'. Signed-off-by: Hans Verkuil diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 73665c7d7045..65e3cf838ac7 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -2942,7 +2942,7 @@ static int v4l2_ctrl_request_clone(struct v4l2_ctrl_handler *hdl, const struct v4l2_ctrl_handler *from) { struct v4l2_ctrl_ref *ref; - int err; + int err = 0; if (WARN_ON(!hdl || hdl == from)) return -EINVAL;