diff mbox

cx231xx: Remove a bogus check for null

Message ID 12286cf71e652fa7fe6edfae04dbf1d46f9681df.1415046679.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Nov. 3, 2014, 8:39 p.m. UTC
As reported by kbuild test robot:
	drivers/media/usb/cx231xx/cx231xx-audio.c:445:16-20: ERROR: dev is NULL but dereferenced.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
diff mbox

Patch

diff --git a/drivers/media/usb/cx231xx/cx231xx-audio.c b/drivers/media/usb/cx231xx/cx231xx-audio.c
index 6d9a03402faf..de4ae5eb4830 100644
--- a/drivers/media/usb/cx231xx/cx231xx-audio.c
+++ b/drivers/media/usb/cx231xx/cx231xx-audio.c
@@ -439,12 +439,6 @@  static int snd_cx231xx_capture_open(struct snd_pcm_substream *substream)
 	dev_dbg(dev->dev,
 		"opening device and trying to acquire exclusive lock\n");
 
-	if (!dev) {
-		dev_err(dev->dev,
-			"BUG: cx231xx can't find device struct. Can't proceed with open\n");
-		return -ENODEV;
-	}
-
 	if (dev->state & DEV_DISCONNECTED) {
 		dev_err(dev->dev,
 			"Can't open. the device was removed.\n");