From patchwork Wed Jan 21 00:38:39 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaswinder Singh Rajput X-Patchwork-Id: 3374 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n0L0Zffh004593 for ; Tue, 20 Jan 2009 16:35:41 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757202AbZAUAkJ (ORCPT ); Tue, 20 Jan 2009 19:40:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756962AbZAUAkH (ORCPT ); Tue, 20 Jan 2009 19:40:07 -0500 Received: from hera.kernel.org ([140.211.167.34]:55336 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756875AbZAUAkE (ORCPT ); Tue, 20 Jan 2009 19:40:04 -0500 Received: from [192.168.1.3] (triband-del-59.180.61.40.bol.net.in [59.180.61.40] (may be forged)) (authenticated bits=0) by hera.kernel.org (8.14.2/8.13.8) with ESMTP id n0L0cjsc019726 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 21 Jan 2009 00:38:49 GMT Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings From: Jaswinder Singh Rajput To: "H. Peter Anvin" Cc: Sam Ravnborg , David Woodhouse , Ingo Molnar , x86 maintainers , urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de, linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org, greg@kroah.com, linux-usb@vger.kernel.org, linux-mtd@lists.infradead.org, tiwai@suse.de, mchehab@infradead.org, LKML , Andrew Morton In-Reply-To: <49725B1E.604@kernel.org> References: <1232223441.3966.22.camel@localhost.localdomain> <1232228261.27094.0.camel@macbook.infradead.org> <20090117221932.GA4956@uranus.ravnborg.org> <49725B1E.604@kernel.org> Date: Wed, 21 Jan 2009 06:08:39 +0530 Message-Id: <1232498319.3123.34.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-3.fc10) X-Virus-Scanned: ClamAV 0.93.3/8881/Tue Jan 20 14:48:51 2009 on hera.kernel.org X-Virus-Status: Clean Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote: > Sam Ravnborg wrote: > >>> > >> That patch looks wrong, and unnecessary. It was fine before. > > Nope - include/linux/dvb/audio.h failed to include linux/types.h > > despite the fact that is uses __u32 etc. > > > > But why the _kernel_ should include a userspace header is > > much more questionable. > > > > is one of a handful of headers provided by gcc itself. > Should I reintroduce my patch to solve this warning of 'make headers_check': usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include Or you guys have some better plan. Thanks, --- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h index 89412e1..758a48c 100644 --- a/include/linux/dvb/audio.h +++ b/include/linux/dvb/audio.h @@ -24,9 +24,8 @@ #ifndef _DVBAUDIO_H_ #define _DVBAUDIO_H_ -#ifdef __KERNEL__ #include -#else +#ifndef __KERNEL__ #include #endif